From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Bjorn Helgaas' <bhelgaas@google.com>,
'Wei Yongjun' <weiyj.lk@gmail.com>,
'Kukjin Kim' <kgene.kim@samsung.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
'Grant Likely' <grant.likely@linaro.org>,
'Rob Herring' <rob.herring@calxeda.com>,
'Seungwon Jeon' <tgih.jun@samsung.com>,
'Wei Yongjun' <yongjun_wei@trendmicro.com.cn>
Subject: Re: [PATCH] PCI: exynos: missing clk_disable_unprepare() on error in exynos_pcie_probe()
Date: Tue, 01 Oct 2013 15:49:23 +0200 [thread overview]
Message-ID: <524AD2E3.9010808@gmail.com> (raw)
In-Reply-To: <000301cebe46$42e86e00$c8b94a00$%han@samsung.com>
On 10/01/2013 03:33 AM, Jingoo Han wrote:
> On Sunday, September 29, 2013 11:29 AM, Wei Yongjun wrote:
>>
>> From: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
>>
>> Add the missing clk_disable_unprepare() before return
>> from exynos_pcie_probe() in the error handling case.
>>
>> Signed-off-by: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
>
> Acked-by: Jingoo Han<jg1.han@samsung.com>
>
> However, the commit name should be fixed as below:
> [PATCH] PCI: exynos: use missing clk_disable_unprepare() on error in exynos_pcie_probe()
Perhaps just:
"PCI: exynos: Add missing clk_disable_unprepare() on error path
How can something that is missing be used ? :)
WARNING: multiple messages have this Message-ID (diff)
From: sylvester.nawrocki@gmail.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: exynos: missing clk_disable_unprepare() on error in exynos_pcie_probe()
Date: Tue, 01 Oct 2013 15:49:23 +0200 [thread overview]
Message-ID: <524AD2E3.9010808@gmail.com> (raw)
In-Reply-To: <000301cebe46$42e86e00$c8b94a00$%han@samsung.com>
On 10/01/2013 03:33 AM, Jingoo Han wrote:
> On Sunday, September 29, 2013 11:29 AM, Wei Yongjun wrote:
>>
>> From: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
>>
>> Add the missing clk_disable_unprepare() before return
>> from exynos_pcie_probe() in the error handling case.
>>
>> Signed-off-by: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
>
> Acked-by: Jingoo Han<jg1.han@samsung.com>
>
> However, the commit name should be fixed as below:
> [PATCH] PCI: exynos: use missing clk_disable_unprepare() on error in exynos_pcie_probe()
Perhaps just:
"PCI: exynos: Add missing clk_disable_unprepare() on error path
How can something that is missing be used ? :)
next prev parent reply other threads:[~2013-10-01 13:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-29 2:29 [PATCH] PCI: exynos: missing clk_disable_unprepare() on error in exynos_pcie_probe() Wei Yongjun
2013-09-29 2:29 ` Wei Yongjun
2013-10-01 1:33 ` Jingoo Han
2013-10-01 1:33 ` Jingoo Han
2013-10-01 13:49 ` Sylwester Nawrocki [this message]
2013-10-01 13:49 ` Sylwester Nawrocki
2013-10-01 23:44 ` Jingoo Han
2013-10-01 23:44 ` Jingoo Han
2013-10-04 22:50 ` Bjorn Helgaas
2013-10-04 22:50 ` Bjorn Helgaas
2013-10-04 22:50 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524AD2E3.9010808@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=bhelgaas@google.com \
--cc=grant.likely@linaro.org \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=tgih.jun@samsung.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.