* [PATCH] xfs: Use kmem_free() instead of free()
@ 2013-10-01 14:47 ` Thierry Reding
0 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2013-10-01 14:47 UTC (permalink / raw)
To: Ben Myers, Alex Elder; +Cc: linux-kernel, xfs
This fixes a build failure caused by calling the free() function which
does not exist in the Linux kernel.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
fs/xfs/xfs_log_recover.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index 4324058..3979749 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -1585,7 +1585,7 @@ xlog_recover_add_to_trans(
"bad number of regions (%d) in inode log format",
in_f->ilf_size);
ASSERT(0);
- free(ptr);
+ kmem_free(ptr);
return XFS_ERROR(EIO);
}
--
1.8.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] xfs: Use kmem_free() instead of free()
@ 2013-10-01 14:47 ` Thierry Reding
0 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2013-10-01 14:47 UTC (permalink / raw)
To: Ben Myers, Alex Elder; +Cc: xfs, linux-kernel
This fixes a build failure caused by calling the free() function which
does not exist in the Linux kernel.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
fs/xfs/xfs_log_recover.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index 4324058..3979749 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -1585,7 +1585,7 @@ xlog_recover_add_to_trans(
"bad number of regions (%d) in inode log format",
in_f->ilf_size);
ASSERT(0);
- free(ptr);
+ kmem_free(ptr);
return XFS_ERROR(EIO);
}
--
1.8.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs: Use kmem_free() instead of free()
2013-10-01 14:47 ` Thierry Reding
@ 2013-10-01 15:00 ` Mark Tinguely
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Tinguely @ 2013-10-01 15:00 UTC (permalink / raw)
To: Thierry Reding; +Cc: Ben Myers, Alex Elder, linux-kernel, xfs
On 10/01/13 09:47, Thierry Reding wrote:
> This fixes a build failure caused by calling the free() function which
> does not exist in the Linux kernel.
>
> Signed-off-by: Thierry Reding<treding@nvidia.com>
> ---
> fs/xfs/xfs_log_recover.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> index 4324058..3979749 100644
> --- a/fs/xfs/xfs_log_recover.c
> +++ b/fs/xfs/xfs_log_recover.c
> @@ -1585,7 +1585,7 @@ xlog_recover_add_to_trans(
> "bad number of regions (%d) in inode log format",
> in_f->ilf_size);
> ASSERT(0);
> - free(ptr);
> + kmem_free(ptr);
> return XFS_ERROR(EIO);
> }
>
Looks good. I will remove the other list items in another patch.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs: Use kmem_free() instead of free()
@ 2013-10-01 15:00 ` Mark Tinguely
0 siblings, 0 replies; 6+ messages in thread
From: Mark Tinguely @ 2013-10-01 15:00 UTC (permalink / raw)
To: Thierry Reding; +Cc: Ben Myers, Alex Elder, linux-kernel, xfs
On 10/01/13 09:47, Thierry Reding wrote:
> This fixes a build failure caused by calling the free() function which
> does not exist in the Linux kernel.
>
> Signed-off-by: Thierry Reding<treding@nvidia.com>
> ---
> fs/xfs/xfs_log_recover.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> index 4324058..3979749 100644
> --- a/fs/xfs/xfs_log_recover.c
> +++ b/fs/xfs/xfs_log_recover.c
> @@ -1585,7 +1585,7 @@ xlog_recover_add_to_trans(
> "bad number of regions (%d) in inode log format",
> in_f->ilf_size);
> ASSERT(0);
> - free(ptr);
> + kmem_free(ptr);
> return XFS_ERROR(EIO);
> }
>
Looks good. I will remove the other list items in another patch.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs: Use kmem_free() instead of free()
2013-10-01 15:00 ` Mark Tinguely
@ 2013-10-01 15:22 ` Ben Myers
-1 siblings, 0 replies; 6+ messages in thread
From: Ben Myers @ 2013-10-01 15:22 UTC (permalink / raw)
To: Mark Tinguely; +Cc: Alex Elder, Thierry Reding, linux-kernel, xfs
On Tue, Oct 01, 2013 at 10:00:43AM -0500, Mark Tinguely wrote:
> On 10/01/13 09:47, Thierry Reding wrote:
> >This fixes a build failure caused by calling the free() function which
> >does not exist in the Linux kernel.
> >
> >Signed-off-by: Thierry Reding<treding@nvidia.com>
> >---
> > fs/xfs/xfs_log_recover.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> >index 4324058..3979749 100644
> >--- a/fs/xfs/xfs_log_recover.c
> >+++ b/fs/xfs/xfs_log_recover.c
> >@@ -1585,7 +1585,7 @@ xlog_recover_add_to_trans(
> > "bad number of regions (%d) in inode log format",
> > in_f->ilf_size);
> > ASSERT(0);
> >- free(ptr);
> >+ kmem_free(ptr);
> > return XFS_ERROR(EIO);
> > }
> >
>
> Looks good. I will remove the other list items in another patch.
>
> Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Gah. Build Fail. Apparently things were getting a little punchy over here.
Applied, and thanks Thierry.
-Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs: Use kmem_free() instead of free()
@ 2013-10-01 15:22 ` Ben Myers
0 siblings, 0 replies; 6+ messages in thread
From: Ben Myers @ 2013-10-01 15:22 UTC (permalink / raw)
To: Mark Tinguely; +Cc: Thierry Reding, Alex Elder, linux-kernel, xfs
On Tue, Oct 01, 2013 at 10:00:43AM -0500, Mark Tinguely wrote:
> On 10/01/13 09:47, Thierry Reding wrote:
> >This fixes a build failure caused by calling the free() function which
> >does not exist in the Linux kernel.
> >
> >Signed-off-by: Thierry Reding<treding@nvidia.com>
> >---
> > fs/xfs/xfs_log_recover.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> >index 4324058..3979749 100644
> >--- a/fs/xfs/xfs_log_recover.c
> >+++ b/fs/xfs/xfs_log_recover.c
> >@@ -1585,7 +1585,7 @@ xlog_recover_add_to_trans(
> > "bad number of regions (%d) in inode log format",
> > in_f->ilf_size);
> > ASSERT(0);
> >- free(ptr);
> >+ kmem_free(ptr);
> > return XFS_ERROR(EIO);
> > }
> >
>
> Looks good. I will remove the other list items in another patch.
>
> Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Gah. Build Fail. Apparently things were getting a little punchy over here.
Applied, and thanks Thierry.
-Ben
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-01 15:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-01 14:47 [PATCH] xfs: Use kmem_free() instead of free() Thierry Reding
2013-10-01 14:47 ` Thierry Reding
2013-10-01 15:00 ` Mark Tinguely
2013-10-01 15:00 ` Mark Tinguely
2013-10-01 15:22 ` Ben Myers
2013-10-01 15:22 ` Ben Myers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.