From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Anton Vorontsov <anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Manish Badarkhe
<badarkhe.manish-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Darbha Sriharsha
<dsriharsha-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [Patch V4] drivers: power: Add support for bq24735 charger
Date: Tue, 01 Oct 2013 14:00:46 -0600 [thread overview]
Message-ID: <524B29EE.4090608@wwwdotorg.org> (raw)
In-Reply-To: <1380211376-7539-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 09/26/2013 10:02 AM, Rhyland Klein wrote:
> From: Darbha Sriharsha <dsriharsha-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Adds support for the bq24735 charger chipset. The bq24735 is a
> high-efficiency, synchronous battery charger.
>
> It allows control of the charging current, input current, and the charger
> voltage DAC's through SMBus.
> diff --git a/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt b/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt
> +Optional properties :
> + - ti,charge-current : Used to control and set the charging current. This value
> + must be between 128mA and 8.128A with a 64mA step resolution. The POR value
> + is 0x0000h. See spec for more details.
> + - ti,charge-voltage : Used to control and set the charging voltage. This value
> + must be between 1.024V and 19.2V with a 16mV step resolution. The POR value
> + is 0x0000h. See spec for more details.
> + - ti,input-current : Used to control and set the charger input current. This
> + value must be between 128mA and 8.064A with a 128mA step resolution. The
> + POR value is 0x1000h. See spec for more details.
What units and representation do those properties use? I assume it's mA
and mV, without any shift or register encoding, but the text doesn't
make it clear. It'd be best to reference a specific register name rather
than just saying "see the spec".
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Rhyland Klein <rklein@nvidia.com>
Cc: Anton Vorontsov <anton@enomsg.org>,
David Woodhouse <dwmw2@infradead.org>,
Manish Badarkhe <badarkhe.manish@gmail.com>,
Darbha Sriharsha <dsriharsha@nvidia.com>,
Stephen Warren <swarren@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [Patch V4] drivers: power: Add support for bq24735 charger
Date: Tue, 01 Oct 2013 14:00:46 -0600 [thread overview]
Message-ID: <524B29EE.4090608@wwwdotorg.org> (raw)
In-Reply-To: <1380211376-7539-1-git-send-email-rklein@nvidia.com>
On 09/26/2013 10:02 AM, Rhyland Klein wrote:
> From: Darbha Sriharsha <dsriharsha@nvidia.com>
>
> Adds support for the bq24735 charger chipset. The bq24735 is a
> high-efficiency, synchronous battery charger.
>
> It allows control of the charging current, input current, and the charger
> voltage DAC's through SMBus.
> diff --git a/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt b/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt
> +Optional properties :
> + - ti,charge-current : Used to control and set the charging current. This value
> + must be between 128mA and 8.128A with a 64mA step resolution. The POR value
> + is 0x0000h. See spec for more details.
> + - ti,charge-voltage : Used to control and set the charging voltage. This value
> + must be between 1.024V and 19.2V with a 16mV step resolution. The POR value
> + is 0x0000h. See spec for more details.
> + - ti,input-current : Used to control and set the charger input current. This
> + value must be between 128mA and 8.064A with a 128mA step resolution. The
> + POR value is 0x1000h. See spec for more details.
What units and representation do those properties use? I assume it's mA
and mV, without any shift or register encoding, but the text doesn't
make it clear. It'd be best to reference a specific register name rather
than just saying "see the spec".
next prev parent reply other threads:[~2013-10-01 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 16:02 [Patch V4] drivers: power: Add support for bq24735 charger Rhyland Klein
2013-09-26 16:02 ` Rhyland Klein
[not found] ` <1380211376-7539-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-01 20:00 ` Stephen Warren [this message]
2013-10-01 20:00 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524B29EE.4090608@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org \
--cc=badarkhe.manish-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dsriharsha-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.