Re: [PATCH 2/7] arm: dts: add dra7 IVA thermal data

From: Eduardo Valentin <eduardo.valentin-l0cyMroinI0@public.gmane.org>
To: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
Cc: Eduardo Valentin <eduardo.valentin-l0cyMroinI0@public.gmane.org>,
	swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
	linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org,
	rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/7] arm: dts: add dra7 IVA thermal data
Date: Tue, 1 Oct 2013 21:26:31 -0400	[thread overview]
Message-ID: <524B7647.9050208@ti.com> (raw)
In-Reply-To: <20131001223337.GA11451@kahuna>

[-- Attachment #1: Type: text/plain, Size: 2252 bytes --]

On 01-10-2013 18:33, Nishanth Menon wrote:
> On 14:32-20131001, Eduardo Valentin wrote:
> minor comments follow
>> This patch changes a dtsi file to contain the thermal data
> s/changes/introduces?
>> for IVA domain on DRA7 and later SoCs. This data will
>> enable a thermal shutdown at 125C.
>>
>> This thermal data can be reused across TI SoC devices.
> is'nt it just DRA7 that reuses this - based on dtsi name?

For now, yes, but the file is intended to be reusable. just like the
file with cpu thermal zone is reusable on omap4/5/dra devices.

>>
>> Signed-off-by: Eduardo Valentin <eduardo.valentin-l0cyMroinI0@public.gmane.org>
>> ---
>>  arch/arm/boot/dts/dra7-iva-thermal.dtsi | 28 ++++++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/dra7-iva-thermal.dtsi
>>
>> diff --git a/arch/arm/boot/dts/dra7-iva-thermal.dtsi b/arch/arm/boot/dts/dra7-iva-thermal.dtsi
>> new file mode 100644
>> index 0000000..fea0cea
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/dra7-iva-thermal.dtsi
>> @@ -0,0 +1,28 @@
>> +/*
>> + * Device Tree Source for DRA7 SoC IVA thermal
>> + *
>> + * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/
>> + * Contact: Eduardo Valentin <eduardo.valentin-l0cyMroinI0@public.gmane.org>
>> + *
>> + * This file is licensed under the terms of the GNU General Public License
>> + * version 2.  This program is licensed "as is" without any warranty of any
>> + * kind, whether express or implied.
>> + */
>> +
>> +#include <dt-bindings/thermal/thermal.h>
>> +
>> +iva_thermal: iva_thermal {
>> +	polling-delay-passive = <250>; /* milliseconds */
>> +	polling-delay = <1000>; /* milliseconds */
>> +
>> +		/* sensor       ID */
> ^^ double tab here?
>> +	thermal-sensors = <&bandgap     4>;
> space after bandgap is good enough?

Those tabulation were intentional, to hint that 4 means sensor id.

>> +
>> +	trips {
>> +		iva_crit: iva_crit {
>> +			temperature = <125000>; /* milliCelsius */
>> +			hysteresis = <2000>; /* milliCelsius */
>> +			type = THERMAL_TRIP_CRITICAL;
>> +		};
>> +	};
>> +};
> 

-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]