From: Valentine <valentine.barshak@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 5/6] arm: shmobile: lager: Add internal PCI support
Date: Wed, 02 Oct 2013 12:17:00 +0000 [thread overview]
Message-ID: <524C0EBC.5010105@cogentembedded.com> (raw)
In-Reply-To: <1380652251-8143-6-git-send-email-valentine.barshak@cogentembedded.com>
On 10/02/2013 04:18 AM, Kuninori Morimoto wrote:
>
> Hi Valentine
Hi Morimoto-san,
>
>> This adds internal PCI/USB host support to Lager board.
>> There are 3 internal PCI bus controllers with only a EHCI/OHCI
>> device present on each one. This gives us 3 USB host channels.
>> Channel 0 is shared with the USBHS function module.
>> Channel 2 is shared with the USBSS (XHCI) device.
>>
>> Currently no channel configuration is supported,
>> and the default settings are assumed:
>> Channel 0 - USBHS
>> Channel 1 - PCI/USB host
>> Channel 2 - PCI/USB host
>>
>> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
>> ---
> (snip)
>> /* USB0 */
>> - PIN_MAP_MUX_GROUP_DEFAULT("renesas_usbhs", "pfc-r8a7790",
>> + PIN_MAP_MUX_GROUP_DEFAULT(LAGER_USB0_DEVNAME, "pfc-r8a7790",
>> "usb0", "usb0"),
>
> I found definition of "LAGER_USB0_DEVNAME" on [6/6] patch,
> but [5/6] patch is using it.
>
Good catch. Thanks!
> Best regards
> ---
> Kuninori Morimoto
>
Thanks,
Val.
next prev parent reply other threads:[~2013-10-02 12:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 18:30 [PATCH 5/6] arm: shmobile: lager: Add internal PCI support Valentine Barshak
2013-10-02 0:18 ` Kuninori Morimoto
2013-10-02 0:24 ` Magnus Damm
2013-10-02 12:17 ` Valentine [this message]
2013-10-02 12:36 ` Valentine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524C0EBC.5010105@cogentembedded.com \
--to=valentine.barshak@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.