From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Beomho Seo <beomho.seo@samsung.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
pawel.moll@arm.com, Mark Rutland <mark.rutland@arm.com>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
myungjoo.ham@samsung.com, Jaehoon Chung <jh80.chung@samsung.com>,
Peter Meerwald l <pmeerw@pmeerw.net>
Subject: Re: [PATCH v5 1/2] iio: cm36651: Add CM36651 proximity/light sensor
Date: Thu, 03 Oct 2013 10:36:28 +0200 [thread overview]
Message-ID: <524D2C8C.3010502@metafoo.de> (raw)
In-Reply-To: <524B3E0D.3040803@kernel.org>
On 10/01/2013 11:26 PM, Jonathan Cameron wrote:
> On 10/01/13 13:55, Beomho Seo wrote:
>>
>> This patch adds a new driver for Capella CM36651 proximity and RGB sensor.
>>
>> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> A couple of little points inline. In short, some unnecessary
> variable initializations (bad idea as they may hide real bugs)
> and you should use IRQF_DISABLED if you really do need to have
> the interrupt disabled.
IRQF_DISABLED actually does something else (or well did something else,
these days it's a no-op and shouldn't be used). But yea, a flag that keeps
the interrupt disabled would be nice.
>
> Also, sorry if I missed an explanation, but I can't see why you need
> the enable and disable on the interrupt. As you explicitly turn the
> interrupt on by writing to a device register why would an interrupt
> occur at any other time? Convention is normally to not do the disabling
> of the irq unless it is actually necessary. It complicates
> the code for no gain.
Yep, I don't see any reason why the code actually has to use
enable_irq/disable_irq. Unless there is a problem with the chip that it
tends to generate lots of spurious interrupts. In that case this should be
documented in the code though.
- Lars
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
To: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Beomho Seo <beomho.seo-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
"linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org"
<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org"
<ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>,
Sylwester Nawrocki
<s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Jacek Anaszewski
<j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
Jaehoon Chung
<jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Peter Meerwald l <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>
Subject: Re: [PATCH v5 1/2] iio: cm36651: Add CM36651 proximity/light sensor
Date: Thu, 03 Oct 2013 10:36:28 +0200 [thread overview]
Message-ID: <524D2C8C.3010502@metafoo.de> (raw)
In-Reply-To: <524B3E0D.3040803-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On 10/01/2013 11:26 PM, Jonathan Cameron wrote:
> On 10/01/13 13:55, Beomho Seo wrote:
>>
>> This patch adds a new driver for Capella CM36651 proximity and RGB sensor.
>>
>> Signed-off-by: Beomho Seo <beomho.seo-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> A couple of little points inline. In short, some unnecessary
> variable initializations (bad idea as they may hide real bugs)
> and you should use IRQF_DISABLED if you really do need to have
> the interrupt disabled.
IRQF_DISABLED actually does something else (or well did something else,
these days it's a no-op and shouldn't be used). But yea, a flag that keeps
the interrupt disabled would be nice.
>
> Also, sorry if I missed an explanation, but I can't see why you need
> the enable and disable on the interrupt. As you explicitly turn the
> interrupt on by writing to a device register why would an interrupt
> occur at any other time? Convention is normally to not do the disabling
> of the irq unless it is actually necessary. It complicates
> the code for no gain.
Yep, I don't see any reason why the code actually has to use
enable_irq/disable_irq. Unless there is a problem with the chip that it
tends to generate lots of spurious interrupts. In that case this should be
documented in the code though.
- Lars
next prev parent reply other threads:[~2013-10-03 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 12:55 [PATCH v5 1/2] iio: cm36651: Add CM36651 proximity/light sensor Beomho Seo
2013-10-01 12:55 ` Beomho Seo
2013-10-01 21:26 ` Jonathan Cameron
2013-10-01 21:26 ` Jonathan Cameron
2013-10-03 8:36 ` Lars-Peter Clausen [this message]
2013-10-03 8:36 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524D2C8C.3010502@metafoo.de \
--to=lars@metafoo.de \
--cc=beomho.seo@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=ian.campbell@citrix.com \
--cc=j.anaszewski@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=rob.herring@calxeda.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.