[U-Boot] [UBOOT]: Mcspi/qspi conflicting configs leading to build failure.

[U-Boot] [UBOOT]: Mcspi/qspi conflicting configs leading to build failure.

[Sourav Poddar]

Hi Jagan,

If you see the mcspi defconfig(CONFIG_OMAP3_SPI), it is moved to
common file "include/configs/ti_armv7_common.h" . But with this, now after
adding qspi the build breaks like this..

ti_qspi.o: In function `spi_cs_is_valid':
/home/a0131647/clone/u-boot/drivers/spi/ti_qspi.c:108: multiple 
definition of `spi_cs_is_valid'
omap3_spi.o:/home/a0131647/clone/u-boot/drivers/spi/omap3_spi.c:415: 
first defined here
ti_qspi.o: In function `spi_cs_activate':
/home/a0131647/clone/u-boot/drivers/spi/ti_qspi.c:114: multiple 
definition of `spi_cs_activate'
omap3_spi.o:/home/a0131647/clone/u-boot/drivers/spi/omap3_spi.c:419: 
first defined here
ti_qspi.o: In function `spi_cs_deactivate':
/home/a0131647/clone/u-boot/drivers/spi/ti_qspi.c:120: multiple 
definition of `spi_cs_deactivate'
omap3_spi.o:/home/a0131647/clone/u-boot/drivers/spi/omap3_spi.c:423: 
first defined here
ti_qspi.o: In function `spi_init':
/home/a0131647/clone/u-boot/drivers/spi/ti_qspi.c:125: multiple 
definition of `spi_init'

As of now, I am tackling this by doing a undef CONFIG_OMAP3_SPI in my 
configs.

But, we should have a way to use both(spi/qspi) of them simultaneously ?

[U-Boot] [UBOOT]: Mcspi/qspi conflicting configs leading to build failure.

[Jagan Teki]

On Fri, Oct 4, 2013 at 12:07 AM, Sourav Poddar <sourav.poddar@ti.com> wrote:
> Hi Jagan,
>
> If you see the mcspi defconfig(CONFIG_OMAP3_SPI), it is moved to
> common file "include/configs/ti_armv7_common.h" . But with this, now after
> adding qspi the build breaks like this..
>
> ti_qspi.o: In function `spi_cs_is_valid':
> /home/a0131647/clone/u-boot/drivers/spi/ti_qspi.c:108: multiple definition
> of `spi_cs_is_valid'
> omap3_spi.o:/home/a0131647/clone/u-boot/drivers/spi/omap3_spi.c:415: first
> defined here
> ti_qspi.o: In function `spi_cs_activate':
> /home/a0131647/clone/u-boot/drivers/spi/ti_qspi.c:114: multiple definition
> of `spi_cs_activate'
> omap3_spi.o:/home/a0131647/clone/u-boot/drivers/spi/omap3_spi.c:419: first
> defined here
> ti_qspi.o: In function `spi_cs_deactivate':
> /home/a0131647/clone/u-boot/drivers/spi/ti_qspi.c:120: multiple definition
> of `spi_cs_deactivate'
> omap3_spi.o:/home/a0131647/clone/u-boot/drivers/spi/omap3_spi.c:423: first
> defined here
> ti_qspi.o: In function `spi_init':
> /home/a0131647/clone/u-boot/drivers/spi/ti_qspi.c:125: multiple definition
> of `spi_init'
>
> As of now, I am tackling this by doing a undef CONFIG_OMAP3_SPI in my
> configs.
>
> But, we should have a way to use both(spi/qspi) of them simultaneously ?

As of now there is no way to use both, will do it.. I will add it on TODO.

-- 
Thanks,
Jagan.
--------
Jagannadha Sutradharudu Teki,
E: jagannadh.teki at gmail.com, P: +91-9676773388
Engineer - System Software Hacker
U-boot - SPI Custodian and Zynq APSOC
Ln: http://www.linkedin.com/in/jaganteki