From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH] util/path: Fix type which is longer than 8 bit for MinGW
Date: Sat, 05 Oct 2013 13:10:15 +0400 [thread overview]
Message-ID: <524FD777.40303@msgid.tls.msk.ru> (raw)
In-Reply-To: <1380746429-634-1-git-send-email-sw@weilnetz.de>
03.10.2013 00:40, Stefan Weil wrote:
> While dirent->d_type is 8 bit for most systems, it is 32 bit for MinGW.
> Reducing it to 8 bit results in a compiler warning because the macro
> is_dir_maybe compares that 8 bit value with 32 bit constants.
>
> Using 'unsigned' instead of 'unsigned char' matches the declaration for
> MinGW and does not harm the other systems.
>
> MinGW-w32 is not affected: it does not declare d_type.
That's a good one.
What's the diff between mingw-w32 and mingw?
At any rate, there's - I think - no need to declare it as 'char',
int or unsigned should be just fine.
Thanks, applied to the trivial patches queue.
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] util/path: Fix type which is longer than 8 bit for MinGW
Date: Sat, 05 Oct 2013 13:10:15 +0400 [thread overview]
Message-ID: <524FD777.40303@msgid.tls.msk.ru> (raw)
In-Reply-To: <1380746429-634-1-git-send-email-sw@weilnetz.de>
03.10.2013 00:40, Stefan Weil wrote:
> While dirent->d_type is 8 bit for most systems, it is 32 bit for MinGW.
> Reducing it to 8 bit results in a compiler warning because the macro
> is_dir_maybe compares that 8 bit value with 32 bit constants.
>
> Using 'unsigned' instead of 'unsigned char' matches the declaration for
> MinGW and does not harm the other systems.
>
> MinGW-w32 is not affected: it does not declare d_type.
That's a good one.
What's the diff between mingw-w32 and mingw?
At any rate, there's - I think - no need to declare it as 'char',
int or unsigned should be just fine.
Thanks, applied to the trivial patches queue.
/mjt
next prev parent reply other threads:[~2013-10-05 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 20:40 [Qemu-trivial] [PATCH] util/path: Fix type which is longer than 8 bit for MinGW Stefan Weil
2013-10-02 20:40 ` [Qemu-devel] " Stefan Weil
2013-10-05 9:10 ` Michael Tokarev [this message]
2013-10-05 9:10 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-10-05 9:31 ` Stefan Weil
2013-10-05 9:31 ` [Qemu-devel] " Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524FD777.40303@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.