Re: [Qemu-trivial] [Qemu-devel] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Stefan Weil <sw@weilnetz.de>
To: Michael Tokarev <mjt@tls.msk.ru>, Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)
Date: Sat, 05 Oct 2013 11:36:18 +0200	[thread overview]
Message-ID: <524FDD92.5000809@weilnetz.de> (raw)
In-Reply-To: <524FD99E.8020205@msgid.tls.msk.ru>

Am 05.10.2013 11:19, schrieb Michael Tokarev:
>
> Author: Michael Tokarev <mjt@tls.msk.ru>
> Date:   Sat Oct 5 13:18:28 2013 +0400
>
>     migration: Fix compiler warning ('caps' may be used uninitialized)
>
>     Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>
> diff --git a/migration.c b/migration.c
> index b4f8462..2b1ab20 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -150,6 +150,7 @@ MigrationCapabilityStatusList
> *qmp_query_migrate_capabilitie
>      MigrationState *s = migrate_get_current();
>      int i;
>
> +    caps = NULL; /* silence compiler warning */
>      for (i = 0; i < MIGRATION_CAPABILITY_MAX; i++) {
>          if (head == NULL) {
>              head = g_malloc0(sizeof(*caps));
>
>
> Thanks,
>
> /mjt
>


Reviewed-by: Stefan Weil <sw@weilnetz.de>

WARNING: multiple messages have this Message-ID (diff)

From: Stefan Weil <sw@weilnetz.de>
To: Michael Tokarev <mjt@tls.msk.ru>, Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)
Date: Sat, 05 Oct 2013 11:36:18 +0200	[thread overview]
Message-ID: <524FDD92.5000809@weilnetz.de> (raw)
In-Reply-To: <524FD99E.8020205@msgid.tls.msk.ru>

Am 05.10.2013 11:19, schrieb Michael Tokarev:
>
> Author: Michael Tokarev <mjt@tls.msk.ru>
> Date:   Sat Oct 5 13:18:28 2013 +0400
>
>     migration: Fix compiler warning ('caps' may be used uninitialized)
>
>     Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>
> diff --git a/migration.c b/migration.c
> index b4f8462..2b1ab20 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -150,6 +150,7 @@ MigrationCapabilityStatusList
> *qmp_query_migrate_capabilitie
>      MigrationState *s = migrate_get_current();
>      int i;
>
> +    caps = NULL; /* silence compiler warning */
>      for (i = 0; i < MIGRATION_CAPABILITY_MAX; i++) {
>          if (head == NULL) {
>              head = g_malloc0(sizeof(*caps));
>
>
> Thanks,
>
> /mjt
>


Reviewed-by: Stefan Weil <sw@weilnetz.de>

next prev parent reply	other threads:[~2013-10-05  9:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-29 15:41 [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized) Stefan Weil
2013-09-29 15:41 ` [Qemu-devel] " Stefan Weil
2013-09-29 20:13 ` [Qemu-trivial] " Michael Tokarev
2013-09-29 20:13   ` [Qemu-devel] " Michael Tokarev
2013-09-29 20:33   ` Stefan Weil
2013-09-29 20:33     ` [Qemu-devel] " Stefan Weil
2013-09-30  9:59     ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2013-09-30  9:59       ` [Qemu-devel] [Qemu-trivial] " Markus Armbruster
2013-09-30 20:53       ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2013-09-30 20:53         ` [Qemu-devel] [Qemu-trivial] " Stefan Weil
2013-10-01  8:07         ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2013-10-01  8:07           ` [Qemu-devel] [Qemu-trivial] " Markus Armbruster
2013-10-02 19:02         ` [Qemu-trivial] [Qemu-devel] " Michael Tokarev
2013-10-02 19:02           ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-10-02 20:24           ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2013-10-02 20:24             ` [Qemu-devel] [Qemu-trivial] " Stefan Weil
2013-10-03  8:13             ` [Qemu-trivial] [Qemu-devel] " Paolo Bonzini
2013-10-03  8:13               ` [Qemu-devel] [Qemu-trivial] " Paolo Bonzini
2013-10-05  9:15               ` [Qemu-trivial] [Qemu-devel] " Michael Tokarev
2013-10-05  9:15                 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-10-05  9:19                 ` [Qemu-trivial] [Qemu-devel] " Michael Tokarev
2013-10-05  9:19                   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-10-05  9:36                   ` Stefan Weil [this message]
2013-10-05  9:36                     ` Stefan Weil
2013-10-01 11:39 ` Paolo Bonzini
2013-10-01 11:39   ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524FDD92.5000809@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=armbru@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.