From: Denis Benato <denis.benato@linux.dev>
To: Marco Scardovi <scardracs@disroot.org>, ilpo.jarvinen@linux.intel.com
Cc: corentin.chary@gmail.com, hansg@kernel.org,
linux-kernel@vger.kernel.org, luke@ljones.dev,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: asus-armoury: add support for G614PR
Date: Sun, 14 Jun 2026 14:33:47 +0200 [thread overview]
Message-ID: <524bc16a-6a66-4b2f-8aa6-6a4b0bc31f09@linux.dev> (raw)
In-Reply-To: <20260614084423.50723-2-scardracs@disroot.org>
On 6/14/26 10:44, Marco Scardovi wrote:
> Add TDP power limits and fan curve requirements for the ASUS ROG
> Strix G16 G614PR laptop model.
>
> Add the corresponding DMI board name matching entry ("G614PR") under
> the power_limits table in asus-armoury.h, populating the AC and DC limits
> based on the platform's hardware specification.
In general all these data have been posted in the ppt data collection thread
in form of screenshots (and I'd like to have yours too for future reference).
Your model isn't posted there, so I assumed these values were what is available
to you on the official windows app, if so the previous one has to be kept
unless you find an explanation of why what is see is different from
what you expect to see.
> Assisted-by: Antigravity:gemini-3.5-flash
> Signed-off-by: Marco Scardovi <scardracs@disroot.org>
> ---
> drivers/platform/x86/asus-armoury.h | 34 +++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-armoury.h b/drivers/platform/x86/asus-armoury.h
> index 692978b61959..c2df2381a260 100644
> --- a/drivers/platform/x86/asus-armoury.h
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -1898,6 +1898,40 @@ static const struct dmi_system_id power_limits[] = {
> .requires_fan_curve = true,
> },
> },
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "G614PR"),
> + },
> + .driver_data = &(struct power_data) {
> + .ac_data = &(struct power_limits) {
> + .ppt_pl1_spl_min = 30,
> + .ppt_pl1_spl_max = 120,
> + .ppt_pl2_sppt_min = 65,
> + .ppt_pl2_sppt_def = 140,
> + .ppt_pl2_sppt_max = 145,
> + .ppt_pl3_fppt_min = 65,
> + .ppt_pl3_fppt_def = 140,
> + .ppt_pl3_fppt_max = 145,
> + .nv_temp_target_min = 75,
> + .nv_temp_target_max = 87,
> + .nv_dynamic_boost_min = 5,
> + .nv_dynamic_boost_max = 25,
> + .nv_tgp_min = 65,
> + .nv_tgp_max = 115,
> + },
> + .dc_data = &(struct power_limits) {
> + .ppt_pl1_spl_min = 25,
> + .ppt_pl1_spl_max = 65,
> + .ppt_pl2_sppt_min = 25,
> + .ppt_pl2_sppt_max = 65,
> + .ppt_pl3_fppt_min = 35,
> + .ppt_pl3_fppt_max = 75,
> + .nv_temp_target_min = 75,
> + .nv_temp_target_max = 87,
> + },
> + .requires_fan_curve = true,
> + },
> + },
> {
> .matches = {
> DMI_MATCH(DMI_BOARD_NAME, "G615LR"),
next prev parent reply other threads:[~2026-06-14 12:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 15:21 [PATCH] platform/x86: asus-armoury: add support for G614PR Marco Scardovi
2026-06-10 17:54 ` Denis Benato
2026-06-11 15:02 ` Ilpo Järvinen
2026-06-11 15:53 ` Marco Scardovi
2026-06-14 8:44 ` [PATCH v2 0/1] " Marco Scardovi
2026-06-14 8:44 ` [PATCH v2] " Marco Scardovi
2026-06-14 12:33 ` Denis Benato [this message]
2026-06-15 15:07 ` Marco Scardovi
2026-06-27 6:18 ` Marco Scardovi
2026-06-29 11:04 ` Ilpo Järvinen
2026-06-29 11:27 ` Marco Scardovi
2026-06-30 14:18 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524bc16a-6a66-4b2f-8aa6-6a4b0bc31f09@linux.dev \
--to=denis.benato@linux.dev \
--cc=corentin.chary@gmail.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=scardracs@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.