From: Pavel Emelyanov <xemul@parallels.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] smaps: show VM_SOFTDIRTY flag in VmFlags line
Date: Mon, 7 Oct 2013 17:21:48 +0400 [thread overview]
Message-ID: <5252B56C.8030903@parallels.com> (raw)
In-Reply-To: <1380913335-17466-1-git-send-email-n-horiguchi@ah.jp.nec.com>
On 10/04/2013 11:02 PM, Naoya Horiguchi wrote:
> This flag shows that soft dirty bit is not enabled yet.
> You can enable it by "echo 4 > /proc/pid/clear_refs."
The comment is not correct. Per-VMA soft-dirty flag means, that
VMA is "newly created" one and thus represents a new (dirty) are
in task's VM.
Other than this -- yes, it's nice to have this flag in smaps.
> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> ---
> fs/proc/task_mmu.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git v3.12-rc2-mmots-2013-09-24-17-03.orig/fs/proc/task_mmu.c v3.12-rc2-mmots-2013-09-24-17-03/fs/proc/task_mmu.c
> index 7366e9d..c591928 100644
> --- v3.12-rc2-mmots-2013-09-24-17-03.orig/fs/proc/task_mmu.c
> +++ v3.12-rc2-mmots-2013-09-24-17-03/fs/proc/task_mmu.c
> @@ -561,6 +561,9 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma)
> [ilog2(VM_NONLINEAR)] = "nl",
> [ilog2(VM_ARCH_1)] = "ar",
> [ilog2(VM_DONTDUMP)] = "dd",
> +#ifdef CONFIG_MEM_SOFT_DIRTY
> + [ilog2(VM_SOFTDIRTY)] = "sd",
> +#endif
> [ilog2(VM_MIXEDMAP)] = "mm",
> [ilog2(VM_HUGEPAGE)] = "hg",
> [ilog2(VM_NOHUGEPAGE)] = "nh",
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Emelyanov <xemul@parallels.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] smaps: show VM_SOFTDIRTY flag in VmFlags line
Date: Mon, 7 Oct 2013 17:21:48 +0400 [thread overview]
Message-ID: <5252B56C.8030903@parallels.com> (raw)
In-Reply-To: <1380913335-17466-1-git-send-email-n-horiguchi@ah.jp.nec.com>
On 10/04/2013 11:02 PM, Naoya Horiguchi wrote:
> This flag shows that soft dirty bit is not enabled yet.
> You can enable it by "echo 4 > /proc/pid/clear_refs."
The comment is not correct. Per-VMA soft-dirty flag means, that
VMA is "newly created" one and thus represents a new (dirty) are
in task's VM.
Other than this -- yes, it's nice to have this flag in smaps.
> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> ---
> fs/proc/task_mmu.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git v3.12-rc2-mmots-2013-09-24-17-03.orig/fs/proc/task_mmu.c v3.12-rc2-mmots-2013-09-24-17-03/fs/proc/task_mmu.c
> index 7366e9d..c591928 100644
> --- v3.12-rc2-mmots-2013-09-24-17-03.orig/fs/proc/task_mmu.c
> +++ v3.12-rc2-mmots-2013-09-24-17-03/fs/proc/task_mmu.c
> @@ -561,6 +561,9 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma)
> [ilog2(VM_NONLINEAR)] = "nl",
> [ilog2(VM_ARCH_1)] = "ar",
> [ilog2(VM_DONTDUMP)] = "dd",
> +#ifdef CONFIG_MEM_SOFT_DIRTY
> + [ilog2(VM_SOFTDIRTY)] = "sd",
> +#endif
> [ilog2(VM_MIXEDMAP)] = "mm",
> [ilog2(VM_HUGEPAGE)] = "hg",
> [ilog2(VM_NOHUGEPAGE)] = "nh",
>
next prev parent reply other threads:[~2013-10-07 13:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 19:02 [PATCH 1/2] smaps: show VM_SOFTDIRTY flag in VmFlags line Naoya Horiguchi
2013-10-04 19:02 ` Naoya Horiguchi
2013-10-04 19:02 ` [PATCH 2/2] page-types.c: support KPF_SOFTDIRTY bit Naoya Horiguchi
2013-10-04 19:02 ` Naoya Horiguchi
2013-10-08 0:50 ` Andrew Morton
2013-10-08 0:50 ` Andrew Morton
2013-10-07 13:21 ` Pavel Emelyanov [this message]
2013-10-07 13:21 ` [PATCH 1/2] smaps: show VM_SOFTDIRTY flag in VmFlags line Pavel Emelyanov
2013-10-07 14:15 ` [PATCH 1/2 v2] " Naoya Horiguchi
2013-10-07 14:15 ` Naoya Horiguchi
2013-10-07 21:21 ` Cyrill Gorcunov
2013-10-07 21:21 ` Cyrill Gorcunov
2013-10-08 0:51 ` Andrew Morton
2013-10-08 0:51 ` Andrew Morton
2013-10-08 2:54 ` Naoya Horiguchi
2013-10-08 2:54 ` Naoya Horiguchi
2013-10-08 8:59 ` Cyrill Gorcunov
2013-10-08 8:59 ` Cyrill Gorcunov
2013-10-08 9:03 ` Cyrill Gorcunov
2013-10-08 9:03 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5252B56C.8030903@parallels.com \
--to=xemul@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.