From: Stephen Boyd <sboyd@codeaurora.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org
Subject: Re: Bug: kbuild always rebuilds compressed images on ARM
Date: Mon, 07 Oct 2013 13:03:13 -0700 [thread overview]
Message-ID: <52531381.8070607@codeaurora.org> (raw)
In-Reply-To: <20131005131706.GY12758@n2100.arm.linux.org.uk>
On 10/05/13 06:17, Russell King - ARM Linux wrote:
> Hi,
>
> I've noticed that kbuild always rebuilds the compressed piggy image
> on ARM. Here's the output from running make with V=2:
>
> CALL /home/rmk/git/linux-rmk/scripts/checksyscalls.sh - due to target missing
> CHK include/generated/compile.h
> Kernel: arch/arm/boot/Image is ready
> Building modules, stage 2.
> LZO arch/arm/boot/compressed/piggy.lzo - due to command line change
> MODPOST 17 modules - due to target is PHONY
> AS arch/arm/boot/compressed/piggy.lzo.o - due to: arch/arm/boot/compressed/piggy.lzo
> LD arch/arm/boot/compressed/vmlinux - due to: arch/arm/boot/compressed/piggy.lzo.o
> OBJCOPY arch/arm/boot/zImage - due to: arch/arm/boot/compressed/vmlinux
> Kernel: arch/arm/boot/zImage is ready
>
> and with V=1:
>
> ...
> make -f /home/rmk/git/linux-rmk/scripts/Makefile.build obj=arch/arm/boot/compressed arch/arm/boot/compressed/vmlinux
> make -f /home/rmk/git/linux-rmk/scripts/Makefile.modpost
> find .tmp_versions -name '*.mod' | xargs -r grep -h '\.ko$' | sort -u | sed 's/\.ko$/.o/' | scripts/mod/modpost -m -a -o /home/rmk/git/build/imx6/Module.symvers -S -s -T -
> (cat arch/arm/boot/compressed/../Image | lzop -9 && printf \\010\\224\\034\\002) > arch/arm/boot/compressed/piggy.lzo || (rm -f arch/arm/boot/compressed/piggy.lzo ; false)
There are double slashes here '\\'
> make -f /home/rmk/git/linux-rmk/scripts/Makefile.fwinst obj=firmware __fw_modbuild
> ...
>
> The arch/arm/boot/compressed/.piggy.lzo.cmd file contains this:
>
> cmd_arch/arm/boot/compressed/piggy.lzo := (cat arch/arm/boot/compressed/../Image | lzop -9 && printf \\\\010\\\\224\\\\034\\\\002) > arch/arm/boot/compressed/piggy.lzo || (rm -f arch/arm/boot/compressed/piggy.lzo ; false)
But then there are quadruple slashes here '\\\\'. That seems to be
causing kbuild to rebuild each time.
>
> Any ideas why it thinks that the command has changed?
This hack seems to work, but I'm not convinced it's the right solution.
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index 547e15d..bfc0b79 100644
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -209,7 +209,7 @@ endif
# >$< substitution to preserve $ when reloading .cmd file
# note: when using inline perl scripts [perl -e '...$$t=1;...']
# in $(cmd_xxx) double $$ your perl vars
-make-cmd = $(subst \\,\\\\,$(subst \#,\\\#,$(subst $$,$$$$,$(call escsq,$(cmd_$(1))))))
+make-cmd = $(subst \#,\\\#,$(subst $$,$$$$,$(call escsq,$(cmd_$(1)))))
# Find any prerequisites that is newer than target or that does not exist.
# PHONY targets skipped in both cases.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: Bug: kbuild always rebuilds compressed images on ARM
Date: Mon, 07 Oct 2013 13:03:13 -0700 [thread overview]
Message-ID: <52531381.8070607@codeaurora.org> (raw)
In-Reply-To: <20131005131706.GY12758@n2100.arm.linux.org.uk>
On 10/05/13 06:17, Russell King - ARM Linux wrote:
> Hi,
>
> I've noticed that kbuild always rebuilds the compressed piggy image
> on ARM. Here's the output from running make with V=2:
>
> CALL /home/rmk/git/linux-rmk/scripts/checksyscalls.sh - due to target missing
> CHK include/generated/compile.h
> Kernel: arch/arm/boot/Image is ready
> Building modules, stage 2.
> LZO arch/arm/boot/compressed/piggy.lzo - due to command line change
> MODPOST 17 modules - due to target is PHONY
> AS arch/arm/boot/compressed/piggy.lzo.o - due to: arch/arm/boot/compressed/piggy.lzo
> LD arch/arm/boot/compressed/vmlinux - due to: arch/arm/boot/compressed/piggy.lzo.o
> OBJCOPY arch/arm/boot/zImage - due to: arch/arm/boot/compressed/vmlinux
> Kernel: arch/arm/boot/zImage is ready
>
> and with V=1:
>
> ...
> make -f /home/rmk/git/linux-rmk/scripts/Makefile.build obj=arch/arm/boot/compressed arch/arm/boot/compressed/vmlinux
> make -f /home/rmk/git/linux-rmk/scripts/Makefile.modpost
> find .tmp_versions -name '*.mod' | xargs -r grep -h '\.ko$' | sort -u | sed 's/\.ko$/.o/' | scripts/mod/modpost -m -a -o /home/rmk/git/build/imx6/Module.symvers -S -s -T -
> (cat arch/arm/boot/compressed/../Image | lzop -9 && printf \\010\\224\\034\\002) > arch/arm/boot/compressed/piggy.lzo || (rm -f arch/arm/boot/compressed/piggy.lzo ; false)
There are double slashes here '\\'
> make -f /home/rmk/git/linux-rmk/scripts/Makefile.fwinst obj=firmware __fw_modbuild
> ...
>
> The arch/arm/boot/compressed/.piggy.lzo.cmd file contains this:
>
> cmd_arch/arm/boot/compressed/piggy.lzo := (cat arch/arm/boot/compressed/../Image | lzop -9 && printf \\\\010\\\\224\\\\034\\\\002) > arch/arm/boot/compressed/piggy.lzo || (rm -f arch/arm/boot/compressed/piggy.lzo ; false)
But then there are quadruple slashes here '\\\\'. That seems to be
causing kbuild to rebuild each time.
>
> Any ideas why it thinks that the command has changed?
This hack seems to work, but I'm not convinced it's the right solution.
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index 547e15d..bfc0b79 100644
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -209,7 +209,7 @@ endif
# >$< substitution to preserve $ when reloading .cmd file
# note: when using inline perl scripts [perl -e '...$$t=1;...']
# in $(cmd_xxx) double $$ your perl vars
-make-cmd = $(subst \\,\\\\,$(subst \#,\\\#,$(subst $$,$$$$,$(call escsq,$(cmd_$(1))))))
+make-cmd = $(subst \#,\\\#,$(subst $$,$$$$,$(call escsq,$(cmd_$(1)))))
# Find any prerequisites that is newer than target or that does not exist.
# PHONY targets skipped in both cases.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-10-07 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 13:17 Bug: kbuild always rebuilds compressed images on ARM Russell King - ARM Linux
2013-10-05 13:17 ` Russell King - ARM Linux
2013-10-07 20:03 ` Stephen Boyd [this message]
2013-10-07 20:03 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52531381.8070607@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.