From: m@bjorling.me (Matias Bjørling)
Subject: [PATCH RFC 0/2] Convert from bio-based to blk-mq
Date: Tue, 08 Oct 2013 15:19:48 +0200 [thread overview]
Message-ID: <52540674.5030402@bjorling.me> (raw)
In-Reply-To: <20131008131036.GC7422@linux.intel.com>
On 10/08/2013 03:10 PM, Matthew Wilcox wrote:
> On Tue, Oct 08, 2013@11:34:20AM +0200, Matias Bj?rling wrote:
>> The nvme driver implements itself as a bio-based driver. This primarily because
>> of high lock congestion for high-performance nvm devices. To remove the
>> congestion, a multi-queue block layer is being implemented.
>
> Um, no. You'll crater performance by adding another memory allocation
> (of the struct request). multi-queue is not the solution.
>
Agree that there shouldn't be yet another allocation. blk-mq allocates
the requests upfront for that reason. Additionally, nvme_cmd_info can be
handled within the request payload.
WARNING: multiple messages have this Message-ID (diff)
From: "Matias Bjørling" <m@bjorling.me>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH RFC 0/2] Convert from bio-based to blk-mq
Date: Tue, 08 Oct 2013 15:19:48 +0200 [thread overview]
Message-ID: <52540674.5030402@bjorling.me> (raw)
In-Reply-To: <20131008131036.GC7422@linux.intel.com>
On 10/08/2013 03:10 PM, Matthew Wilcox wrote:
> On Tue, Oct 08, 2013 at 11:34:20AM +0200, Matias Bjørling wrote:
>> The nvme driver implements itself as a bio-based driver. This primarily because
>> of high lock congestion for high-performance nvm devices. To remove the
>> congestion, a multi-queue block layer is being implemented.
>
> Um, no. You'll crater performance by adding another memory allocation
> (of the struct request). multi-queue is not the solution.
>
Agree that there shouldn't be yet another allocation. blk-mq allocates
the requests upfront for that reason. Additionally, nvme_cmd_info can be
handled within the request payload.
next prev parent reply other threads:[~2013-10-08 13:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 9:34 [PATCH RFC 0/2] Convert from bio-based to blk-mq Matias Bjørling
2013-10-08 9:34 ` Matias Bjørling
2013-10-08 9:34 ` [PATCH RFC 1/2] blk-mq: call exit_hctx on hw queue teardown Matias Bjørling
2013-10-08 9:34 ` Matias Bjørling
2013-10-08 9:34 ` [PATCH RFC 2/2] NVMe: rfc blk-mq support Matias Bjørling
2013-10-08 9:34 ` Matias Bjørling
2013-10-08 20:59 ` Keith Busch
2013-10-08 20:59 ` Keith Busch
2013-10-09 7:12 ` Matias Bjørling
2013-10-09 7:12 ` Matias Bjørling
2013-10-08 13:10 ` [PATCH RFC 0/2] Convert from bio-based to blk-mq Matthew Wilcox
2013-10-08 13:10 ` Matthew Wilcox
2013-10-08 13:19 ` Matias Bjørling [this message]
2013-10-08 13:19 ` Matias Bjørling
2013-10-08 18:39 ` Jens Axboe
2013-10-08 18:39 ` Jens Axboe
2013-10-09 15:48 ` Keith Busch
2013-10-09 15:48 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52540674.5030402@bjorling.me \
--to=m@bjorling.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.