* [PATCH v2] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio
@ 2013-10-08 18:20 ` Jean-Francois Moine
0 siblings, 0 replies; 9+ messages in thread
From: Jean-Francois Moine @ 2013-10-08 18:20 UTC (permalink / raw)
To: Jason Cooper
Cc: Andrew Lunn, Russell King, devicetree, linux-kernel,
linux-arm-kernel, Sebastian Hesselbarth
As defined in the DT, clkout2 is not allowed to change the pll inside
si5351.
This patch extends the properties of clkout2 so that it works as the
external clock of the audio device in the Cubox.
Also, as the second si5351 clock is not used in the Cubox, its
definition is removed.
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
---
v2:
- remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)
---
arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
index bb38a24..3dd8844 100644
--- a/arch/arm/boot/dts/dove-cubox.dts
+++ b/arch/arm/boot/dts/dove-cubox.dts
@@ -99,18 +99,12 @@
silabs,pll-master;
};
- clkout1 {
- reg = <1>;
- silabs,drive-strength = <8>;
- silabs,multisynth-source = <1>;
- silabs,clock-source = <0>;
- silabs,pll-master;
- };
-
clkout2 {
reg = <2>;
+ silabs,drive-strength = <8>;
silabs,multisynth-source = <1>;
silabs,clock-source = <0>;
+ silabs,pll-master;
};
};
};
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio
@ 2013-10-08 18:20 ` Jean-Francois Moine
0 siblings, 0 replies; 9+ messages in thread
From: Jean-Francois Moine @ 2013-10-08 18:20 UTC (permalink / raw)
To: Jason Cooper
Cc: Andrew Lunn, Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Sebastian Hesselbarth
As defined in the DT, clkout2 is not allowed to change the pll inside
si5351.
This patch extends the properties of clkout2 so that it works as the
external clock of the audio device in the Cubox.
Also, as the second si5351 clock is not used in the Cubox, its
definition is removed.
Signed-off-by: Jean-Francois Moine <moinejf-GANU6spQydw@public.gmane.org>
---
v2:
- remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)
---
arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
index bb38a24..3dd8844 100644
--- a/arch/arm/boot/dts/dove-cubox.dts
+++ b/arch/arm/boot/dts/dove-cubox.dts
@@ -99,18 +99,12 @@
silabs,pll-master;
};
- clkout1 {
- reg = <1>;
- silabs,drive-strength = <8>;
- silabs,multisynth-source = <1>;
- silabs,clock-source = <0>;
- silabs,pll-master;
- };
-
clkout2 {
reg = <2>;
+ silabs,drive-strength = <8>;
silabs,multisynth-source = <1>;
silabs,clock-source = <0>;
+ silabs,pll-master;
};
};
};
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio
2013-10-08 18:20 ` Jean-Francois Moine
(?)
@ 2013-10-08 18:19 ` Sebastian Hesselbarth
-1 siblings, 0 replies; 9+ messages in thread
From: Sebastian Hesselbarth @ 2013-10-08 18:19 UTC (permalink / raw)
To: linux-arm-kernel
On 10/08/2013 08:20 PM, Jean-Francois Moine wrote:
> As defined in the DT, clkout2 is not allowed to change the pll inside
> si5351.
>
> This patch extends the properties of clkout2 so that it works as the
> external clock of the audio device in the Cubox.
>
> Also, as the second si5351 clock is not used in the Cubox, its
> definition is removed.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Already gave my
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
which you should add to help us keep track of them next time.
> ---
> v2:
> - remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)
> ---
> arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
> index bb38a24..3dd8844 100644
> --- a/arch/arm/boot/dts/dove-cubox.dts
> +++ b/arch/arm/boot/dts/dove-cubox.dts
> @@ -99,18 +99,12 @@
> silabs,pll-master;
> };
>
> - clkout1 {
> - reg = <1>;
> - silabs,drive-strength = <8>;
> - silabs,multisynth-source = <1>;
> - silabs,clock-source = <0>;
> - silabs,pll-master;
> - };
> -
> clkout2 {
> reg = <2>;
> + silabs,drive-strength = <8>;
> silabs,multisynth-source = <1>;
> silabs,clock-source = <0>;
> + silabs,pll-master;
> };
> };
> };
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio
@ 2013-10-08 18:19 ` Sebastian Hesselbarth
0 siblings, 0 replies; 9+ messages in thread
From: Sebastian Hesselbarth @ 2013-10-08 18:19 UTC (permalink / raw)
To: Jean-Francois Moine, Jason Cooper
Cc: Andrew Lunn, Russell King, devicetree, linux-kernel,
linux-arm-kernel
On 10/08/2013 08:20 PM, Jean-Francois Moine wrote:
> As defined in the DT, clkout2 is not allowed to change the pll inside
> si5351.
>
> This patch extends the properties of clkout2 so that it works as the
> external clock of the audio device in the Cubox.
>
> Also, as the second si5351 clock is not used in the Cubox, its
> definition is removed.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Already gave my
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
which you should add to help us keep track of them next time.
> ---
> v2:
> - remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)
> ---
> arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
> index bb38a24..3dd8844 100644
> --- a/arch/arm/boot/dts/dove-cubox.dts
> +++ b/arch/arm/boot/dts/dove-cubox.dts
> @@ -99,18 +99,12 @@
> silabs,pll-master;
> };
>
> - clkout1 {
> - reg = <1>;
> - silabs,drive-strength = <8>;
> - silabs,multisynth-source = <1>;
> - silabs,clock-source = <0>;
> - silabs,pll-master;
> - };
> -
> clkout2 {
> reg = <2>;
> + silabs,drive-strength = <8>;
> silabs,multisynth-source = <1>;
> silabs,clock-source = <0>;
> + silabs,pll-master;
> };
> };
> };
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio
@ 2013-10-08 18:19 ` Sebastian Hesselbarth
0 siblings, 0 replies; 9+ messages in thread
From: Sebastian Hesselbarth @ 2013-10-08 18:19 UTC (permalink / raw)
To: Jean-Francois Moine, Jason Cooper
Cc: Andrew Lunn, Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On 10/08/2013 08:20 PM, Jean-Francois Moine wrote:
> As defined in the DT, clkout2 is not allowed to change the pll inside
> si5351.
>
> This patch extends the properties of clkout2 so that it works as the
> external clock of the audio device in the Cubox.
>
> Also, as the second si5351 clock is not used in the Cubox, its
> definition is removed.
>
> Signed-off-by: Jean-Francois Moine <moinejf-GANU6spQydw@public.gmane.org>
Already gave my
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
which you should add to help us keep track of them next time.
> ---
> v2:
> - remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)
> ---
> arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
> index bb38a24..3dd8844 100644
> --- a/arch/arm/boot/dts/dove-cubox.dts
> +++ b/arch/arm/boot/dts/dove-cubox.dts
> @@ -99,18 +99,12 @@
> silabs,pll-master;
> };
>
> - clkout1 {
> - reg = <1>;
> - silabs,drive-strength = <8>;
> - silabs,multisynth-source = <1>;
> - silabs,clock-source = <0>;
> - silabs,pll-master;
> - };
> -
> clkout2 {
> reg = <2>;
> + silabs,drive-strength = <8>;
> silabs,multisynth-source = <1>;
> silabs,clock-source = <0>;
> + silabs,pll-master;
> };
> };
> };
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio
2013-10-08 18:20 ` Jean-Francois Moine
(?)
@ 2013-10-09 13:23 ` Jason Cooper
-1 siblings, 0 replies; 9+ messages in thread
From: Jason Cooper @ 2013-10-09 13:23 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 08, 2013 at 08:20:27PM +0200, Jean-Francois Moine wrote:
> As defined in the DT, clkout2 is not allowed to change the pll inside
> si5351.
>
> This patch extends the properties of clkout2 so that it works as the
> external clock of the audio device in the Cubox.
>
> Also, as the second si5351 clock is not used in the Cubox, its
> definition is removed.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> ---
> v2:
> - remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)
> ---
> arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
Applied to mvebu/dt with Sebastian's Ack.
thx,
Jason.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio
@ 2013-10-09 13:23 ` Jason Cooper
0 siblings, 0 replies; 9+ messages in thread
From: Jason Cooper @ 2013-10-09 13:23 UTC (permalink / raw)
To: Jean-Francois Moine
Cc: Andrew Lunn, Russell King, devicetree, linux-kernel,
linux-arm-kernel, Sebastian Hesselbarth
On Tue, Oct 08, 2013 at 08:20:27PM +0200, Jean-Francois Moine wrote:
> As defined in the DT, clkout2 is not allowed to change the pll inside
> si5351.
>
> This patch extends the properties of clkout2 so that it works as the
> external clock of the audio device in the Cubox.
>
> Also, as the second si5351 clock is not used in the Cubox, its
> definition is removed.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> ---
> v2:
> - remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)
> ---
> arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
Applied to mvebu/dt with Sebastian's Ack.
thx,
Jason.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio
@ 2013-10-09 13:23 ` Jason Cooper
0 siblings, 0 replies; 9+ messages in thread
From: Jason Cooper @ 2013-10-09 13:23 UTC (permalink / raw)
To: Jean-Francois Moine
Cc: Andrew Lunn, Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Sebastian Hesselbarth
On Tue, Oct 08, 2013 at 08:20:27PM +0200, Jean-Francois Moine wrote:
> As defined in the DT, clkout2 is not allowed to change the pll inside
> si5351.
>
> This patch extends the properties of clkout2 so that it works as the
> external clock of the audio device in the Cubox.
>
> Also, as the second si5351 clock is not used in the Cubox, its
> definition is removed.
>
> Signed-off-by: Jean-Francois Moine <moinejf-GANU6spQydw@public.gmane.org>
> ---
> v2:
> - remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)
> ---
> arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
Applied to mvebu/dt with Sebastian's Ack.
thx,
Jason.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread