From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, nobuhiro.iwamatsu.yj@renesas.com,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth: NAPI requires netif_receive_skb()
Date: Tue, 08 Oct 2013 20:53:37 +0000 [thread overview]
Message-ID: <52547E8D.3080101@cogentembedded.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1309261751200.11968@axis700.grange>
Hello.
On 26-09-2013 18:12, Guennadi Liakhovetski wrote:
>> From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Date: Tue, 3 Sep 2013 03:03:10 +0400
>>> Driver supporting NAPI should use NAPI-specific function for receiving packets,
>>> so netif_rx() should be changed to netif_receive_skb().
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> This patch breaks NFS boot on Armadillo800eva for me. Network
> communication slows down to a crawl with
> net eth0: Receive FIFO Overflow
> nfs: server 192.168.x.y not responding, still trying
> With this patch reverted (e.g. in today's Linus tree snapshot) boot is
> restored.
Guennadi, are you expecting some actions (like looking into what Eric have
suggested) from me? If so, I'm still on vacation, should be back next Tuesday.
I don't think reverting the patch is a Right Thing to do.
> Thanks
> Guennadi
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, nobuhiro.iwamatsu.yj@renesas.com,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth: NAPI requires netif_receive_skb()
Date: Tue, 08 Oct 2013 23:52:13 +0200 [thread overview]
Message-ID: <52547E8D.3080101@cogentembedded.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1309261751200.11968@axis700.grange>
Hello.
On 26-09-2013 18:12, Guennadi Liakhovetski wrote:
>> From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Date: Tue, 3 Sep 2013 03:03:10 +0400
>>> Driver supporting NAPI should use NAPI-specific function for receiving packets,
>>> so netif_rx() should be changed to netif_receive_skb().
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> This patch breaks NFS boot on Armadillo800eva for me. Network
> communication slows down to a crawl with
> net eth0: Receive FIFO Overflow
> nfs: server 192.168.x.y not responding, still trying
> With this patch reverted (e.g. in today's Linus tree snapshot) boot is
> restored.
Guennadi, are you expecting some actions (like looking into what Eric have
suggested) from me? If so, I'm still on vacation, should be back next Tuesday.
I don't think reverting the patch is a Right Thing to do.
> Thanks
> Guennadi
WBR, Sergei
next prev parent reply other threads:[~2013-10-08 20:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 23:03 [PATCH] sh_eth: NAPI requires netif_receive_skb() Sergei Shtylyov
2013-09-02 23:03 ` Sergei Shtylyov
2013-09-04 18:12 ` David Miller
2013-09-04 18:12 ` David Miller
2013-09-26 16:12 ` Guennadi Liakhovetski
2013-09-26 16:12 ` Guennadi Liakhovetski
2013-09-26 16:59 ` Eric Dumazet
2013-09-26 16:59 ` Eric Dumazet
2013-10-08 20:53 ` Sergei Shtylyov [this message]
2013-10-08 21:52 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52547E8D.3080101@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=g.liakhovetski@gmx.de \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.