From: Roger Quadros <rogerq@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: tony@atomide.com, balbi@ti.com, rnayak@ti.com, t-kristo@ti.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP4: clock: Initialize USB DPLL
Date: Wed, 9 Oct 2013 10:09:32 +0300 [thread overview]
Message-ID: <5255012C.3050709@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1310090704180.30199@utopia.booyaka.com>
On 10/09/2013 10:05 AM, Paul Walmsley wrote:
> Hi Roger,
>
> On Thu, 21 Mar 2013, Roger Quadros wrote:
>
>> +Paul
>>
>> On 03/21/2013 03:48 PM, Roger Quadros wrote:
>>> If the bootloader doesn't configure USB DPLL (e.g. in u-boot,
>>> disable CONFIG_USB_EHCI_OMAP), then we get all sorts of problems
>>> like
>>> - division by zero errors at boot [1]
>>> - USB DPLL fails to enter locked state
>>> - USB EHCI Host is non functional
>>> - Device can't enter OFF mode
>>>
>>> Initializing the USB DPLL fixes all these issues.
>
> Looks like I may have lost track of this - do we still need this one?
No, this is already in with the typo fix. Thanks.
>
> Also:
>
>>> diff --git a/arch/arm/mach-omap2/cclock44xx_data.c b/arch/arm/mach-omap2/cclock44xx_data.c
>>> index bfc46c1..6127bb9 100644
>>> --- a/arch/arm/mach-omap2/cclock44xx_data.c
>>> +++ b/arch/arm/mach-omap2/cclock44xx_data.c
>>> @@ -53,6 +53,12 @@
>>> */
>>> #define OMAP4_DPLL_ABE_DEFFREQ 98304000
>>>
>>> +/*
>>> + * OMAP4450 TRM Rev X, section "3.6.3.9.5 DPLL_USB Preferred Settings"
>
> 4450?
cheers,
-roger
WARNING: multiple messages have this Message-ID (diff)
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP4: clock: Initialize USB DPLL
Date: Wed, 9 Oct 2013 10:09:32 +0300 [thread overview]
Message-ID: <5255012C.3050709@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1310090704180.30199@utopia.booyaka.com>
On 10/09/2013 10:05 AM, Paul Walmsley wrote:
> Hi Roger,
>
> On Thu, 21 Mar 2013, Roger Quadros wrote:
>
>> +Paul
>>
>> On 03/21/2013 03:48 PM, Roger Quadros wrote:
>>> If the bootloader doesn't configure USB DPLL (e.g. in u-boot,
>>> disable CONFIG_USB_EHCI_OMAP), then we get all sorts of problems
>>> like
>>> - division by zero errors at boot [1]
>>> - USB DPLL fails to enter locked state
>>> - USB EHCI Host is non functional
>>> - Device can't enter OFF mode
>>>
>>> Initializing the USB DPLL fixes all these issues.
>
> Looks like I may have lost track of this - do we still need this one?
No, this is already in with the typo fix. Thanks.
>
> Also:
>
>>> diff --git a/arch/arm/mach-omap2/cclock44xx_data.c b/arch/arm/mach-omap2/cclock44xx_data.c
>>> index bfc46c1..6127bb9 100644
>>> --- a/arch/arm/mach-omap2/cclock44xx_data.c
>>> +++ b/arch/arm/mach-omap2/cclock44xx_data.c
>>> @@ -53,6 +53,12 @@
>>> */
>>> #define OMAP4_DPLL_ABE_DEFFREQ 98304000
>>>
>>> +/*
>>> + * OMAP4450 TRM Rev X, section "3.6.3.9.5 DPLL_USB Preferred Settings"
>
> 4450?
cheers,
-roger
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: <tony@atomide.com>, <balbi@ti.com>, <rnayak@ti.com>,
<t-kristo@ti.com>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: OMAP4: clock: Initialize USB DPLL
Date: Wed, 9 Oct 2013 10:09:32 +0300 [thread overview]
Message-ID: <5255012C.3050709@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1310090704180.30199@utopia.booyaka.com>
On 10/09/2013 10:05 AM, Paul Walmsley wrote:
> Hi Roger,
>
> On Thu, 21 Mar 2013, Roger Quadros wrote:
>
>> +Paul
>>
>> On 03/21/2013 03:48 PM, Roger Quadros wrote:
>>> If the bootloader doesn't configure USB DPLL (e.g. in u-boot,
>>> disable CONFIG_USB_EHCI_OMAP), then we get all sorts of problems
>>> like
>>> - division by zero errors at boot [1]
>>> - USB DPLL fails to enter locked state
>>> - USB EHCI Host is non functional
>>> - Device can't enter OFF mode
>>>
>>> Initializing the USB DPLL fixes all these issues.
>
> Looks like I may have lost track of this - do we still need this one?
No, this is already in with the typo fix. Thanks.
>
> Also:
>
>>> diff --git a/arch/arm/mach-omap2/cclock44xx_data.c b/arch/arm/mach-omap2/cclock44xx_data.c
>>> index bfc46c1..6127bb9 100644
>>> --- a/arch/arm/mach-omap2/cclock44xx_data.c
>>> +++ b/arch/arm/mach-omap2/cclock44xx_data.c
>>> @@ -53,6 +53,12 @@
>>> */
>>> #define OMAP4_DPLL_ABE_DEFFREQ 98304000
>>>
>>> +/*
>>> + * OMAP4450 TRM Rev X, section "3.6.3.9.5 DPLL_USB Preferred Settings"
>
> 4450?
cheers,
-roger
next prev parent reply other threads:[~2013-10-09 7:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 13:48 [PATCH] ARM: OMAP4: clock: Initialize USB DPLL Roger Quadros
2013-03-21 13:48 ` Roger Quadros
2013-03-21 13:48 ` Roger Quadros
2013-03-21 13:55 ` Roger Quadros
2013-03-21 13:55 ` Roger Quadros
2013-03-21 13:55 ` Roger Quadros
2013-03-21 14:12 ` Roger Quadros
2013-03-21 14:12 ` Roger Quadros
2013-03-21 14:12 ` Roger Quadros
2013-10-09 7:05 ` Paul Walmsley
2013-10-09 7:05 ` Paul Walmsley
2013-10-09 7:09 ` Roger Quadros [this message]
2013-10-09 7:09 ` Roger Quadros
2013-10-09 7:09 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5255012C.3050709@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.