All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ionut Nicu <ioan.nicu.ext-OYasijW0DpE@public.gmane.org>
To: Peter Korsgaard
	<peter.korsgaard-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org>
Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
	Alexander Sverdlin
	<alexander.sverdlin-OYasijW0DpE@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree
Date: Wed, 09 Oct 2013 10:30:57 +0200	[thread overview]
Message-ID: <52551441.4090503@nsn.com> (raw)
In-Reply-To: <87vc17km2m.fsf-1Ae4nN3xCbAluPl5bxqUMw@public.gmane.org>

On 09.10.2013 08:14, ext Peter Korsgaard wrote:
>>>>>> "WS" == Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> writes:
> 
> WS> On Tue, Oct 08, 2013 at 03:51:50PM +0200, Ionut Nicu wrote:
>>> If the i2c-parent bus driver is not loaded, returning
>>> -EINVAL will force people to unload and then reload the
>>> module again to get it working.
>>>
>>> Signed-off-by: Ionut Nicu <ioan.nicu.ext-OYasijW0DpE@public.gmane.org>
> 
> WS> Doesn't the non-DT case need fixing, too?
> 
> Arguably yes.
> 

Yes, and it's also a one line fix. Should I do it in a separate
patch or should I change this one and resubmit?

WARNING: multiple messages have this Message-ID (diff)
From: Ionut Nicu <ioan.nicu.ext@nsn.com>
To: Peter Korsgaard <peter.korsgaard@barco.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
	Alexander Sverdlin <alexander.sverdlin@nsn.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree
Date: Wed, 09 Oct 2013 10:30:57 +0200	[thread overview]
Message-ID: <52551441.4090503@nsn.com> (raw)
In-Reply-To: <87vc17km2m.fsf@thor.barco.com>

On 09.10.2013 08:14, ext Peter Korsgaard wrote:
>>>>>> "WS" == Wolfram Sang <wsa@the-dreams.de> writes:
> 
> WS> On Tue, Oct 08, 2013 at 03:51:50PM +0200, Ionut Nicu wrote:
>>> If the i2c-parent bus driver is not loaded, returning
>>> -EINVAL will force people to unload and then reload the
>>> module again to get it working.
>>>
>>> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nsn.com>
> 
> WS> Doesn't the non-DT case need fixing, too?
> 
> Arguably yes.
> 

Yes, and it's also a one line fix. Should I do it in a separate
patch or should I change this one and resubmit?

  parent reply	other threads:[~2013-10-09  8:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08 13:51 [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree Ionut Nicu
2013-10-08 13:51 ` Ionut Nicu
     [not found] ` <52540DF6.6050407-OYasijW0DpE@public.gmane.org>
2013-10-08 14:45   ` Peter Korsgaard
2013-10-08 14:45     ` Peter Korsgaard
2013-10-08 21:36   ` Wolfram Sang
2013-10-08 21:36     ` Wolfram Sang
2013-10-09  6:14     ` Peter Korsgaard
2013-10-09  6:14       ` Peter Korsgaard
     [not found]       ` <87vc17km2m.fsf-1Ae4nN3xCbAluPl5bxqUMw@public.gmane.org>
2013-10-09  8:30         ` Ionut Nicu [this message]
2013-10-09  8:30           ` Ionut Nicu
     [not found]           ` <52551441.4090503-OYasijW0DpE@public.gmane.org>
2013-10-09  9:02             ` Wolfram Sang
2013-10-09  9:02               ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52551441.4090503@nsn.com \
    --to=ioan.nicu.ext-oyasijw0dpe@public.gmane.org \
    --cc=alexander.sverdlin-OYasijW0DpE@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=peter.korsgaard-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.