From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, dzickus@redhat.com, gleb@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2/3] pvclock: detect watchdog reset at pvclock read
Date: Wed, 09 Oct 2013 10:39:04 +0200 [thread overview]
Message-ID: <52551628.5080800@redhat.com> (raw)
In-Reply-To: <20131009012230.GA27210@amt.cnet>
Il 09/10/2013 03:22, Marcelo Tosatti ha scritto:
> On Tue, Oct 08, 2013 at 11:58:10AM +0200, Paolo Bonzini wrote:
>> Il 08/10/2013 03:05, Marcelo Tosatti ha scritto:
>>> +void pvclock_touch_watchdogs(void)
>>> +{
>>> + touch_softlockup_watchdog_sync();
>>> + clocksource_touch_watchdog();
>>> + rcu_cpu_stall_reset();
>>> + reset_hung_task_detector();
>>> +}
>>> +
>>
>> Should this function be in kernel/ instead? It's not really
>> pvclock-specific.
>>
>> Paolo
>
> kernel/watchdog.c is configurable via CONFIG_LOCKUP_DETECTOR, so its not
> appropriate.
>
> And, the choice of watchdogs to reset might be different for the caller.
>
Thanks for clarifying.
Paolo
next prev parent reply other threads:[~2013-10-09 8:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 1:05 [patch 0/3] generic kernel watchdog reset at pvclock read Marcelo Tosatti
2013-10-08 1:05 ` [patch 1/3] hung_task: add method to reset detector Marcelo Tosatti
2013-10-08 13:35 ` Don Zickus
2013-10-08 1:05 ` [patch 2/3] pvclock: detect watchdog reset at pvclock read Marcelo Tosatti
2013-10-08 9:58 ` Paolo Bonzini
2013-10-09 1:22 ` Marcelo Tosatti
2013-10-09 8:39 ` Paolo Bonzini [this message]
2013-10-08 13:37 ` Don Zickus
2013-10-08 22:08 ` Marcelo Tosatti
2013-10-09 13:55 ` Don Zickus
2013-10-09 21:26 ` Marcelo Tosatti
2013-10-16 18:22 ` Don Zickus
2013-10-08 1:05 ` [patch 3/3] 01-hung-task-watchdog-reset 02-kvmclock-touch-watchdog-on-kvmclock-read series Marcelo Tosatti
2013-10-08 1:07 ` Marcelo Tosatti
2013-10-08 9:57 ` [patch 0/3] generic kernel watchdog reset at pvclock read Paolo Bonzini
2013-10-12 0:39 ` [patch 0/2] generic kernel watchdog reset at pvclock read (v2) Marcelo Tosatti
2013-10-12 0:39 ` [patch 1/2] pvclock: detect watchdog reset at pvclock read Marcelo Tosatti
2013-10-12 0:39 ` [patch 2/2] hung_task: add method to reset detector Marcelo Tosatti
2013-10-14 11:30 ` [patch 0/2] generic kernel watchdog reset at pvclock read (v2) Paolo Bonzini
2013-10-16 18:25 ` Don Zickus
2013-10-16 21:02 ` Marcelo Tosatti
2013-11-06 7:49 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52551628.5080800@redhat.com \
--to=pbonzini@redhat.com \
--cc=dzickus@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.