All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] A couple of fixes for OpenBSD
Date: Wed, 09 Oct 2013 12:22:31 +0200	[thread overview]
Message-ID: <52552E67.80700@gmail.com> (raw)
In-Reply-To: <201310091139.26628.Ilya_Bakulin@genua.de>

[-- Attachment #1: Type: text/plain, Size: 1799 bytes --]

On 09.10.2013 11:39, Ilya Bakulin wrote:
> Hi,
> attached is a small fix for getroot.c to make the conversion between partition 
> names and drive names work correctly on OpenBSD.
This patch looks like one of the numerous fixes I've done recently. Do I
get it correctly that you used some older version? Is there a problem
with current trunk?
> After applying this and previous patch, I am able to build GRUB2 both on 
> 5.3/amd64 and 5.3/i386 and invoke grub-install, and the GRUB2 gets installed 
> in the MBR and then able to load the L4 kernel + tons of modules from FAT32 
> filesystem (using multiboot).
> 
> Thanks!
> 
> diff --git a/contrib/grub2/util/getroot.c b/contrib/grub2/util/getroot.c
> index 103a3d2..2dd8486 100644
> --- a/contrib/grub2/util/getroot.c
> +++ b/contrib/grub2/util/getroot.c
> @@ -913,7 +913,7 @@ grub_find_device (const char *dir, dev_t dev)
>           /* Found!  */
>           char *res;
>           char *cwd;
> -#if defined(__NetBSD__)
> +#if defined(__NetBSD__) || defined(__OpenBSD__)
>           /* Convert this block device to its character (raw) device.  */
>           const char *template = "%s/r%s";
>  #else
> @@ -2360,7 +2360,7 @@ grub_util_biosdisk_get_grub_dev (const char *os_dev)
>      }
>    free (sys_disk);
>  
> -#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || 
> defined(__APPLE__) || defined(__NetBSD__) || defined (__s
> +#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || 
> defined(__APPLE__) || defined(__NetBSD__) || defined (__s
>    if (! S_ISCHR (st.st_mode))
>  #else
>    if (! S_ISBLK (st.st_mode))
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]

  reply	other threads:[~2013-10-09 10:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-09  9:39 [PATCH] A couple of fixes for OpenBSD Ilya Bakulin
2013-10-09 10:22 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-10-09 13:06   ` Ilya Bakulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52552E67.80700@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.