From: Michal Simek <monstr@monstr.eu>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: monstr@monstr.eu, Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 3/3] video: xilinxfb: Simplify error path
Date: Wed, 09 Oct 2013 10:25:50 +0000 [thread overview]
Message-ID: <52552F2E.7080007@monstr.eu> (raw)
In-Reply-To: <52551BAB.40805@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]
On 10/09/2013 11:02 AM, Tomi Valkeinen wrote:
> On 30/09/13 15:05, Michal Simek wrote:
>> Hi Tomi,
>>
>> On 09/16/2013 12:34 PM, Tomi Valkeinen wrote:
>>> On 16/09/13 13:33, Michal Simek wrote:
>>>> On 09/16/2013 11:51 AM, Tomi Valkeinen wrote:
>>>>> On 12/09/13 08:54, Michal Simek wrote:
>>>>>
>>>>>> @@ -394,16 +382,12 @@ static int xilinxfb_release(struct device *dev)
>>>>>> /* Turn off the display */
>>>>>> xilinx_fb_out32(drvdata, REG_CTRL, 0);
>>>>>>
>>>>>> - /* Release the resources, as allocated based on interface */
>>>>>> - if (drvdata->flags & BUS_ACCESS_FLAG)
>>>>>> - devm_iounmap(dev, drvdata->regs);
>>>>>> #ifdef CONFIG_PPC_DCR
>>>>>> - else
>>>>>> + /* Release the resources, as allocated based on interface */
>>>>>> + if (!(drvdata->flags & BUS_ACCESS_FLAG))
>>>>>> dcr_unmap(drvdata->dcr_host, drvdata->dcr_len);
>>>>>> #endif
>>>>>
>>>>> I might be mistaken, and it's not strictly part of this series, but
>>>>> shouldn't dcr_unmap be called somewhere else also, if the probe fails?
>>>>
>>>> yes. It should.
>>>
>>> Do you want me to apply these patches as they are, or do you want to
>>> improve the series to include the dcr_unmap fix?
>>
>> Sorry I have missed this email.
>>
>> Yes please apply it as is. I don't have ppc hw here to be able to test this
>> change.
>
> This series does not apply. Can you rebase on top of linux-next, and resend?
Do you mean Stephen Rothwell linux-next or any your linux-next branch?
No problem to do so if you send me link to the repo.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <monstr@monstr.eu>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: monstr@monstr.eu, Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 3/3] video: xilinxfb: Simplify error path
Date: Wed, 09 Oct 2013 12:25:50 +0200 [thread overview]
Message-ID: <52552F2E.7080007@monstr.eu> (raw)
In-Reply-To: <52551BAB.40805@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]
On 10/09/2013 11:02 AM, Tomi Valkeinen wrote:
> On 30/09/13 15:05, Michal Simek wrote:
>> Hi Tomi,
>>
>> On 09/16/2013 12:34 PM, Tomi Valkeinen wrote:
>>> On 16/09/13 13:33, Michal Simek wrote:
>>>> On 09/16/2013 11:51 AM, Tomi Valkeinen wrote:
>>>>> On 12/09/13 08:54, Michal Simek wrote:
>>>>>
>>>>>> @@ -394,16 +382,12 @@ static int xilinxfb_release(struct device *dev)
>>>>>> /* Turn off the display */
>>>>>> xilinx_fb_out32(drvdata, REG_CTRL, 0);
>>>>>>
>>>>>> - /* Release the resources, as allocated based on interface */
>>>>>> - if (drvdata->flags & BUS_ACCESS_FLAG)
>>>>>> - devm_iounmap(dev, drvdata->regs);
>>>>>> #ifdef CONFIG_PPC_DCR
>>>>>> - else
>>>>>> + /* Release the resources, as allocated based on interface */
>>>>>> + if (!(drvdata->flags & BUS_ACCESS_FLAG))
>>>>>> dcr_unmap(drvdata->dcr_host, drvdata->dcr_len);
>>>>>> #endif
>>>>>
>>>>> I might be mistaken, and it's not strictly part of this series, but
>>>>> shouldn't dcr_unmap be called somewhere else also, if the probe fails?
>>>>
>>>> yes. It should.
>>>
>>> Do you want me to apply these patches as they are, or do you want to
>>> improve the series to include the dcr_unmap fix?
>>
>> Sorry I have missed this email.
>>
>> Yes please apply it as is. I don't have ppc hw here to be able to test this
>> change.
>
> This series does not apply. Can you rebase on top of linux-next, and resend?
Do you mean Stephen Rothwell linux-next or any your linux-next branch?
No problem to do so if you send me link to the repo.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2013-10-09 10:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 5:54 [PATCH 1/3] video: xilinxfb: Use standard variable name convention Michal Simek
2013-09-12 5:54 ` Michal Simek
2013-09-12 5:54 ` [PATCH 2/3] video: xilinxfb: Use devm_kzalloc instead of kzalloc Michal Simek
2013-09-12 5:54 ` Michal Simek
2013-09-12 10:42 ` Jingoo Han
2013-09-12 10:42 ` Jingoo Han
2013-09-12 5:54 ` [PATCH 3/3] video: xilinxfb: Simplify error path Michal Simek
2013-09-12 5:54 ` Michal Simek
2013-09-12 10:46 ` Jingoo Han
2013-09-12 10:46 ` Jingoo Han
2013-09-16 9:51 ` Tomi Valkeinen
2013-09-16 9:51 ` Tomi Valkeinen
2013-09-16 10:33 ` Michal Simek
2013-09-16 10:33 ` Michal Simek
2013-09-16 10:34 ` Tomi Valkeinen
2013-09-16 10:34 ` Tomi Valkeinen
2013-09-30 12:05 ` Michal Simek
2013-09-30 12:05 ` Michal Simek
2013-10-09 9:02 ` Tomi Valkeinen
2013-10-09 9:02 ` Tomi Valkeinen
2013-10-09 10:25 ` Michal Simek [this message]
2013-10-09 10:25 ` Michal Simek
2013-10-09 10:28 ` Tomi Valkeinen
2013-10-09 10:28 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52552F2E.7080007@monstr.eu \
--to=monstr@monstr.eu \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.