From: gang.chen@asianux.com (Chen Gang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] arm: include: asm: atomic.h: use 'unsigned int' and 'atomic' instead of 'unsigned long' for atomic_clear_mask()
Date: Thu, 10 Oct 2013 10:34:02 +0800 [thread overview]
Message-ID: <5256121A.9030504@asianux.com> (raw)
In-Reply-To: <5256117A.4000009@asianux.com>
In current kernel wide source, for arm, only s390 scsi drivers use
atomic_clear_mask(), now, s390 itself need use 'unsigned int' and
'atomic_t', so need match s390's atomic_clear_mask().
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm/include/asm/atomic.h | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/arm/include/asm/atomic.h b/arch/arm/include/asm/atomic.h
index da1c77d..0832a7f 100644
--- a/arch/arm/include/asm/atomic.h
+++ b/arch/arm/include/asm/atomic.h
@@ -134,9 +134,10 @@ static inline int atomic_cmpxchg(atomic_t *ptr, int old, int new)
return oldval;
}
-static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr)
+static inline void atomic_clear_mask(unsigned int mask, atomic_t *ptr)
{
- unsigned long tmp, tmp2;
+ unsigned int tmp;
+ unsigned long tmp2;
__asm__ __volatile__("@ atomic_clear_mask\n"
"1: ldrex %0, [%3]\n"
@@ -144,8 +145,8 @@ static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr)
" strex %1, %0, [%3]\n"
" teq %1, #0\n"
" bne 1b"
- : "=&r" (tmp), "=&r" (tmp2), "+Qo" (*addr)
- : "r" (addr), "Ir" (mask)
+ : "=&r" (tmp), "=&r" (tmp2), "+Qo" (ptr->counter)
+ : "r" (&ptr->counter), "Ir" (mask)
: "cc");
}
@@ -197,12 +198,12 @@ static inline int atomic_cmpxchg(atomic_t *v, int old, int new)
return ret;
}
-static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr)
+static inline void atomic_clear_mask(unsigned int mask, atomic_t *v)
{
unsigned long flags;
raw_local_irq_save(flags);
- *addr &= ~mask;
+ v->counter &= ~mask;
raw_local_irq_restore(flags);
}
--
1.7.7.6
WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <gang.chen@asianux.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <will.deacon@arm.com>
Cc: linux390@de.ibm.com, linux-s390@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/3] arm: include: asm: atomic.h: use 'unsigned int' and 'atomic' instead of 'unsigned long' for atomic_clear_mask()
Date: Thu, 10 Oct 2013 10:34:02 +0800 [thread overview]
Message-ID: <5256121A.9030504@asianux.com> (raw)
In-Reply-To: <5256117A.4000009@asianux.com>
In current kernel wide source, for arm, only s390 scsi drivers use
atomic_clear_mask(), now, s390 itself need use 'unsigned int' and
'atomic_t', so need match s390's atomic_clear_mask().
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm/include/asm/atomic.h | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/arm/include/asm/atomic.h b/arch/arm/include/asm/atomic.h
index da1c77d..0832a7f 100644
--- a/arch/arm/include/asm/atomic.h
+++ b/arch/arm/include/asm/atomic.h
@@ -134,9 +134,10 @@ static inline int atomic_cmpxchg(atomic_t *ptr, int old, int new)
return oldval;
}
-static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr)
+static inline void atomic_clear_mask(unsigned int mask, atomic_t *ptr)
{
- unsigned long tmp, tmp2;
+ unsigned int tmp;
+ unsigned long tmp2;
__asm__ __volatile__("@ atomic_clear_mask\n"
"1: ldrex %0, [%3]\n"
@@ -144,8 +145,8 @@ static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr)
" strex %1, %0, [%3]\n"
" teq %1, #0\n"
" bne 1b"
- : "=&r" (tmp), "=&r" (tmp2), "+Qo" (*addr)
- : "r" (addr), "Ir" (mask)
+ : "=&r" (tmp), "=&r" (tmp2), "+Qo" (ptr->counter)
+ : "r" (&ptr->counter), "Ir" (mask)
: "cc");
}
@@ -197,12 +198,12 @@ static inline int atomic_cmpxchg(atomic_t *v, int old, int new)
return ret;
}
-static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr)
+static inline void atomic_clear_mask(unsigned int mask, atomic_t *v)
{
unsigned long flags;
raw_local_irq_save(flags);
- *addr &= ~mask;
+ v->counter &= ~mask;
raw_local_irq_restore(flags);
}
--
1.7.7.6
next prev parent reply other threads:[~2013-10-10 2:34 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 2:30 [PATCH 0/3] s390/arm/arm64: include: asm: atomic.h: use 'unsigned int' and 'atomic_t' instead of 'unsigned long' for atomic_*_mask() Chen Gang
2013-10-10 2:30 ` Chen Gang
2013-10-10 2:31 ` [PATCH 1/3] s390: include: asm: atomic.h: use 'unsigned int' " Chen Gang
2013-10-10 2:31 ` Chen Gang
2013-10-10 2:34 ` Chen Gang [this message]
2013-10-10 2:34 ` [PATCH 2/3] arm: include: asm: atomic.h: use 'unsigned int' and 'atomic' instead of 'unsigned long' for atomic_clear_mask() Chen Gang
2013-10-10 2:35 ` [PATCH 3/3] arm64: include: asm: atomic.h: use 'unsigned int' and 'atomic_t' " Chen Gang
2013-10-10 2:35 ` Chen Gang
2013-10-10 10:07 ` Will Deacon
2013-10-10 10:07 ` Will Deacon
2013-10-10 11:03 ` Chen Gang
2013-10-10 11:03 ` Chen Gang
2013-10-10 14:23 ` Will Deacon
2013-10-10 14:23 ` Will Deacon
2013-10-11 1:18 ` Chen Gang
2013-10-11 1:18 ` Chen Gang
2013-10-11 10:44 ` Will Deacon
2013-10-11 10:44 ` Will Deacon
2013-10-11 11:25 ` Chen Gang
2013-10-11 11:25 ` Chen Gang
2013-10-11 11:47 ` [PATCH] arm/arm64: remove atomic_clear_mask() in "include/asm/atomic.h" Chen Gang
2013-10-11 11:47 ` Chen Gang
2013-10-11 12:08 ` Richard Weinberger
2013-10-11 12:08 ` Richard Weinberger
2013-10-11 12:28 ` Will Deacon
2013-10-11 12:28 ` Will Deacon
2013-10-11 13:03 ` Richard Weinberger
2013-10-11 13:03 ` Richard Weinberger
2013-10-12 1:36 ` Chen Gang
2013-10-12 1:36 ` Chen Gang
2013-10-12 2:09 ` Chen Gang
2013-10-12 2:09 ` Chen Gang
2013-10-11 16:55 ` Will Deacon
2013-10-11 16:55 ` Will Deacon
2013-10-12 1:46 ` Chen Gang
2013-10-12 1:46 ` Chen Gang
2013-10-12 22:28 ` Catalin Marinas
2013-10-12 22:28 ` Catalin Marinas
2013-11-04 7:36 ` Chen Gang
2013-11-04 10:07 ` Will Deacon
2013-11-04 10:15 ` Chen Gang
2013-10-10 9:58 ` [PATCH 2/3] arm: include: asm: atomic.h: use 'unsigned int' and 'atomic' instead of 'unsigned long' for atomic_clear_mask() Will Deacon
2013-10-10 9:58 ` Will Deacon
2013-10-10 11:02 ` Chen Gang
2013-10-10 11:02 ` Chen Gang
2013-10-10 7:25 ` [PATCH 1/3] s390: include: asm: atomic.h: use 'unsigned int' instead of 'unsigned long' for atomic_*_mask() Heiko Carstens
2013-10-10 7:25 ` Heiko Carstens
2013-10-10 7:34 ` Chen Gang
2013-10-10 7:34 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5256121A.9030504@asianux.com \
--to=gang.chen@asianux.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.