Re: error compiling kvm-72 not there with kvm-69 - link kernel 2.6.26

[jim miro <daliroot@yahoo.com>]

the patch does not work...

watermod@miro:~/KVM$ sh run_c_kvm

Message from syslogd@miro at Thu Aug  7 01:58:37 2008 ...
miro kernel: Oops: 0011 [1] SMP 

Message from syslogd@miro at Thu Aug  7 01:58:37 2008 ...
miro kernel: Code: 00 00 00 00 00 00 00 00 00 00 00 20 5d ed 6e 00 81 ff ff 20 5d ed 6e 00 81 ff ff 00 00 00 00 00 00 00 00 40 5e 9f 68 00 81 ff ff <40> 5d ed 6e 00 81 ff ff 40 5d ed 6e 00 81 ff ff 80 e7 82 7b 00 

Message from syslogd@miro at Thu Aug  7 01:58:37 2008 ...
miro kernel: CR2: ffff81006eed5d40

Message from syslogd@miro at Thu Aug  7 01:58:37 2008 ...
miro kernel: Oops: 0000 [2] SMP 

Message from syslogd@miro at Thu Aug  7 01:58:37 2008 ...
miro kernel: Code: 5f e9 91 b4 11 00 41 57 4c 8d 7f 04 41 56 41 55 41 54 55 48 89 fd 4c 89 ff 4c 8d 75 08 53 48 83 ec 08 e8 6e b3 11 00 48 89 04 24 <48> 8b 4d 08 c7 45 00 00 00 00 00 4c 39 f1 0f 84 be 00 00 00 45 

Message from syslogd@miro at Thu Aug  7 01:58:37 2008 ...
miro kernel: CR2: 0000000000000009



--- On Thu, 8/7/08, jim miro <daliroot@yahoo.com> wrote:

> From: jim miro <daliroot@yahoo.com>
> Subject: Re: error compiling kvm-72 not there with kvm-69 - link kernel 2.6.26
> To: kvm@vger.kernel.org
> Date: Thursday, August 7, 2008, 1:46 AM
> If I remove the "flags" parameter from the call to
> anon_inode_getfd in the function kvm_anon_inode_getfd 
> It compiles but I get a warning.
> 
>  CC [M]  /usr/src/kvm-72/kernel/anon_inodes.o
> /usr/src/kvm-72/kernel/anon_inodes.c: In function
> ‘kvm_anon_inode_getfd’:
> /usr/src/kvm-72/kernel/anon_inodes.c:254: warning: passing
> argument 2 of ‘anon_inode_getfd’ from incompatible
> pointer type
>   CC [M]  /usr/src/kvm-72/kernel/irq.o
> 
> So...
> its late and I won't have time to try it tonight but
> there is a coding error there.
> 
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,26)
> 
> int kvm_anon_inode_getfd(const char *name,
> 			 const struct file_operations *fops,
> 			 void *priv, int flags)
> {
> 	int r;
> 	int fd;
> 	struct inode *inode;
> 	struct file *file;
> 
> 	r = anon_inode_getfd(&fd, &inode, &file, name,
> fops, priv);
> 	if (r < 0)
> 		return r;
> 	return fd;
> }
> 
> #else
> 
> int kvm_anon_inode_getfd(const char *name,
> 			 const struct file_operations *fops,
> 			 void *priv, int flags)
> {
> 	return anon_inode_getfd(name, &fops, priv, flags);
> }                                                  ^^^error
> 
> 
> #endif