From: Chanwoo Choi <cw00.choi@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Tomasz Figa <t.figa@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
ijc+devicetree@hellion.org.uk,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12
Date: Thu, 10 Oct 2013 13:05:54 +0900 [thread overview]
Message-ID: <525627A2.70709@samsung.com> (raw)
In-Reply-To: <CAK9yfHxr27nsmaqkE+seDgZAkpUmOsPqdXdeogY89tAXYEEG2w@mail.gmail.com>
On 10/10/2013 12:29 PM, Sachin Kamat wrote:
> On 10 October 2013 06:00, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> This patch maudio/gps_alive power domain to exynos4x12.dtsi.
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
>> index ad531fe..c04418e 100644
>> --- a/arch/arm/boot/dts/exynos4x12.dtsi
>> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
>> @@ -35,6 +35,16 @@
>> reg = <0x10023CA0 0x20>;
>> };
>>
>> + pd_maudio: maudio-power-domain@10023CC0 {
>> + compatible = "samsung,exynos4210-pd";
>> + reg = <0x10023CC0 0x20>;
>> + };
>> +
>> + pd_gps_alive: gps-alive-power-domain@10023D04 {
>> + compatible = "samsung,exynos4210-pd";
>> + reg = <0x10023D00 0x20>;
>
> There is mismatch between node name and register value.
>
>
What is exactly mismatch?
I checked the register address of MAUDIO_CONFIGURATION/GPS_ALIVE_CONFIGURATION regsiter.
- MAUDIO_CONFIGURATION 0x1002_3CC0
- GPS_ALIVE_CONFIGURATION 0x1002_3D00
WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12
Date: Thu, 10 Oct 2013 13:05:54 +0900 [thread overview]
Message-ID: <525627A2.70709@samsung.com> (raw)
In-Reply-To: <CAK9yfHxr27nsmaqkE+seDgZAkpUmOsPqdXdeogY89tAXYEEG2w@mail.gmail.com>
On 10/10/2013 12:29 PM, Sachin Kamat wrote:
> On 10 October 2013 06:00, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> This patch maudio/gps_alive power domain to exynos4x12.dtsi.
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
>> index ad531fe..c04418e 100644
>> --- a/arch/arm/boot/dts/exynos4x12.dtsi
>> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
>> @@ -35,6 +35,16 @@
>> reg = <0x10023CA0 0x20>;
>> };
>>
>> + pd_maudio: maudio-power-domain at 10023CC0 {
>> + compatible = "samsung,exynos4210-pd";
>> + reg = <0x10023CC0 0x20>;
>> + };
>> +
>> + pd_gps_alive: gps-alive-power-domain at 10023D04 {
>> + compatible = "samsung,exynos4210-pd";
>> + reg = <0x10023D00 0x20>;
>
> There is mismatch between node name and register value.
>
>
What is exactly mismatch?
I checked the register address of MAUDIO_CONFIGURATION/GPS_ALIVE_CONFIGURATION regsiter.
- MAUDIO_CONFIGURATION 0x1002_3CC0
- GPS_ALIVE_CONFIGURATION 0x1002_3D00
next prev parent reply other threads:[~2013-10-10 4:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 0:30 [PATCH 0/3] ARM: dts: exynos: Add missing dt data to bring up kernel feature Chanwoo Choi
2013-10-10 0:30 ` Chanwoo Choi
2013-10-10 0:30 ` [PATCH 1/3] ARM: dts: exynos4212: Add PMU dt data for pmu-irq Chanwoo Choi
2013-10-10 0:30 ` Chanwoo Choi
2013-10-10 0:30 ` [PATCH 2/3] ARM: dts: exynos4212: Add missing clock for multi core timer Chanwoo Choi
2013-10-10 0:30 ` Chanwoo Choi
[not found] ` <1381365007-1782-1-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-10-10 0:30 ` [PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12 Chanwoo Choi
2013-10-10 0:30 ` Chanwoo Choi
2013-10-10 0:30 ` Chanwoo Choi
2013-10-10 3:29 ` Sachin Kamat
2013-10-10 3:29 ` Sachin Kamat
2013-10-10 4:05 ` Chanwoo Choi [this message]
2013-10-10 4:05 ` Chanwoo Choi
2013-10-10 4:07 ` Chanwoo Choi
2013-10-10 4:07 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525627A2.70709@samsung.com \
--to=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=sachin.kamat@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.