All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix: Handle ampersand in branch names properly
@ 2013-10-10 14:19 Alexander Kurz
  0 siblings, 0 replies; only message in thread
From: Alexander Kurz @ 2013-10-10 14:19 UTC (permalink / raw)
  To: git

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

Hello git maintainer crew,
  recently I stumbled about gitweb generating improper HTML after 
somebody merged from a branch contining an ampersand, e.g. branch 
name=fixes&features.
  Thanks, Alexander Kurz

[-- Attachment #2: 0001-Fix-Handle-ampersand-in-branch-names-properly.patch --]
[-- Type: text/x-diff, Size: 717 bytes --]

>From beccd85ba8b8421213056883f31365f33d6e4490 Mon Sep 17 00:00:00 2001
From: kurz <kurz@DP-KURZ.heliocentris.com>
Date: Thu, 10 Oct 2013 16:09:46 +0200
Subject: [PATCH] Fix: Handle ampersand in branch names properly

---
 gitweb/gitweb.perl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 68c77f6..2963b1d 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2026,7 +2026,7 @@ sub format_ref_marker {
 				-href => href(
 					action=>$dest_action,
 					hash=>$dest
-				)}, $name);
+				)}, esc_attr($name));
 
 			$markers .= " <span class=\"".esc_attr($class)."\" title=\"".esc_attr($ref)."\">" .
 				$link . "</span>";
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-10-10 14:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-10 14:19 [PATCH] Fix: Handle ampersand in branch names properly Alexander Kurz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.