Re: [PATCH] spi/xilinx: Use DT information for bits_per_word value, fix bus_num value

[Jens Renner <renner-Xf229rFC5gsb1SvskN2V4Q@public.gmane.org>]

Am 10.10.2013 16:12, schrieb Mark Brown:
> On Thu, Oct 10, 2013 at 02:45:58PM +0200, Jens Renner wrote:
> 
>> +		of_property_read_u32(pdev->dev.of_node, "xlnx,num-transfer-bits",
>> +					&bits_per_word);
> 
> This new property needs to be documented in the binding document (and
> sent to the DT maintainers for review though in this case it's probably
> OK).

So far there is no binding documentation for spi/xilinx at all, but I prepared
a file spi-xilinx.txt which documents everything. I will send it to the DT
maintainers.

>> @@ -385,7 +387,7 @@ static int xilinx_spi_probe(struct platform_device *pdev)
>>  		goto put_master;
>>  	}
>>  
>> -	master->bus_num = pdev->dev.id;
>> +	master->bus_num = pdev->id;
>>  	master->num_chipselect = num_cs;
>>  	master->dev.of_node = pdev->dev.of_node;
> 
> This looks like an unrelated change (and buggy?).
> 

Related insofar as I mentioned the modification in the patch title and
description. Buggy, yes, I resent the patch ...


------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk