* Regression in commit 0d528d8
@ 2013-10-10 21:07 Larry Finger
2013-10-10 21:35 ` Felix Fietkau
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2013-10-10 21:07 UTC (permalink / raw)
To: Felix Fietkau, Johannes Berg; +Cc: linux-wireless
Commit 0d528d8 by Felix Fietkau, entitled "mac80211: improve the rate control
API", causes the rtlwifi-family of drivers to be unable to connect to an 802.11g
network. A bisection led to this commit, which was confirmed by reversing the patch.
The drivers can connect to a 802.11n networks, which is why the problem has gone
undetected from kernel 3.10 till now.
These drivers use the rate-control mechanism in their firmware. I suspect that
this is causing the problem. What actions do the drivers need to take that were
not required before this patch?
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Regression in commit 0d528d8
2013-10-10 21:07 Regression in commit 0d528d8 Larry Finger
@ 2013-10-10 21:35 ` Felix Fietkau
2013-10-11 19:42 ` Larry Finger
0 siblings, 1 reply; 5+ messages in thread
From: Felix Fietkau @ 2013-10-10 21:35 UTC (permalink / raw)
To: Larry Finger; +Cc: Johannes Berg, linux-wireless
On 2013-10-10 11:07 PM, Larry Finger wrote:
> Commit 0d528d8 by Felix Fietkau, entitled "mac80211: improve the rate control
> API", causes the rtlwifi-family of drivers to be unable to connect to an 802.11g
> network. A bisection led to this commit, which was confirmed by reversing the patch.
>
> The drivers can connect to a 802.11n networks, which is why the problem has gone
> undetected from kernel 3.10 till now.
>
> These drivers use the rate-control mechanism in their firmware. I suspect that
> this is causing the problem. What actions do the drivers need to take that were
> not required before this patch?
I don't recall any necessary extra actions introduced by this patch.
Please compare the rate selection info passed to the driver before and
after this patch, by dumping info->control.rates.
- Felix
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Regression in commit 0d528d8
2013-10-10 21:35 ` Felix Fietkau
@ 2013-10-11 19:42 ` Larry Finger
2013-10-11 19:47 ` Felix Fietkau
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2013-10-11 19:42 UTC (permalink / raw)
To: Felix Fietkau; +Cc: Johannes Berg, linux-wireless
On 10/10/2013 04:35 PM, Felix Fietkau wrote:
> I don't recall any necessary extra actions introduced by this patch.
> Please compare the rate selection info passed to the driver before and
> after this patch, by dumping info->control.rates.
I dumped the structure returned by ieee80211_get_tx_rate(hw, info) and found the
same values for the case that worked and the one that failed. The values were:
flags 0xc, bitrate 0xa, hw_value 0x0, and hw_value_short 0x0.
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Regression in commit 0d528d8
2013-10-11 19:42 ` Larry Finger
@ 2013-10-11 19:47 ` Felix Fietkau
2013-10-11 19:59 ` Larry Finger
0 siblings, 1 reply; 5+ messages in thread
From: Felix Fietkau @ 2013-10-11 19:47 UTC (permalink / raw)
To: Larry Finger; +Cc: Johannes Berg, linux-wireless
On 2013-10-11 9:42 PM, Larry Finger wrote:
> On 10/10/2013 04:35 PM, Felix Fietkau wrote:
>> I don't recall any necessary extra actions introduced by this patch.
>> Please compare the rate selection info passed to the driver before and
>> after this patch, by dumping info->control.rates.
>
> I dumped the structure returned by ieee80211_get_tx_rate(hw, info) and found the
> same values for the case that worked and the one that failed. The values were:
> flags 0xc, bitrate 0xa, hw_value 0x0, and hw_value_short 0x0.
I guess then we need to take another look at what exactly happens when
the connection fails, I have no idea how that commit can affect rtlwifi.
- Felix
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Regression in commit 0d528d8
2013-10-11 19:47 ` Felix Fietkau
@ 2013-10-11 19:59 ` Larry Finger
0 siblings, 0 replies; 5+ messages in thread
From: Larry Finger @ 2013-10-11 19:59 UTC (permalink / raw)
To: Felix Fietkau; +Cc: Johannes Berg, linux-wireless
On 10/11/2013 02:47 PM, Felix Fietkau wrote:
> On 2013-10-11 9:42 PM, Larry Finger wrote:
>> On 10/10/2013 04:35 PM, Felix Fietkau wrote:
>>> I don't recall any necessary extra actions introduced by this patch.
>>> Please compare the rate selection info passed to the driver before and
>>> after this patch, by dumping info->control.rates.
>>
>> I dumped the structure returned by ieee80211_get_tx_rate(hw, info) and found the
>> same values for the case that worked and the one that failed. The values were:
>> flags 0xc, bitrate 0xa, hw_value 0x0, and hw_value_short 0x0.
> I guess then we need to take another look at what exactly happens when
> the connection fails, I have no idea how that commit can affect rtlwifi.
With NetworkManager, the interface authenticates and associates normally, but it
seems that DHCP never completes. I will fire up my trusty machine that handles
kismet and get a dump of what is on the air.
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-11 19:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-10 21:07 Regression in commit 0d528d8 Larry Finger
2013-10-10 21:35 ` Felix Fietkau
2013-10-11 19:42 ` Larry Finger
2013-10-11 19:47 ` Felix Fietkau
2013-10-11 19:59 ` Larry Finger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.