From: Fabio Fantoni <fabio.fantoni@m2r.biz>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com,
Stefano.Stabellini@eu.citrix.com,
George Dunlap <george.dunlap@eu.citrix.com>,
Ian.Jackson@eu.citrix.com, wei.lui2@citrix.com
Subject: Re: [PATCH v2] libxl: remove qemu default devices for upstream qemu
Date: Fri, 11 Oct 2013 09:53:08 +0200 [thread overview]
Message-ID: <5257AE64.30507@m2r.biz> (raw)
In-Reply-To: <20131010164900.GA3195@perard.uk.xensource.com>
Il 10/10/2013 18:49, Anthony PERARD ha scritto:
> On Tue, Oct 08, 2013 at 03:54:16PM +0100, George Dunlap wrote:
>> On 10/08/2013 03:51 PM, Fabio Fantoni wrote:
>>> Il 30/09/2013 13:53, Fabio Fantoni ha scritto:
>>>> Remove default devices created by qemu. Qemu will create only devices
>>>> defined by xen, since the devices not defined by xen are not usable.
>>>> Remove deleting of empty floppy no more needed with nodefault.
>>> Any comment on this?
>>>
>>> Thanks for any reply.
>> It sounds like a good idea to me, but I'm not in a position to
>> review it. You should CC Anthony Perard along with Stefano for
>> patches that have to do with qemu.
> After applying the patch, there is three things that goes away:
> - the parallel port
> - an empty cdrom driver, if xl does not ask for one
> - a block device reported by qemu as "sd0"
>
> So, parallel, I suppose that can go away, as it's not usubal (by default
> the output go to the graphic output). The "sd0" seems to be an sdcard
> slot, but I don't think we can use it from xl. And the last one, the
> cdrom driver is also not usubal from xl, if one want to insert a cd into
> it, the cdrom driver need to be in the vm config file.
>
> So, I'm happy with the patch:
>
> Acked-by: Anthony PERARD <anthony.perard@citrix.com>
>
Thanks for your reply, can you check also this post please?
http://lists.xen.org/archives/html/xen-devel/2013-10/msg00843.html
next prev parent reply other threads:[~2013-10-11 7:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 11:53 [PATCH v2] libxl: remove qemu default devices for upstream qemu Fabio Fantoni
2013-10-08 14:51 ` Fabio Fantoni
2013-10-08 14:54 ` George Dunlap
2013-10-10 16:49 ` Anthony PERARD
2013-10-11 7:53 ` Fabio Fantoni [this message]
2013-10-14 16:47 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5257AE64.30507@m2r.biz \
--to=fabio.fantoni@m2r.biz \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=anthony.perard@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=wei.lui2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.