From: Eric Blake <eblake@redhat.com>
To: Don Koch <dkoch@verizon.com>, Stefan Weil <sw@weilnetz.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>,
Stefan Hajnoczi <stefanha@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] misc: Spelling and grammar fixes in comments
Date: Fri, 11 Oct 2013 14:09:25 -0600 [thread overview]
Message-ID: <52585AF5.4090700@redhat.com> (raw)
In-Reply-To: <52585983.1000606@terremark.com>
[-- Attachment #1: Type: text/plain, Size: 972 bytes --]
On 10/11/2013 02:03 PM, Don Koch wrote:
>> In this method, H/L and X0/X1 is always same position.
>> - This lead us to more speed and less memory.
>> + This leads us to more speed and less memory.
>> Of cause, the result of both method is quite same
>> because it's only difference that coefficient position.
>> */
>>
>
> Since you're in the neighborhood, this paragraph needs more fixes:
>
> In this method, H/L and X0/X1 is always in the same position.
> This leads us to more speed and less memory.
> Of course, the result of both methods is the same
> because the only difference is the coefficient position.
Broken record. This was what was attempted in v1, where the argument
was that the original wording is so obtuse that it is not obvious that
this is the correct replacement.
I actually like the approach of v2.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Don Koch <dkoch@verizon.com>, Stefan Weil <sw@weilnetz.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>,
Stefan Hajnoczi <stefanha@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3] misc: Spelling and grammar fixes in comments
Date: Fri, 11 Oct 2013 14:09:25 -0600 [thread overview]
Message-ID: <52585AF5.4090700@redhat.com> (raw)
In-Reply-To: <52585983.1000606@terremark.com>
[-- Attachment #1: Type: text/plain, Size: 972 bytes --]
On 10/11/2013 02:03 PM, Don Koch wrote:
>> In this method, H/L and X0/X1 is always same position.
>> - This lead us to more speed and less memory.
>> + This leads us to more speed and less memory.
>> Of cause, the result of both method is quite same
>> because it's only difference that coefficient position.
>> */
>>
>
> Since you're in the neighborhood, this paragraph needs more fixes:
>
> In this method, H/L and X0/X1 is always in the same position.
> This leads us to more speed and less memory.
> Of course, the result of both methods is the same
> because the only difference is the coefficient position.
Broken record. This was what was attempted in v1, where the argument
was that the original wording is so obtuse that it is not obvious that
this is the correct replacement.
I actually like the approach of v2.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-10-11 20:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 19:34 [Qemu-trivial] [PATCH v3] misc: Spelling and grammar fixes in comments Stefan Weil
2013-10-11 19:34 ` [Qemu-devel] " Stefan Weil
2013-10-11 20:03 ` [Qemu-trivial] " Don Koch
2013-10-11 20:03 ` Don Koch
2013-10-11 20:08 ` [Qemu-trivial] " Stefan Weil
2013-10-11 20:08 ` Stefan Weil
2013-10-11 20:51 ` [Qemu-trivial] " Don Koch
2013-10-11 20:51 ` Don Koch
2013-10-11 20:09 ` Eric Blake [this message]
2013-10-11 20:09 ` Eric Blake
2013-10-11 20:10 ` [Qemu-trivial] " Peter Maydell
2013-10-11 20:10 ` Peter Maydell
2013-10-11 20:28 ` [Qemu-trivial] " Don Koch
2013-10-11 20:28 ` Don Koch
2013-10-21 8:46 ` [Qemu-trivial] " Michael Tokarev
2013-10-21 8:46 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-10-23 5:37 ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2013-10-23 5:37 ` [Qemu-devel] [Qemu-trivial] " Stefan Weil
2013-10-11 20:11 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2013-10-11 20:11 ` Peter Maydell
2013-10-26 9:08 ` [Qemu-trivial] " Michael Tokarev
2013-10-26 9:08 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52585AF5.4090700@redhat.com \
--to=eblake@redhat.com \
--cc=agraf@suse.de \
--cc=dkoch@verizon.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.