From: jianhai luan <jianhai.luan@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>, Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org
Subject: DomU's network interface will hung when Dom0 running 32bit
Date: Sat, 12 Oct 2013 16:53:18 +0800 [thread overview]
Message-ID: <52590DFE.6080203@oracle.com> (raw)
Hi Ian,
I meet the DomU's network interface hung issue recently, and have
been working on the issue from that time. I find that DomU's network
interface, which send lesser package, will hung if Dom0 running 32bit
and DomU's up-time is very long. I think that one jiffies overflow bug
exist in the function tx_credit_exceeded().
I know the inline function time_after_eq(a,b) will process jiffies
overflow, but the function have one limit a should little that (b +
MAX_SIGNAL_LONG). If a large than the value, time_after_eq will return
false. The MAX_SINGNAL_LONG should be 0x7fffffff at 32-bit machine.
If DomU's network interface send lesser package (<0.5k/s if
jiffies=250 and credit_bytes=ULONG_MAX), jiffies will beyond out
(credit_timeout.expires + MAX_SIGNAL_LONG) and time_after_eq(now,
next_credit) will failure (should be true). So one timer which will not
be trigger in short time, and later process will be aborted when
timer_pending(&vif->credit_timeout) is true. The result will be DomU's
network interface will be hung in long time (> 40days).
Please think about the below scenario:
Condition:
Dom0 running 32-bit and HZ = 1000
vif->credit_timeout->expire = 0xffffffff, vif->remaining_credit =
0xffffffff, vif->credit_usec=0 jiffies=0
vif receive lesser package (DomU send lesser package). If the value
is litter than 2K/s, consume 4G(0xffffffff) will need 582.55 hours.
jiffies will large than 0x7ffffff. we guess jiffies = 0x800000ff,
time_after_eq(0x800000ff, 0xffffffff) will failure, and one time which
expire is 0xfffffff will be pended into system. So the interface will
hung until jiffies recount 0xffffffff (that will need very long time).
If some error exist in above explain, please help me point it out.
Thanks,
Jason
next reply other threads:[~2013-10-12 8:53 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-12 8:53 jianhai luan [this message]
2013-10-14 11:19 ` DomU's network interface will hung when Dom0 running 32bit Wei Liu
2013-10-15 2:44 ` jianhai luan
2013-10-15 2:44 ` jianhai luan
2013-10-15 8:43 ` Ian Campbell
2013-10-15 8:43 ` Ian Campbell
2013-10-15 9:34 ` jianhai luan
2013-10-15 9:34 ` jianhai luan
2013-10-15 10:06 ` Wei Liu
2013-10-15 11:26 ` jianhai luan
2013-10-15 11:26 ` jianhai luan
2013-10-15 12:58 ` Wei Liu
2013-10-15 14:29 ` jianhai luan
2013-10-15 14:49 ` Wei Liu
2013-10-15 14:49 ` Wei Liu
2013-10-15 14:50 ` Ian Campbell
2013-10-15 14:50 ` Ian Campbell
2013-10-15 15:19 ` jianhai luan
2013-10-15 16:03 ` Wei Liu
2013-10-15 16:23 ` jianhai luan
2013-10-16 0:15 ` jianhai luan
2013-10-16 0:15 ` jianhai luan
2013-10-15 16:23 ` jianhai luan
2013-10-15 16:03 ` Wei Liu
2013-10-15 15:19 ` jianhai luan
2013-10-15 14:29 ` jianhai luan
2013-10-16 7:35 ` jianhai luan
2013-10-16 9:39 ` annie li
2013-10-16 9:39 ` [Xen-devel] " annie li
2013-10-16 13:08 ` jianhai luan
2013-10-16 13:47 ` Wei Liu
2013-10-16 15:04 ` jianhai luan
2013-10-16 15:17 ` Wei Liu
2013-10-16 15:17 ` [Xen-devel] " Wei Liu
2013-10-16 16:11 ` David Vrabel
2013-10-16 16:11 ` [Xen-devel] " David Vrabel
2013-10-16 16:44 ` jianhai luan
2013-10-16 16:44 ` [Xen-devel] " jianhai luan
2013-10-16 15:26 ` annie li
2013-10-16 15:26 ` [Xen-devel] " annie li
2013-10-16 15:04 ` jianhai luan
2013-10-16 13:47 ` Wei Liu
2013-10-16 13:08 ` jianhai luan
2013-10-16 7:35 ` jianhai luan
2013-10-15 12:58 ` Wei Liu
2013-10-15 10:06 ` Wei Liu
2013-10-16 7:10 ` annie li
2013-10-16 7:10 ` annie li
2013-10-16 8:46 ` Ian Campbell
2013-10-16 8:46 ` Ian Campbell
2013-10-14 11:19 ` Wei Liu
-- strict thread matches above, loose matches on Subject: below --
2013-10-12 8:53 jianhai luan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52590DFE.6080203@oracle.com \
--to=jianhai.luan@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.