All of lore.kernel.org
 help / color / mirror / Atom feed
From: Afzal Mohammed <afzal@ti.com>
To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v2] ARM: OMAP2+: wakeupgen: AM43x adaptation
Date: Sat, 12 Oct 2013 15:52:06 +0530	[thread overview]
Message-ID: <525922CE.6080200@ti.com> (raw)
In-Reply-To: <1381302753-7045-1-git-send-email-afzal@ti.com>

Hi Tony,

On Wednesday 09 October 2013 12:42 PM, Afzal Mohammed wrote:
> AM43x has 224 interrupts and 7 banks, make it as maximum values. Keep
> default values as earlier, if am43x is detected, update interrupts and
> banks accordingly.
> 
> Also AM43x has only one cpu, ensure that clearing bitmask at wakeupgen
> is done only for the single existing cpu, existing code assumes that
> there are two cpu's.
> 
> If bitmask is cleared in wakeupgen for the nonexistent second cpu,
> an imprecise abort happens as soon as Kernel switches to user space.
> It was rootcaused by Sekhar Nori <nsekhar@ti.com>.
> 
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> ---
> 
> v2:
> 1. make AM43x adaptation such that changes required for new SoC addition is less
> 2. avoid usage of am43x local variable, use soc_is_am43xx() instead

Seems you missed this one, please consider this for the coming merge
window. Without this AM43x would not boot to prompt.

Regards
Afzal


WARNING: multiple messages have this Message-ID (diff)
From: afzal@ti.com (Afzal Mohammed)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: OMAP2+: wakeupgen: AM43x adaptation
Date: Sat, 12 Oct 2013 15:52:06 +0530	[thread overview]
Message-ID: <525922CE.6080200@ti.com> (raw)
In-Reply-To: <1381302753-7045-1-git-send-email-afzal@ti.com>

Hi Tony,

On Wednesday 09 October 2013 12:42 PM, Afzal Mohammed wrote:
> AM43x has 224 interrupts and 7 banks, make it as maximum values. Keep
> default values as earlier, if am43x is detected, update interrupts and
> banks accordingly.
> 
> Also AM43x has only one cpu, ensure that clearing bitmask at wakeupgen
> is done only for the single existing cpu, existing code assumes that
> there are two cpu's.
> 
> If bitmask is cleared in wakeupgen for the nonexistent second cpu,
> an imprecise abort happens as soon as Kernel switches to user space.
> It was rootcaused by Sekhar Nori <nsekhar@ti.com>.
> 
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> ---
> 
> v2:
> 1. make AM43x adaptation such that changes required for new SoC addition is less
> 2. avoid usage of am43x local variable, use soc_is_am43xx() instead

Seems you missed this one, please consider this for the coming merge
window. Without this AM43x would not boot to prompt.

Regards
Afzal

  reply	other threads:[~2013-10-12 10:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-09  7:12 [PATCH v2] ARM: OMAP2+: wakeupgen: AM43x adaptation Afzal Mohammed
2013-10-09  7:12 ` Afzal Mohammed
2013-10-12 10:22 ` Afzal Mohammed [this message]
2013-10-12 10:22   ` Afzal Mohammed
2013-10-22 13:53   ` Afzal Mohammed
2013-10-22 13:53     ` Afzal Mohammed
2013-10-22 14:29     ` Tony Lindgren
2013-10-22 14:29       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525922CE.6080200@ti.com \
    --to=afzal@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.