All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] configure: create fsdev/ directory
Date: Sat, 12 Oct 2013 23:05:47 +0400	[thread overview]
Message-ID: <52599D8B.3020200@msgid.tls.msk.ru> (raw)
In-Reply-To: <525978C8.9010002@redhat.com>

12.10.2013 20:28, Paolo Bonzini wrote:
> Il 11/10/2013 11:05, Michael Tokarev ha scritto:
[]
>> --- a/configure
>> +++ b/configure
>> @@ -3576,6 +3576,7 @@ if test "$softmmu" = yes ; then
>>       if test "$cap" = yes && test "$linux" = yes && test "$attr" = yes ; then
>>         virtfs=yes
>>         tools="$tools fsdev/virtfs-proxy-helper\$(EXESUF)"
>> +      mkdir -p fsdev
>>       else
>>         if test "$virtfs" = yes; then
>>           error_exit "VirtFS is supported only on Linux and requires libcap-devel and libattr-devel"
>>
>
> Please modify around
>
> DIRS="tests tests/tcg tests/tcg/cris tests/tcg/lm32 tests/libqos
> tests/qapi-schema tests/tcg/xtensa tests/qemu-iotests"
> DIRS="$DIRS pc-bios/optionrom pc-bios/spapr-rtas pc-bios/s390-ccw"
> DIRS="$DIRS roms/seabios roms/vgabios"
> DIRS="$DIRS qapi-generated"
>
> instead.

I considered doing it there initially, but decided to add it
to the other place, because that's where virtfs variable
is set.  The place you're referring to will need to have a
condition `if' based on $virtfs value.

Also, there are other places below this virtfs test (which I
modified) which runs mkdir (dtc, pixman), so this is not
something unusual.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: create fsdev/ directory
Date: Sat, 12 Oct 2013 23:05:47 +0400	[thread overview]
Message-ID: <52599D8B.3020200@msgid.tls.msk.ru> (raw)
In-Reply-To: <525978C8.9010002@redhat.com>

12.10.2013 20:28, Paolo Bonzini wrote:
> Il 11/10/2013 11:05, Michael Tokarev ha scritto:
[]
>> --- a/configure
>> +++ b/configure
>> @@ -3576,6 +3576,7 @@ if test "$softmmu" = yes ; then
>>       if test "$cap" = yes && test "$linux" = yes && test "$attr" = yes ; then
>>         virtfs=yes
>>         tools="$tools fsdev/virtfs-proxy-helper\$(EXESUF)"
>> +      mkdir -p fsdev
>>       else
>>         if test "$virtfs" = yes; then
>>           error_exit "VirtFS is supported only on Linux and requires libcap-devel and libattr-devel"
>>
>
> Please modify around
>
> DIRS="tests tests/tcg tests/tcg/cris tests/tcg/lm32 tests/libqos
> tests/qapi-schema tests/tcg/xtensa tests/qemu-iotests"
> DIRS="$DIRS pc-bios/optionrom pc-bios/spapr-rtas pc-bios/s390-ccw"
> DIRS="$DIRS roms/seabios roms/vgabios"
> DIRS="$DIRS qapi-generated"
>
> instead.

I considered doing it there initially, but decided to add it
to the other place, because that's where virtfs variable
is set.  The place you're referring to will need to have a
condition `if' based on $virtfs value.

Also, there are other places below this virtfs test (which I
modified) which runs mkdir (dtc, pixman), so this is not
something unusual.

Thanks,

/mjt

  reply	other threads:[~2013-10-12 19:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11  9:05 [Qemu-trivial] [PATCH] configure: create fsdev/ directory Michael Tokarev
2013-10-11  9:05 ` [Qemu-devel] " Michael Tokarev
2013-10-12 12:54 ` [Qemu-trivial] " Alex Bennée
2013-10-12 12:54   ` Alex Bennée
2013-10-12 16:28 ` [Qemu-trivial] " Paolo Bonzini
2013-10-12 16:28   ` [Qemu-devel] " Paolo Bonzini
2013-10-12 19:05   ` Michael Tokarev [this message]
2013-10-12 19:05     ` Michael Tokarev
2013-10-13  7:01     ` [Qemu-trivial] " Paolo Bonzini
2013-10-13  7:01       ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52599D8B.3020200@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.