From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Wendy Ng <wendy.ng@broadcom.com>
Cc: Rob Herring <rob.herring@calxeda.com>,
Stephen Warren <swarren@wwwdotorg.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, Christian Daudt <bcm@fixthebug.org>,
Markus Mayer <mmayer@broadcom.com>,
eduardo.valentin@ti.com
Subject: Re: [PATCH v2 3/3] ARM: bcm281xx: Add thermal driver to device tree.
Date: Sun, 13 Oct 2013 18:19:35 -0400 [thread overview]
Message-ID: <525B1C77.1070809@ti.com> (raw)
In-Reply-To: <1380321454-16216-4-git-send-email-wendy.ng@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]
On 27-09-2013 18:37, Wendy Ng wrote:
> This patch adds the device tree node for Broadcom bcm281xx SoCs thermal
> driver.
>
> Signed-off-by: Wendy Ng <wendy.ng@broadcom.com>
> Reviewed-by: Markus Mayer <mmayer@broadcom.com>
> Reviewed-by: Christian Daudt <csd@broadcom.com>
> ---
> arch/arm/boot/dts/bcm11351-brt.dts | 4 +++-
> arch/arm/boot/dts/bcm11351.dtsi | 6 ++++++
> arch/arm/boot/dts/bcm28155-ap.dts | 4 ++++
> 3 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm11351-brt.dts b/arch/arm/boot/dts/bcm11351-brt.dts
> index 9d36eb4..0771b6b 100644
> --- a/arch/arm/boot/dts/bcm11351-brt.dts
> +++ b/arch/arm/boot/dts/bcm11351-brt.dts
> @@ -43,5 +43,7 @@
> status = "okay";
> };
>
> -
> + thermal@34008000 {
> + status = "okay";
> + };
> };
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index 05a5aab..aa13353 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -96,4 +96,10 @@
> status = "disabled";
> };
>
> + thermal@34008000 {
> + compatible = "brcm,bcm11351-thermal", "brcm,kona-thermal";
> + reg = <0x34008000 0x0024>;
> + thermal-name = "bcm_kona_therm";
As I mentioned previously, my only concern is this thermal binding,
which is specific to your driver (BTW, you would need to do
bcm,thermal-name)
> + status = "disabled";
> + };
> };
> diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
> index 96ae67a..a39aa47 100644
> --- a/arch/arm/boot/dts/bcm28155-ap.dts
> +++ b/arch/arm/boot/dts/bcm28155-ap.dts
> @@ -42,4 +42,8 @@
> max-frequency = <48000000>;
> status = "okay";
> };
> +
> + thermal@34008000 {
> + status = "okay";
> + };
> };
>
--
You have got to be excited about what you are doing. (L. Lamport)
Eduardo Valentin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Wendy Ng <wendy.ng@broadcom.com>
Cc: Rob Herring <rob.herring@calxeda.com>,
Stephen Warren <swarren@wwwdotorg.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>, Christian Daudt <bcm@fixthebug.org>,
Markus Mayer <mmayer@broadcom.com>, <eduardo.valentin@ti.com>
Subject: Re: [PATCH v2 3/3] ARM: bcm281xx: Add thermal driver to device tree.
Date: Sun, 13 Oct 2013 18:19:35 -0400 [thread overview]
Message-ID: <525B1C77.1070809@ti.com> (raw)
In-Reply-To: <1380321454-16216-4-git-send-email-wendy.ng@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]
On 27-09-2013 18:37, Wendy Ng wrote:
> This patch adds the device tree node for Broadcom bcm281xx SoCs thermal
> driver.
>
> Signed-off-by: Wendy Ng <wendy.ng@broadcom.com>
> Reviewed-by: Markus Mayer <mmayer@broadcom.com>
> Reviewed-by: Christian Daudt <csd@broadcom.com>
> ---
> arch/arm/boot/dts/bcm11351-brt.dts | 4 +++-
> arch/arm/boot/dts/bcm11351.dtsi | 6 ++++++
> arch/arm/boot/dts/bcm28155-ap.dts | 4 ++++
> 3 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm11351-brt.dts b/arch/arm/boot/dts/bcm11351-brt.dts
> index 9d36eb4..0771b6b 100644
> --- a/arch/arm/boot/dts/bcm11351-brt.dts
> +++ b/arch/arm/boot/dts/bcm11351-brt.dts
> @@ -43,5 +43,7 @@
> status = "okay";
> };
>
> -
> + thermal@34008000 {
> + status = "okay";
> + };
> };
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index 05a5aab..aa13353 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -96,4 +96,10 @@
> status = "disabled";
> };
>
> + thermal@34008000 {
> + compatible = "brcm,bcm11351-thermal", "brcm,kona-thermal";
> + reg = <0x34008000 0x0024>;
> + thermal-name = "bcm_kona_therm";
As I mentioned previously, my only concern is this thermal binding,
which is specific to your driver (BTW, you would need to do
bcm,thermal-name)
> + status = "disabled";
> + };
> };
> diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
> index 96ae67a..a39aa47 100644
> --- a/arch/arm/boot/dts/bcm28155-ap.dts
> +++ b/arch/arm/boot/dts/bcm28155-ap.dts
> @@ -42,4 +42,8 @@
> max-frequency = <48000000>;
> status = "okay";
> };
> +
> + thermal@34008000 {
> + status = "okay";
> + };
> };
>
--
You have got to be excited about what you are doing. (L. Lamport)
Eduardo Valentin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]
next prev parent reply other threads:[~2013-10-13 22:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 22:37 [PATCH v2 0/3] thermal: bcm281xx: Add thermal driver Wendy Ng
2013-09-27 22:37 ` [PATCH v2 2/3] ARM: bcm281xx: Turn on Thermal and HWMON drivers Wendy Ng
2013-10-13 22:16 ` Eduardo Valentin
2013-10-13 22:16 ` Eduardo Valentin
2013-10-16 21:18 ` Wendy Ng
[not found] ` <1380321454-16216-1-git-send-email-wendy.ng-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2013-09-27 22:37 ` [PATCH v2 1/3] thermal: bcm281xx: Add thermal driver Wendy Ng
2013-09-27 22:37 ` Wendy Ng
2013-10-13 23:14 ` Eduardo Valentin
2013-10-13 23:14 ` Eduardo Valentin
2013-10-15 21:57 ` Wendy Ng
2013-09-27 22:37 ` [PATCH v2 3/3] ARM: bcm281xx: Add thermal driver to device tree Wendy Ng
2013-09-27 22:37 ` Wendy Ng
2013-10-13 22:19 ` Eduardo Valentin [this message]
2013-10-13 22:19 ` Eduardo Valentin
[not found] ` <525B1C77.1070809-l0cyMroinI0@public.gmane.org>
2013-10-15 21:10 ` Wendy Ng
2013-10-15 21:10 ` Wendy Ng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525B1C77.1070809@ti.com \
--to=eduardo.valentin@ti.com \
--cc=bcm@fixthebug.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mmayer@broadcom.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=wendy.ng@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.