From: Roger Quadros <rogerq@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: balbi@ti.com, bcousson@baylibre.com, tony@atomide.com,
rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, linux@arm.linux.org.uk,
grant.likely@linaro.org, s.nawrocki@samsung.com,
galak@codeaurora.org, swarren@wwwdotorg.org,
ian.campbell@citrix.com, rob@landley.net, george.cherian@ti.com,
gregkh@linuxfoundation.org, linux-doc@vger.kernel.org,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] drivers: phy: usb3/pipe3: Adapt pipe3 driver to Generic PHY Framework
Date: Mon, 14 Oct 2013 12:31:26 +0300 [thread overview]
Message-ID: <525BB9EE.3010709@ti.com> (raw)
In-Reply-To: <525BB726.6040100@ti.com>
Kishon,
On 10/14/2013 12:19 PM, Kishon Vijay Abraham I wrote:
> Hi Roger,
>
> On Friday 11 October 2013 08:32 PM, Roger Quadros wrote:
>> On 09/16/2013 10:37 AM, Roger Quadros wrote:
>>> On 09/16/2013 06:01 AM, Kishon Vijay Abraham I wrote:
>>>> On Thursday 12 September 2013 04:49 PM, Roger Quadros wrote:
>>>>> Hi Kishon,
>>>>>
>>>>> On 09/02/2013 06:43 PM, Kishon Vijay Abraham I wrote:
>>>>>> #ifdef CONFIG_OF
>>>>>> -static const struct of_device_id omap_usb3_id_table[] = {
>>>>>> +static const struct of_device_id omap_pipe3_id_table[] = {
>>>>>> + { .compatible = "ti,omap-pipe3" },
>>>>>
>>>>> why do you need "omap-pipe3", isn't sata, pcie and usb3 sufficient?
>>>>
>>>> I thought it would be better if everyone uses omap-pipe3 and added pcie, sata if there are any specific settings (for pcie or sata) that should be done.
>>>
>>> We can always add specialized options later when needed. AFAIK just the
>>> DPLL data is different among the different PHYs.
>>>>>
>>>>>> + { .compatible = "ti,omap-sata" },
>>>>>> + { .compatible = "ti,omap-pcie" },
>>>>>> { .compatible = "ti,omap-usb3" },
>>>
>>> I think compatible strings should be improved to indicate that it is a PHY.
>>>
>>> e.g. "ti,omap-phy-sata" or just "ti,pipe3-phy-sata"
>>>
>>
>> Please remove "ti,omap-pcie" for now, you can add it later whenever you add
>> dpll settings for pcie.
>>
>> Also, please change the newly added compatible strings to
>>
>> "ti,phy-pipe3-usb3" and "ti,phy-pipe3-sata"
>
> No, I think we should have omap in the compatible since this PHY is specific to
> OMAP.
DRA7x and an am43x are not OMAP so I was suggesting not to use it for new PHY types.
We still preserve just "ti,omap-usb3" for backward compatibility.
cheers,
-roger
WARNING: multiple messages have this Message-ID (diff)
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] drivers: phy: usb3/pipe3: Adapt pipe3 driver to Generic PHY Framework
Date: Mon, 14 Oct 2013 12:31:26 +0300 [thread overview]
Message-ID: <525BB9EE.3010709@ti.com> (raw)
In-Reply-To: <525BB726.6040100@ti.com>
Kishon,
On 10/14/2013 12:19 PM, Kishon Vijay Abraham I wrote:
> Hi Roger,
>
> On Friday 11 October 2013 08:32 PM, Roger Quadros wrote:
>> On 09/16/2013 10:37 AM, Roger Quadros wrote:
>>> On 09/16/2013 06:01 AM, Kishon Vijay Abraham I wrote:
>>>> On Thursday 12 September 2013 04:49 PM, Roger Quadros wrote:
>>>>> Hi Kishon,
>>>>>
>>>>> On 09/02/2013 06:43 PM, Kishon Vijay Abraham I wrote:
>>>>>> #ifdef CONFIG_OF
>>>>>> -static const struct of_device_id omap_usb3_id_table[] = {
>>>>>> +static const struct of_device_id omap_pipe3_id_table[] = {
>>>>>> + { .compatible = "ti,omap-pipe3" },
>>>>>
>>>>> why do you need "omap-pipe3", isn't sata, pcie and usb3 sufficient?
>>>>
>>>> I thought it would be better if everyone uses omap-pipe3 and added pcie, sata if there are any specific settings (for pcie or sata) that should be done.
>>>
>>> We can always add specialized options later when needed. AFAIK just the
>>> DPLL data is different among the different PHYs.
>>>>>
>>>>>> + { .compatible = "ti,omap-sata" },
>>>>>> + { .compatible = "ti,omap-pcie" },
>>>>>> { .compatible = "ti,omap-usb3" },
>>>
>>> I think compatible strings should be improved to indicate that it is a PHY.
>>>
>>> e.g. "ti,omap-phy-sata" or just "ti,pipe3-phy-sata"
>>>
>>
>> Please remove "ti,omap-pcie" for now, you can add it later whenever you add
>> dpll settings for pcie.
>>
>> Also, please change the newly added compatible strings to
>>
>> "ti,phy-pipe3-usb3" and "ti,phy-pipe3-sata"
>
> No, I think we should have omap in the compatible since this PHY is specific to
> OMAP.
DRA7x and an am43x are not OMAP so I was suggesting not to use it for new PHY types.
We still preserve just "ti,omap-usb3" for backward compatibility.
cheers,
-roger
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: <balbi@ti.com>, <bcousson@baylibre.com>, <tony@atomide.com>,
<rob.herring@calxeda.com>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <linux@arm.linux.org.uk>,
<grant.likely@linaro.org>, <s.nawrocki@samsung.com>,
<galak@codeaurora.org>, <swarren@wwwdotorg.org>,
<ian.campbell@citrix.com>, <rob@landley.net>,
<george.cherian@ti.com>, <gregkh@linuxfoundation.org>,
<linux-doc@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/7] drivers: phy: usb3/pipe3: Adapt pipe3 driver to Generic PHY Framework
Date: Mon, 14 Oct 2013 12:31:26 +0300 [thread overview]
Message-ID: <525BB9EE.3010709@ti.com> (raw)
In-Reply-To: <525BB726.6040100@ti.com>
Kishon,
On 10/14/2013 12:19 PM, Kishon Vijay Abraham I wrote:
> Hi Roger,
>
> On Friday 11 October 2013 08:32 PM, Roger Quadros wrote:
>> On 09/16/2013 10:37 AM, Roger Quadros wrote:
>>> On 09/16/2013 06:01 AM, Kishon Vijay Abraham I wrote:
>>>> On Thursday 12 September 2013 04:49 PM, Roger Quadros wrote:
>>>>> Hi Kishon,
>>>>>
>>>>> On 09/02/2013 06:43 PM, Kishon Vijay Abraham I wrote:
>>>>>> #ifdef CONFIG_OF
>>>>>> -static const struct of_device_id omap_usb3_id_table[] = {
>>>>>> +static const struct of_device_id omap_pipe3_id_table[] = {
>>>>>> + { .compatible = "ti,omap-pipe3" },
>>>>>
>>>>> why do you need "omap-pipe3", isn't sata, pcie and usb3 sufficient?
>>>>
>>>> I thought it would be better if everyone uses omap-pipe3 and added pcie, sata if there are any specific settings (for pcie or sata) that should be done.
>>>
>>> We can always add specialized options later when needed. AFAIK just the
>>> DPLL data is different among the different PHYs.
>>>>>
>>>>>> + { .compatible = "ti,omap-sata" },
>>>>>> + { .compatible = "ti,omap-pcie" },
>>>>>> { .compatible = "ti,omap-usb3" },
>>>
>>> I think compatible strings should be improved to indicate that it is a PHY.
>>>
>>> e.g. "ti,omap-phy-sata" or just "ti,pipe3-phy-sata"
>>>
>>
>> Please remove "ti,omap-pcie" for now, you can add it later whenever you add
>> dpll settings for pcie.
>>
>> Also, please change the newly added compatible strings to
>>
>> "ti,phy-pipe3-usb3" and "ti,phy-pipe3-sata"
>
> No, I think we should have omap in the compatible since this PHY is specific to
> OMAP.
DRA7x and an am43x are not OMAP so I was suggesting not to use it for new PHY types.
We still preserve just "ti,omap-usb3" for backward compatibility.
cheers,
-roger
next prev parent reply other threads:[~2013-10-14 9:32 UTC|newest]
Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 15:43 [PATCH 0/7] Make dwc3 use Generic PHY Framework and misc cleanup Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-02 15:43 ` [PATCH 1/7] usb: dwc3: get "usb_phy" only if the platform indicates the presence of PHY Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-12 10:36 ` Roger Quadros
2013-09-12 10:36 ` Roger Quadros
2013-09-12 10:36 ` Roger Quadros
2013-09-12 10:47 ` Vivek Gautam
2013-09-12 10:47 ` Vivek Gautam
2013-09-12 10:47 ` Vivek Gautam
2013-09-12 11:04 ` Roger Quadros
2013-09-12 11:04 ` Roger Quadros
2013-09-12 11:04 ` Roger Quadros
2013-09-12 11:26 ` Vivek Gautam
2013-09-12 11:26 ` Vivek Gautam
2013-09-12 11:26 ` Vivek Gautam
2013-09-12 13:11 ` Roger Quadros
2013-09-12 13:11 ` Roger Quadros
2013-09-12 13:11 ` Roger Quadros
[not found] ` <5231BD9F.4020105-l0cyMroinI0@public.gmane.org>
2013-09-16 8:40 ` Vivek Gautam
2013-09-16 8:40 ` Vivek Gautam
2013-09-16 8:40 ` Vivek Gautam
2013-09-17 15:45 ` Felipe Balbi
2013-09-17 15:45 ` Felipe Balbi
2013-09-17 15:45 ` Felipe Balbi
2013-09-02 15:43 ` [PATCH 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-12 9:27 ` Vivek Gautam
2013-09-12 9:27 ` Vivek Gautam
2013-09-12 10:10 ` Kishon Vijay Abraham I
2013-09-12 10:10 ` Kishon Vijay Abraham I
2013-09-12 10:10 ` Kishon Vijay Abraham I
2013-09-12 10:27 ` Vivek Gautam
2013-09-12 10:27 ` Vivek Gautam
2013-10-10 10:28 ` Kishon Vijay Abraham I
2013-10-10 10:28 ` Kishon Vijay Abraham I
2013-10-10 10:28 ` Kishon Vijay Abraham I
[not found] ` <1378136591-7463-3-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-09-12 13:19 ` Roger Quadros
2013-09-12 13:19 ` Roger Quadros
2013-09-12 13:19 ` Roger Quadros
[not found] ` <5231BF7A.3080104-l0cyMroinI0@public.gmane.org>
2013-09-16 2:52 ` Kishon Vijay Abraham I
2013-09-16 2:52 ` Kishon Vijay Abraham I
2013-09-16 2:52 ` Kishon Vijay Abraham I
2013-09-16 7:25 ` Roger Quadros
2013-09-16 7:25 ` Roger Quadros
2013-09-16 7:25 ` Roger Quadros
2013-10-11 15:09 ` Roger Quadros
2013-10-11 15:09 ` Roger Quadros
2013-10-11 15:09 ` Roger Quadros
2013-10-14 9:26 ` Kishon Vijay Abraham I
2013-10-14 9:26 ` Kishon Vijay Abraham I
2013-10-14 9:26 ` Kishon Vijay Abraham I
2013-10-14 10:21 ` Roger Quadros
2013-10-14 10:21 ` Roger Quadros
2013-10-14 10:21 ` Roger Quadros
2013-10-15 5:31 ` Kishon Vijay Abraham I
2013-10-15 5:31 ` Kishon Vijay Abraham I
2013-10-15 5:31 ` Kishon Vijay Abraham I
2013-10-15 7:57 ` Roger Quadros
2013-10-15 7:57 ` Roger Quadros
2013-10-15 7:57 ` Roger Quadros
2013-10-15 12:00 ` Felipe Balbi
2013-10-15 12:00 ` Felipe Balbi
2013-10-15 12:00 ` Felipe Balbi
2013-10-15 11:58 ` Felipe Balbi
2013-10-15 11:58 ` Felipe Balbi
2013-10-15 11:58 ` Felipe Balbi
2013-10-15 11:57 ` Felipe Balbi
2013-10-15 11:57 ` Felipe Balbi
2013-10-15 11:57 ` Felipe Balbi
2013-10-15 12:10 ` Roger Quadros
2013-10-15 12:10 ` Roger Quadros
2013-10-15 12:10 ` Roger Quadros
2013-10-15 13:19 ` Felipe Balbi
2013-10-15 13:19 ` Felipe Balbi
2013-10-15 13:19 ` Felipe Balbi
2013-10-15 13:48 ` Roger Quadros
2013-10-15 13:48 ` Roger Quadros
2013-10-15 13:48 ` Roger Quadros
2013-10-15 13:56 ` Felipe Balbi
2013-10-15 13:56 ` Felipe Balbi
2013-10-15 13:56 ` Felipe Balbi
2013-10-15 14:03 ` Roger Quadros
2013-10-15 14:03 ` Roger Quadros
2013-10-15 14:03 ` Roger Quadros
2013-10-15 14:12 ` Felipe Balbi
2013-10-15 14:12 ` Felipe Balbi
2013-10-15 14:12 ` Felipe Balbi
2013-09-02 15:43 ` [PATCH 3/7] drivers: phy: usb3/pipe3: Adapt pipe3 driver to " Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-12 11:19 ` Roger Quadros
2013-09-12 11:19 ` Roger Quadros
2013-09-12 11:19 ` Roger Quadros
2013-09-16 3:01 ` Kishon Vijay Abraham I
2013-09-16 3:01 ` Kishon Vijay Abraham I
2013-09-16 3:01 ` Kishon Vijay Abraham I
2013-09-16 7:37 ` Roger Quadros
2013-09-16 7:37 ` Roger Quadros
2013-09-16 7:37 ` Roger Quadros
[not found] ` <5236B537.1090902-l0cyMroinI0@public.gmane.org>
2013-10-11 15:02 ` Roger Quadros
2013-10-11 15:02 ` Roger Quadros
2013-10-11 15:02 ` Roger Quadros
2013-10-14 9:19 ` Kishon Vijay Abraham I
2013-10-14 9:19 ` Kishon Vijay Abraham I
2013-10-14 9:19 ` Kishon Vijay Abraham I
2013-10-14 9:31 ` Roger Quadros [this message]
2013-10-14 9:31 ` Roger Quadros
2013-10-14 9:31 ` Roger Quadros
2013-09-02 15:43 ` [PATCH 4/7] Documentation: dt bindings: move ..usb/usb-phy.txt to ..phy/omap-phy.txt Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-12 13:23 ` Roger Quadros
2013-09-12 13:23 ` Roger Quadros
2013-09-12 13:23 ` Roger Quadros
[not found] ` <5231C040.4040609-l0cyMroinI0@public.gmane.org>
2013-09-16 3:04 ` Kishon Vijay Abraham I
2013-09-16 3:04 ` Kishon Vijay Abraham I
2013-09-16 3:04 ` Kishon Vijay Abraham I
2013-09-02 15:43 ` [PATCH 5/7] phy: omap-usb2: move omap_usb.h from linux/usb/ to linux/phy/ Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-02 15:43 ` [PATCH 6/7] arm/dts: added dt properties to adapt to the new phy framwork Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-12 13:28 ` Roger Quadros
2013-09-12 13:28 ` Roger Quadros
2013-09-12 13:28 ` Roger Quadros
2013-09-02 15:43 ` [PATCH 7/7] drivers: phy: renamed struct omap_control_usb to struct omap_control_phy Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-02 15:43 ` Kishon Vijay Abraham I
2013-09-12 13:42 ` Roger Quadros
2013-09-12 13:42 ` Roger Quadros
2013-09-12 13:42 ` Roger Quadros
[not found] ` <5231C4C4.1000100-l0cyMroinI0@public.gmane.org>
2013-09-16 3:06 ` Kishon Vijay Abraham I
2013-09-16 3:06 ` Kishon Vijay Abraham I
2013-09-16 3:06 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525BB9EE.3010709@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=george.cherian@ti.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ian.campbell@citrix.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=s.nawrocki@samsung.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.