From: Paolo Bonzini <pbonzini@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, glin@suse.de,
agraf@suse.de, brogers@suse.de, afaerber@suse.de,
lnussel@suse.de, edk2-devel@lists.sf.net, stable@vger.kernel.org,
Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Subject: Re: [PATCH] KVM: mmu: allow page tables to be in read-only slots
Date: Mon, 14 Oct 2013 17:28:54 +0200 [thread overview]
Message-ID: <525C0DB6.2060009@redhat.com> (raw)
In-Reply-To: <20130901091744.GF22899@redhat.com>
Il 01/09/2013 11:17, Gleb Natapov ha scritto:
> This makes me think are there other places where gfn_to_hva() was
> used, but gfn_to_hva_prot() should have been?
> - kvm_host_page_size() looks incorrect. We never use huge page to map
> read only memory slots currently.
> - kvm_handle_bad_page() also looks incorrect and may cause incorrect
> address to be reported to userspace.
> - kvm_setup_async_pf() also incorrect. Makes all page fault on read
> only slot to be sync.
> - kvm_vm_fault() one looks OK since function assumes write only slots,
> but it is obsolete and should be deleted anyway.
>
> Others in generic and x86 code looks OK, somebody need to check ppc and
> arm code.
PPC is a mess, for s390 I couldn't find a spec. ARM needs to be fixed.
Patches coming...
Paolo
next prev parent reply other threads:[~2013-10-14 15:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 12:41 [PATCH] KVM: mmu: allow page tables to be in read-only slots Paolo Bonzini
2013-09-01 9:17 ` Gleb Natapov
2013-09-02 9:42 ` Xiao Guangrong
2013-09-02 9:49 ` Gleb Natapov
2013-09-02 10:05 ` Xiao Guangrong
2013-09-02 10:11 ` Gleb Natapov
2013-09-02 15:58 ` [edk2] " Paolo Bonzini
2013-09-02 15:58 ` Paolo Bonzini
2013-09-02 16:27 ` Gleb Natapov
2013-10-14 15:28 ` Paolo Bonzini [this message]
2013-09-02 9:20 ` Xiao Guangrong
2013-09-02 9:25 ` Gleb Natapov
2013-09-02 10:00 ` Xiao Guangrong
2013-09-02 10:07 ` Gleb Natapov
2013-09-02 15:56 ` [edk2] " Paolo Bonzini
2013-09-02 15:56 ` Paolo Bonzini
2013-09-02 16:26 ` Gleb Natapov
2013-09-02 16:00 ` [edk2] " Paolo Bonzini
2013-09-02 16:00 ` Paolo Bonzini
2013-09-02 16:16 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525C0DB6.2060009@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=brogers@suse.de \
--cc=edk2-devel@lists.sf.net \
--cc=gleb@redhat.com \
--cc=glin@suse.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lnussel@suse.de \
--cc=stable@vger.kernel.org \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.