From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
toshi.kani@hp.com, sjenning@linux.vnet.ibm.com
Subject: Re: [PATCH] Release device_hotplug_lock when store_mem_state returns EINVAL
Date: Tue, 15 Oct 2013 10:42:30 +0900 [thread overview]
Message-ID: <525C9D86.1020502@jp.fujitsu.com> (raw)
In-Reply-To: <20131011155454.GA32305@kroah.com>
Hi Greg,
(2013/10/12 0:54), Greg KH wrote:
> On Fri, Oct 11, 2013 at 03:36:25PM +0900, Yasuaki Ishimatsu wrote:
>> When inserting a wrong value to /sys/devices/system/memory/memoryX/state file,
>> following messages are shown. And device_hotplug_lock is never released.
>>
>> ================================================
>> [ BUG: lock held when returning to user space! ]
>> 3.12.0-rc4-debug+ #3 Tainted: G W
>> ------------------------------------------------
>> bash/6442 is leaving the kernel with locks still held!
>> 1 lock held by bash/6442:
>> #0: (device_hotplug_lock){+.+.+.}, at: [<ffffffff8146cbb5>] lock_device_hotplug_sysfs+0x15/0x50
>>
>> This issue was introdued by commit fa2be40 (drivers: base: use standard
>> device online/offline for state change).
>>
>> This patch releases device_hotplug_lcok when store_mem_state returns EINVAL.
>>
>> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>> CC: Toshi Kani <toshi.kani@hp.com>
>> CC: Seth Jennings <sjenning@linux.vnet.ibm.com>
>> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Is this needed in 3.12-final, and possibly older kernel releases as well
> (3.10, 3.11, etc.)? Or is it ok for 3.13?
The patch is needed in 3.12 because this problem has occurred since 3.12-rc1.
Thanks,
Yasuaki Ishimatsu
>
> thanks,
>
> greg k-h
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<toshi.kani@hp.com>, <sjenning@linux.vnet.ibm.com>
Subject: Re: [PATCH] Release device_hotplug_lock when store_mem_state returns EINVAL
Date: Tue, 15 Oct 2013 10:42:30 +0900 [thread overview]
Message-ID: <525C9D86.1020502@jp.fujitsu.com> (raw)
In-Reply-To: <20131011155454.GA32305@kroah.com>
Hi Greg,
(2013/10/12 0:54), Greg KH wrote:
> On Fri, Oct 11, 2013 at 03:36:25PM +0900, Yasuaki Ishimatsu wrote:
>> When inserting a wrong value to /sys/devices/system/memory/memoryX/state file,
>> following messages are shown. And device_hotplug_lock is never released.
>>
>> ================================================
>> [ BUG: lock held when returning to user space! ]
>> 3.12.0-rc4-debug+ #3 Tainted: G W
>> ------------------------------------------------
>> bash/6442 is leaving the kernel with locks still held!
>> 1 lock held by bash/6442:
>> #0: (device_hotplug_lock){+.+.+.}, at: [<ffffffff8146cbb5>] lock_device_hotplug_sysfs+0x15/0x50
>>
>> This issue was introdued by commit fa2be40 (drivers: base: use standard
>> device online/offline for state change).
>>
>> This patch releases device_hotplug_lcok when store_mem_state returns EINVAL.
>>
>> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>> CC: Toshi Kani <toshi.kani@hp.com>
>> CC: Seth Jennings <sjenning@linux.vnet.ibm.com>
>> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Is this needed in 3.12-final, and possibly older kernel releases as well
> (3.10, 3.11, etc.)? Or is it ok for 3.13?
The patch is needed in 3.12 because this problem has occurred since 3.12-rc1.
Thanks,
Yasuaki Ishimatsu
>
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2013-10-15 1:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 6:36 [PATCH] Release device_hotplug_lock when store_mem_state returns EINVAL Yasuaki Ishimatsu
2013-10-11 6:36 ` Yasuaki Ishimatsu
2013-10-11 15:54 ` Greg KH
2013-10-11 15:54 ` Greg KH
2013-10-15 1:42 ` Yasuaki Ishimatsu [this message]
2013-10-15 1:42 ` Yasuaki Ishimatsu
2013-10-11 16:31 ` Toshi Kani
2013-10-11 16:31 ` Toshi Kani
2013-10-17 2:24 ` Yasuaki Ishimatsu
2013-10-17 2:24 ` Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525C9D86.1020502@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sjenning@linux.vnet.ibm.com \
--cc=toshi.kani@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.