From: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
To: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org,
James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org,
vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] x86 efi: efi reverve boot service fix
Date: Wed, 16 Oct 2013 00:29:58 -0700 [thread overview]
Message-ID: <525E4076.2070107@zytor.com> (raw)
In-Reply-To: <20131016071122.GB18241-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
On 10/16/2013 12:11 AM, Dave Young wrote:
>>
>> --- linux-2.6.orig/arch/x86/platform/efi/efi.c
>> +++ linux-2.6/arch/x86/platform/efi/efi.c
>> @@ -440,7 +440,7 @@ void __init efi_reserve_boot_services(vo
>> * - Not within any part of the kernel
>> * - Not the bios reserved area
>> */
>> - if ((start+size >= __pa_symbol(_text)
>> + if ((start + size - 1 >= __pa_symbol(_text)
>> && start <= __pa_symbol(_end)) ||
>> !e820_all_mapped(start, start+size, E820_RAM) ||
>> memblock_is_region_reserved(start, size)) {
It would be better to change >= to >.
-hpa
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Dave Young <dyoung@redhat.com>,
matt@console-pimps.org, x86@kernel.org,
linux-kernel@vger.kernel.org, mjg59@srcf.ucam.org,
James.Bottomley@HansenPartnership.com, vgoyal@redhat.com,
linux-efi@vger.kernel.org
Subject: Re: [PATCH] x86 efi: efi reverve boot service fix
Date: Wed, 16 Oct 2013 00:29:58 -0700 [thread overview]
Message-ID: <525E4076.2070107@zytor.com> (raw)
In-Reply-To: <20131016071122.GB18241@dhcp-16-126.nay.redhat.com>
On 10/16/2013 12:11 AM, Dave Young wrote:
>>
>> --- linux-2.6.orig/arch/x86/platform/efi/efi.c
>> +++ linux-2.6/arch/x86/platform/efi/efi.c
>> @@ -440,7 +440,7 @@ void __init efi_reserve_boot_services(vo
>> * - Not within any part of the kernel
>> * - Not the bios reserved area
>> */
>> - if ((start+size >= __pa_symbol(_text)
>> + if ((start + size - 1 >= __pa_symbol(_text)
>> && start <= __pa_symbol(_end)) ||
>> !e820_all_mapped(start, start+size, E820_RAM) ||
>> memblock_is_region_reserved(start, size)) {
It would be better to change >= to >.
-hpa
next prev parent reply other threads:[~2013-10-16 7:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 7:03 [PATCH] x86 efi: efi reverve boot service fix Dave Young
2013-10-16 7:03 ` Dave Young
[not found] ` <20131016070301.GA26752-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-10-16 7:11 ` Dave Young
2013-10-16 7:11 ` Dave Young
[not found] ` <20131016071122.GB18241-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-10-16 7:29 ` H. Peter Anvin [this message]
2013-10-16 7:29 ` H. Peter Anvin
[not found] ` <525E4076.2070107-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-10-16 8:24 ` Dave Young
2013-10-16 8:24 ` Dave Young
2013-10-16 8:07 ` Matt Fleming
2013-10-16 8:07 ` Matt Fleming
[not found] ` <20131016080711.GC10834-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-16 8:28 ` Dave Young
2013-10-16 8:28 ` Dave Young
2013-10-16 8:36 ` Maarten Lankhorst
2013-10-16 8:35 ` [PATCH v2] " Dave Young
2013-10-16 8:35 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525E4076.2070107@zytor.com \
--to=hpa-ymnouzjc4hwavxtiumwx3w@public.gmane.org \
--cc=James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
--cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.