All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <dborkman@redhat.com>
To: Vlad Yasevich <vyasevich@gmail.com>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, fan.du@windriver.com
Subject: Re: [PATCH v4 net 0/3] sctp: Use software checksum under certain
Date: Wed, 16 Oct 2013 08:02:32 +0000	[thread overview]
Message-ID: <525E4818.2080101@redhat.com> (raw)
In-Reply-To: <1381888891-31186-1-git-send-email-vyasevich@gmail.com>

On 10/16/2013 04:01 AM, Vlad Yasevich wrote:
> There are some cards that support SCTP checksum offloading.  When using
> these cards with IPSec or forcing IP fragmentation of SCTP traffic,
> the checksum is computed incorrectly due to the fact that xfrm and IP/IPv6
> fragmentation code do not know that this is SCTP traffic and do not
> know that checksum has to be computed differently.
>
> To fix this, we let SCTP detect these conditions and perform software
> checksum calculation.
>
> Fan Du (1):
>    sctp: Use software crc32 checksum when xfrm transform will happen.
>
> Vlad Yasevich (2):
>    net: dst: provide accessor function to dst->xfrm
>    sctp: Perform software checksum if packet has to be fragmented.
>
>   include/net/dst.h | 12 ++++++++++++
>   net/sctp/output.c |  3 ++-
>   2 files changed, 14 insertions(+), 1 deletion(-)
>

Acked-by: Daniel Borkmann <dborkman@redhat.com>

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com>
To: Vlad Yasevich <vyasevich@gmail.com>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, fan.du@windriver.com
Subject: Re: [PATCH v4 net 0/3] sctp: Use software checksum under certain
Date: Wed, 16 Oct 2013 10:02:32 +0200	[thread overview]
Message-ID: <525E4818.2080101@redhat.com> (raw)
In-Reply-To: <1381888891-31186-1-git-send-email-vyasevich@gmail.com>

On 10/16/2013 04:01 AM, Vlad Yasevich wrote:
> There are some cards that support SCTP checksum offloading.  When using
> these cards with IPSec or forcing IP fragmentation of SCTP traffic,
> the checksum is computed incorrectly due to the fact that xfrm and IP/IPv6
> fragmentation code do not know that this is SCTP traffic and do not
> know that checksum has to be computed differently.
>
> To fix this, we let SCTP detect these conditions and perform software
> checksum calculation.
>
> Fan Du (1):
>    sctp: Use software crc32 checksum when xfrm transform will happen.
>
> Vlad Yasevich (2):
>    net: dst: provide accessor function to dst->xfrm
>    sctp: Perform software checksum if packet has to be fragmented.
>
>   include/net/dst.h | 12 ++++++++++++
>   net/sctp/output.c |  3 ++-
>   2 files changed, 14 insertions(+), 1 deletion(-)
>

Acked-by: Daniel Borkmann <dborkman@redhat.com>

  parent reply	other threads:[~2013-10-16  8:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16  2:01 [PATCH v4 net 0/3] sctp: Use software checksum under certain Vlad Yasevich
2013-10-16  2:01 ` Vlad Yasevich
2013-10-16  2:01 ` [PATCH v4 net 1/3] net: dst: provide accessor function to dst->xfrm Vlad Yasevich
2013-10-16  2:01   ` Vlad Yasevich
2013-10-16 13:31   ` Neil Horman
2013-10-16 13:31     ` Neil Horman
2013-10-16  2:01 ` [PATCH v4 net 2/3] sctp: Use software crc32 checksum when xfrm transform will happen Vlad Yasevich
2013-10-16  2:01   ` Vlad Yasevich
2013-10-16 13:32   ` Neil Horman
2013-10-16 13:32     ` Neil Horman
2013-10-16  2:01 ` [PATCH v4 net 3/3] sctp: Perform software checksum if packet has to be fragmented Vlad Yasevich
2013-10-16  2:01   ` Vlad Yasevich
2013-10-16 13:34   ` Neil Horman
2013-10-16 13:34     ` Neil Horman
2013-10-16  8:02 ` Daniel Borkmann [this message]
2013-10-16  8:02   ` [PATCH v4 net 0/3] sctp: Use software checksum under certain Daniel Borkmann
2013-10-17 19:26 ` David Miller
2013-10-17 19:26   ` David Miller
2013-10-17 20:21   ` Vlad Yasevich
2013-10-17 20:21     ` Vlad Yasevich
2013-10-18  3:33     ` David Miller
2013-10-18  3:33       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525E4818.2080101@redhat.com \
    --to=dborkman@redhat.com \
    --cc=fan.du@windriver.com \
    --cc=linux-sctp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.