All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Filipe David Borba Manana <fdmanana@gmail.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com, dsterba@suse.cz,
	jbacik@fusionio.com
Subject: Re: [PATCH] xfstests: add specific test for default ACL inheritance
Date: Wed, 16 Oct 2013 10:10:23 -0500	[thread overview]
Message-ID: <525EAC5F.3040201@sandeen.net> (raw)
In-Reply-To: <1381932296-14674-1-git-send-email-fdmanana@gmail.com>

On 10/16/13 9:04 AM, Filipe David Borba Manana wrote:
> This test is motivated by an issue found by a btrfs user, addressed
> and described by the following GNU/Linux kernel patch:
> 
> https://patchwork.kernel.org/patch/3046931/

Hi Filipe, thanks for the patch.

Usually we don't want to add new, possibly-failing cases to old tests;
that makes it harder to identify when the code regressed vs. when
the test changed to test new things.

It would be better to just copy the framework of tests/shared/051
to a new test in shared/ and test only this new inheritance
problem.

Also, I'm confused about this hunk:

> @@ -345,7 +345,12 @@ chacl $acl2 largeaclfile
>  getfacl --numeric largeaclfile | _filter_aces
>  
>  echo "1 above xfs acl max"
> -chacl $acl3 largeaclfile
> +if [ "$FSTYP" != "btrfs" ]; then
> +	chacl $acl3 largeaclfile
> +else
> +	echo 'chacl: cannot set access acl on "largeaclfile": Invalid argument'
> +fi
> +
>  getfacl --numeric largeaclfile | _filter_aces
>  
>  echo "use 16 aces"

What's that about?

Thanks,
-Eric


WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@sandeen.net>
To: Filipe David Borba Manana <fdmanana@gmail.com>
Cc: jbacik@fusionio.com, dsterba@suse.cz,
	linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: add specific test for default ACL inheritance
Date: Wed, 16 Oct 2013 10:10:23 -0500	[thread overview]
Message-ID: <525EAC5F.3040201@sandeen.net> (raw)
In-Reply-To: <1381932296-14674-1-git-send-email-fdmanana@gmail.com>

On 10/16/13 9:04 AM, Filipe David Borba Manana wrote:
> This test is motivated by an issue found by a btrfs user, addressed
> and described by the following GNU/Linux kernel patch:
> 
> https://patchwork.kernel.org/patch/3046931/

Hi Filipe, thanks for the patch.

Usually we don't want to add new, possibly-failing cases to old tests;
that makes it harder to identify when the code regressed vs. when
the test changed to test new things.

It would be better to just copy the framework of tests/shared/051
to a new test in shared/ and test only this new inheritance
problem.

Also, I'm confused about this hunk:

> @@ -345,7 +345,12 @@ chacl $acl2 largeaclfile
>  getfacl --numeric largeaclfile | _filter_aces
>  
>  echo "1 above xfs acl max"
> -chacl $acl3 largeaclfile
> +if [ "$FSTYP" != "btrfs" ]; then
> +	chacl $acl3 largeaclfile
> +else
> +	echo 'chacl: cannot set access acl on "largeaclfile": Invalid argument'
> +fi
> +
>  getfacl --numeric largeaclfile | _filter_aces
>  
>  echo "use 16 aces"

What's that about?

Thanks,
-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-10-16 15:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16 14:04 [PATCH] xfstests: add specific test for default ACL inheritance Filipe David Borba Manana
2013-10-16 14:04 ` Filipe David Borba Manana
2013-10-16 15:10 ` Eric Sandeen [this message]
2013-10-16 15:10   ` Eric Sandeen
2013-10-16 15:14   ` Filipe David Manana
2013-10-16 15:14     ` Filipe David Manana
2013-10-16 15:19     ` Eric Sandeen
2013-10-16 15:19       ` Eric Sandeen
2013-10-16 21:51   ` Dave Chinner
2013-10-16 21:51     ` Dave Chinner
2013-10-16 15:52 ` [PATCH v2] " Filipe David Borba Manana
2013-10-16 15:52   ` Filipe David Borba Manana
2013-10-16 16:09   ` Eric Sandeen
2013-10-16 16:09     ` Eric Sandeen
2013-10-16 16:11     ` Filipe David Manana
2013-10-16 16:11       ` Filipe David Manana
2013-10-16 16:14       ` Eric Sandeen
2013-10-16 16:14         ` Eric Sandeen
2013-10-16 16:11 ` [PATCH] " Christoph Hellwig
2013-10-16 16:11   ` Christoph Hellwig
2013-10-16 16:25 ` [PATCH v3] " Filipe David Borba Manana
2013-10-16 16:25   ` Filipe David Borba Manana
2013-10-16 16:30   ` Eric Sandeen
2013-10-16 16:30     ` Eric Sandeen
2013-10-16 21:24   ` Rich Johnston
2013-10-16 21:24     ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525EAC5F.3040201@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=dsterba@suse.cz \
    --cc=fdmanana@gmail.com \
    --cc=jbacik@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.