All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/2] README: I2C: Fix indent
@ 2013-10-11  7:23 Nobuhiro Iwamatsu
  2013-10-11  7:23 ` [U-Boot] [PATCH 2/2] i2c: sh_i2c: Avoid using I2C prior to relocation Nobuhiro Iwamatsu
  2013-10-17  6:23 ` [U-Boot] [PATCH 1/2] README: I2C: Fix indent Heiko Schocher
  0 siblings, 2 replies; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2013-10-11  7:23 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
 README | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/README b/README
index cee8e2f..77d2e80 100644
--- a/README
+++ b/README
@@ -1987,16 +1987,16 @@ CBFS (Coreboot Filesystem) support
 		    offset CONFIG_SYS_FSL_I2C_SPEED for the i2c speed and
 		    CONFIG_SYS_FSL_I2C_SLAVE for the slave addr of the first
 		    bus.
-                  - If your board supports a second fsl i2c bus, define
+		  - If your board supports a second fsl i2c bus, define
 		    CONFIG_SYS_FSL_I2C2_OFFSET for the register offset
 		    CONFIG_SYS_FSL_I2C2_SPEED for the speed and
 		    CONFIG_SYS_FSL_I2C2_SLAVE for the slave address of the
 		    second bus.
 
 		- drivers/i2c/tegra_i2c.c:
-		 - activate this driver with CONFIG_SYS_I2C_TEGRA
-		 - This driver adds 4 i2c buses with a fix speed from
-		   100000 and the slave addr 0!
+		  - activate this driver with CONFIG_SYS_I2C_TEGRA
+		  - This driver adds 4 i2c buses with a fix speed from
+		    100000 and the slave addr 0!
 
 		- drivers/i2c/ppc4xx_i2c.c
 		  - activate this driver with CONFIG_SYS_I2C_PPC4XX
-- 
1.8.4.rc3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 2/2] i2c: sh_i2c: Avoid using I2C prior to relocation
  2013-10-11  7:23 [U-Boot] [PATCH 1/2] README: I2C: Fix indent Nobuhiro Iwamatsu
@ 2013-10-11  7:23 ` Nobuhiro Iwamatsu
  2013-10-17  6:23   ` Heiko Schocher
  2013-10-17  6:23 ` [U-Boot] [PATCH 1/2] README: I2C: Fix indent Heiko Schocher
  1 sibling, 1 reply; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2013-10-11  7:23 UTC (permalink / raw)
  To: u-boot

If user uses the I2C in before the relocation, board of sh and rmobile
will not start. This will solve this problem.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
 drivers/i2c/sh_i2c.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/sh_i2c.c b/drivers/i2c/sh_i2c.c
index 58f8bf1..808202c 100644
--- a/drivers/i2c/sh_i2c.c
+++ b/drivers/i2c/sh_i2c.c
@@ -1,6 +1,6 @@
 /*
- * Copyright (C) 2011 Renesas Solutions Corp.
- * Copyright (C) 2011 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
+ * Copyright (C) 2011, 2013 Renesas Solutions Corp.
+ * Copyright (C) 2011, 2013 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
  *
  * SPDX-License-Identifier:	GPL-2.0+
  */
@@ -8,6 +8,8 @@
 #include <common.h>
 #include <asm/io.h>
 
+DECLARE_GLOBAL_DATA_PTR;
+
 /* Every register is 32bit aligned, but only 8bits in size */
 #define ureg(name) u8 name; u8 __pad_##name##0; u16 __pad_##name##1;
 struct sh_i2c {
@@ -240,6 +242,10 @@ void i2c_init(int speed, int slaveaddr)
 {
 	int num, denom, tmp;
 
+	/* No i2c support prior to relocation */
+	if (!(gd->flags & GD_FLG_RELOC))
+		return;
+
 #ifdef CONFIG_I2C_MULTI_BUS
 	current_bus = 0;
 #endif
-- 
1.8.4.rc3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 1/2] README: I2C: Fix indent
  2013-10-11  7:23 [U-Boot] [PATCH 1/2] README: I2C: Fix indent Nobuhiro Iwamatsu
  2013-10-11  7:23 ` [U-Boot] [PATCH 2/2] i2c: sh_i2c: Avoid using I2C prior to relocation Nobuhiro Iwamatsu
@ 2013-10-17  6:23 ` Heiko Schocher
  1 sibling, 0 replies; 4+ messages in thread
From: Heiko Schocher @ 2013-10-17  6:23 UTC (permalink / raw)
  To: u-boot

Hello Nobuhiro,

Am 11.10.2013 09:23, schrieb Nobuhiro Iwamatsu:
> Signed-off-by: Nobuhiro Iwamatsu<nobuhiro.iwamatsu.yj@renesas.com>
> ---
>   README | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)

Applied to u-boot-i2c.git

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 2/2] i2c: sh_i2c: Avoid using I2C prior to relocation
  2013-10-11  7:23 ` [U-Boot] [PATCH 2/2] i2c: sh_i2c: Avoid using I2C prior to relocation Nobuhiro Iwamatsu
@ 2013-10-17  6:23   ` Heiko Schocher
  0 siblings, 0 replies; 4+ messages in thread
From: Heiko Schocher @ 2013-10-17  6:23 UTC (permalink / raw)
  To: u-boot

Hello Nobuhiro,

Am 11.10.2013 09:23, schrieb Nobuhiro Iwamatsu:
> If user uses the I2C in before the relocation, board of sh and rmobile
> will not start. This will solve this problem.
>
> Signed-off-by: Nobuhiro Iwamatsu<nobuhiro.iwamatsu.yj@renesas.com>
> ---
>   drivers/i2c/sh_i2c.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)

Applied to u-boot-i2c.git

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-10-17  6:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-11  7:23 [U-Boot] [PATCH 1/2] README: I2C: Fix indent Nobuhiro Iwamatsu
2013-10-11  7:23 ` [U-Boot] [PATCH 2/2] i2c: sh_i2c: Avoid using I2C prior to relocation Nobuhiro Iwamatsu
2013-10-17  6:23   ` Heiko Schocher
2013-10-17  6:23 ` [U-Boot] [PATCH 1/2] README: I2C: Fix indent Heiko Schocher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.