Re: [meta-fsl-arm][PATCH] machines: Let u-boot be PREFERRED_PROVIDER for virtual/bootloader

[Daiane Angolini <daiane.angolini@freescale.com>]

On 10/16/2013 09:08 PM, Khem Raj wrote:
> Lets play the layer with other BSP layers in distro

I think I like your patch, but i don't like your commit log, sorry :(

Would you mind to add 1)Why are you making the patch 2)What error it did 
cause to you?


I don't mind if you keep your sentence as is, but i think something else 
is needed.

Daiane

>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>   conf/machine/include/imx-base.inc | 3 +++
>   conf/machine/include/mxs-base.inc | 3 +++

Please, grep the source in order to double check if there is any other 
machine file that set the PREFERRED_PROVIDER_u-boot. I almost remember, 
but I'm not sure.

>   2 files changed, 6 insertions(+)
>
> diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
> index beeee5f..ff5e96b 100644
> --- a/conf/machine/include/imx-base.inc
> +++ b/conf/machine/include/imx-base.inc
> @@ -88,6 +88,9 @@ PREFERRED_PROVIDER_virtual/libgl_mx6 ?= "gpu-viv-bin-mx6q"
>   PREFERRED_PROVIDER_virtual/libgles1_mx6 ?= "gpu-viv-bin-mx6q"
>   PREFERRED_PROVIDER_virtual/libgles2_mx6 ?= "gpu-viv-bin-mx6q"
>
> +# u-boot
> +PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
> +
>   PREFERRED_PROVIDER_virtual/kernel_mx3 = "linux-fslc"
>
>   EXTRA_IMAGEDEPENDS = "u-boot"
> diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
> index a048f9c..ef3130d 100644
> --- a/conf/machine/include/mxs-base.inc
> +++ b/conf/machine/include/mxs-base.inc
> @@ -11,6 +11,9 @@ SOC_FAMILY = "mxs"
>
>   PREFERRED_PROVIDER_virtual/kernel_mx23 = "linux-fslc"
>
> +# u-boot
> +PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
> +
>   UBOOT_ENTRYPOINT = "0x40008000"
>   UBOOT_MAKE_TARGET = "u-boot.sb"
>   UBOOT_SUFFIX = "sb"
>


-- 
Daiane