* [meta-fsl-arm][PATCH] machines: Let u-boot be PREFERRED_PROVIDER for virtual/bootloader
@ 2013-10-17 0:08 Khem Raj
2013-10-17 13:16 ` Daiane Angolini
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2013-10-17 0:08 UTC (permalink / raw)
To: meta-freescale; +Cc: Khem Raj
Lets play the layer with other BSP layers in distro
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
conf/machine/include/imx-base.inc | 3 +++
conf/machine/include/mxs-base.inc | 3 +++
2 files changed, 6 insertions(+)
diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
index beeee5f..ff5e96b 100644
--- a/conf/machine/include/imx-base.inc
+++ b/conf/machine/include/imx-base.inc
@@ -88,6 +88,9 @@ PREFERRED_PROVIDER_virtual/libgl_mx6 ?= "gpu-viv-bin-mx6q"
PREFERRED_PROVIDER_virtual/libgles1_mx6 ?= "gpu-viv-bin-mx6q"
PREFERRED_PROVIDER_virtual/libgles2_mx6 ?= "gpu-viv-bin-mx6q"
+# u-boot
+PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
+
PREFERRED_PROVIDER_virtual/kernel_mx3 = "linux-fslc"
EXTRA_IMAGEDEPENDS = "u-boot"
diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
index a048f9c..ef3130d 100644
--- a/conf/machine/include/mxs-base.inc
+++ b/conf/machine/include/mxs-base.inc
@@ -11,6 +11,9 @@ SOC_FAMILY = "mxs"
PREFERRED_PROVIDER_virtual/kernel_mx23 = "linux-fslc"
+# u-boot
+PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
+
UBOOT_ENTRYPOINT = "0x40008000"
UBOOT_MAKE_TARGET = "u-boot.sb"
UBOOT_SUFFIX = "sb"
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [meta-fsl-arm][PATCH] machines: Let u-boot be PREFERRED_PROVIDER for virtual/bootloader
2013-10-17 0:08 [meta-fsl-arm][PATCH] machines: Let u-boot be PREFERRED_PROVIDER for virtual/bootloader Khem Raj
@ 2013-10-17 13:16 ` Daiane Angolini
2013-10-17 14:56 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Daiane Angolini @ 2013-10-17 13:16 UTC (permalink / raw)
To: Khem Raj, meta-freescale
On 10/16/2013 09:08 PM, Khem Raj wrote:
> Lets play the layer with other BSP layers in distro
I think I like your patch, but i don't like your commit log, sorry :(
Would you mind to add 1)Why are you making the patch 2)What error it did
cause to you?
I don't mind if you keep your sentence as is, but i think something else
is needed.
Daiane
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> conf/machine/include/imx-base.inc | 3 +++
> conf/machine/include/mxs-base.inc | 3 +++
Please, grep the source in order to double check if there is any other
machine file that set the PREFERRED_PROVIDER_u-boot. I almost remember,
but I'm not sure.
> 2 files changed, 6 insertions(+)
>
> diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
> index beeee5f..ff5e96b 100644
> --- a/conf/machine/include/imx-base.inc
> +++ b/conf/machine/include/imx-base.inc
> @@ -88,6 +88,9 @@ PREFERRED_PROVIDER_virtual/libgl_mx6 ?= "gpu-viv-bin-mx6q"
> PREFERRED_PROVIDER_virtual/libgles1_mx6 ?= "gpu-viv-bin-mx6q"
> PREFERRED_PROVIDER_virtual/libgles2_mx6 ?= "gpu-viv-bin-mx6q"
>
> +# u-boot
> +PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
> +
> PREFERRED_PROVIDER_virtual/kernel_mx3 = "linux-fslc"
>
> EXTRA_IMAGEDEPENDS = "u-boot"
> diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
> index a048f9c..ef3130d 100644
> --- a/conf/machine/include/mxs-base.inc
> +++ b/conf/machine/include/mxs-base.inc
> @@ -11,6 +11,9 @@ SOC_FAMILY = "mxs"
>
> PREFERRED_PROVIDER_virtual/kernel_mx23 = "linux-fslc"
>
> +# u-boot
> +PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
> +
> UBOOT_ENTRYPOINT = "0x40008000"
> UBOOT_MAKE_TARGET = "u-boot.sb"
> UBOOT_SUFFIX = "sb"
>
--
Daiane
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-fsl-arm][PATCH] machines: Let u-boot be PREFERRED_PROVIDER for virtual/bootloader
2013-10-17 13:16 ` Daiane Angolini
@ 2013-10-17 14:56 ` Khem Raj
2013-10-17 15:05 ` Otavio Salvador
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2013-10-17 14:56 UTC (permalink / raw)
To: Daiane Angolini; +Cc: meta-freescale@yoctoproject.org
[-- Attachment #1: Type: text/plain, Size: 2274 bytes --]
On Thursday, October 17, 2013, Daiane Angolini wrote:
> On 10/16/2013 09:08 PM, Khem Raj wrote:
>
>> Lets play the layer with other BSP layers in distro
>>
>
> I think I like your patch, but i don't like your commit log, sorry :(
Yes there is missing bits, it must have been "lets it ..."
nevertheless you can change it to "lets it coexist with other bsp layers in
a multimachine distribution setup"
>
> Would you mind to add 1)Why are you making the patch 2)What error it did
> cause to you?
Bit bake virtual/bootloader would build wrong u-boot thats why the patch
>
>
> I don't mind if you keep your sentence as is, but i think something else
> is needed.
>
> Daiane
>
>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> conf/machine/include/imx-base.**inc | 3 +++
>> conf/machine/include/mxs-base.**inc | 3 +++
>>
>
> Please, grep the source in order to double check if there is any other
> machine file that set the PREFERRED_PROVIDER_u-boot. I almost remember, but
> I'm not sure.
>
> 2 files changed, 6 insertions(+)
>>
>> diff --git a/conf/machine/include/imx-**base.inc
>> b/conf/machine/include/imx-**base.inc
>> index beeee5f..ff5e96b 100644
>> --- a/conf/machine/include/imx-**base.inc
>> +++ b/conf/machine/include/imx-**base.inc
>> @@ -88,6 +88,9 @@ PREFERRED_PROVIDER_virtual/**libgl_mx6 ?=
>> "gpu-viv-bin-mx6q"
>> PREFERRED_PROVIDER_virtual/**libgles1_mx6 ?= "gpu-viv-bin-mx6q"
>> PREFERRED_PROVIDER_virtual/**libgles2_mx6 ?= "gpu-viv-bin-mx6q"
>>
>> +# u-boot
>> +PREFERRED_PROVIDER_virtual/**bootloader ?= "u-boot-fslc"
>> +
>> PREFERRED_PROVIDER_virtual/**kernel_mx3 = "linux-fslc"
>>
>> EXTRA_IMAGEDEPENDS = "u-boot"
>> diff --git a/conf/machine/include/mxs-**base.inc
>> b/conf/machine/include/mxs-**base.inc
>> index a048f9c..ef3130d 100644
>> --- a/conf/machine/include/mxs-**base.inc
>> +++ b/conf/machine/include/mxs-**base.inc
>> @@ -11,6 +11,9 @@ SOC_FAMILY = "mxs"
>>
>> PREFERRED_PROVIDER_virtual/**kernel_mx23 = "linux-fslc"
>>
>> +# u-boot
>> +PREFERRED_PROVIDER_virtual/**bootloader ?= "u-boot-fslc"
>> +
>> UBOOT_ENTRYPOINT = "0x40008000"
>> UBOOT_MAKE_TARGET = "u-boot.sb"
>> UBOOT_SUFFIX = "sb"
>>
>>
>
> --
> Daiane
>
>
[-- Attachment #2: Type: text/html, Size: 3396 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-fsl-arm][PATCH] machines: Let u-boot be PREFERRED_PROVIDER for virtual/bootloader
2013-10-17 14:56 ` Khem Raj
@ 2013-10-17 15:05 ` Otavio Salvador
0 siblings, 0 replies; 4+ messages in thread
From: Otavio Salvador @ 2013-10-17 15:05 UTC (permalink / raw)
To: Khem Raj; +Cc: meta-freescale@yoctoproject.org
On Thu, Oct 17, 2013 at 11:56 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On Thursday, October 17, 2013, Daiane Angolini wrote:
>>
>> On 10/16/2013 09:08 PM, Khem Raj wrote:
>>>
>>> Lets play the layer with other BSP layers in distro
>>
>>
>> I think I like your patch, but i don't like your commit log, sorry :(
>
>
> Yes there is missing bits, it must have been "lets it ..."
> nevertheless you can change it to "lets it coexist with other bsp layers in
> a multimachine distribution setup"
>
>> Would you mind to add 1)Why are you making the patch 2)What error it did
>> cause to you?
>
>
> Bit bake virtual/bootloader would build wrong u-boot thats why the patch
>>
>>
>>
>> I don't mind if you keep your sentence as is, but i think something else
>> is needed.
Please Khem please a v2 with a more extended commitlog and please
check of other boards setting the U-Boot preference; as Daiane said we
have other references for it and it'd be better to fix this in same
patch.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-17 15:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-17 0:08 [meta-fsl-arm][PATCH] machines: Let u-boot be PREFERRED_PROVIDER for virtual/bootloader Khem Raj
2013-10-17 13:16 ` Daiane Angolini
2013-10-17 14:56 ` Khem Raj
2013-10-17 15:05 ` Otavio Salvador
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.