From: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
To: Timur Tabi <timur-N01EOCouUvQ@public.gmane.org>
Cc: Xiubo Li <Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
r65073-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tiwai-l3A5Bk7waGM@public.gmane.org,
b18965-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
b42378-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
oskar-fYPSZ7JpQqsAvxtiuMwx3w@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org,
r64188-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.
Date: Thu, 17 Oct 2013 15:51:54 +0200 [thread overview]
Message-ID: <525FEB7A.5040406@metafoo.de> (raw)
In-Reply-To: <525FE815.1040300-N01EOCouUvQ@public.gmane.org>
On 10/17/2013 03:37 PM, Timur Tabi wrote:
> Lars-Peter Clausen wrote:
>>> >Maybe I've been out of the loop for too long, but why is that a particular
>>> >problem with this driver?
>
>> It is usually something you'd want to check in general to make sure that you
>> don't have multiple device that access the same iomem region at the same
>> time.
>
> I understand that, but I'm trying to figure out why of_iomap() is okay for
> hundreds of other drivers, but not this one. I've used it dozens of times
> myself, without ever worrying about overlapping regions.
The driver would work fine with just of_iomap(). But the resource range
check comes basically for free and it does help to catch errors, so I'd
recommend on using it rather than not using it.
- Lars
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Timur Tabi <timur@tabi.org>
Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org,
linux-doc@vger.kernel.org, tiwai@suse.de, b18965@freescale.com,
linux-kernel@vger.kernel.org, r65073@freescale.com,
LW@KARO-electronics.de, linux@arm.linux.org.uk,
b42378@freescale.com, Xiubo Li <Li.Xiubo@freescale.com>,
oskar@scara.com, grant.likely@linaro.org,
devicetree@vger.kernel.org, ian.campbell@citrix.com,
pawel.moll@arm.com, swarren@wwwdotorg.org,
rob.herring@calxeda.com, broonie@kernel.org,
linux-arm-kernel@lists.infradead.org,
fabio.estevam@freescale.com, lgirdwood@gmail.com,
rob@landley.net, r64188@freescale.com, shawn.guo@linaro.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.
Date: Thu, 17 Oct 2013 15:51:54 +0200 [thread overview]
Message-ID: <525FEB7A.5040406@metafoo.de> (raw)
In-Reply-To: <525FE815.1040300@tabi.org>
On 10/17/2013 03:37 PM, Timur Tabi wrote:
> Lars-Peter Clausen wrote:
>>> >Maybe I've been out of the loop for too long, but why is that a particular
>>> >problem with this driver?
>
>> It is usually something you'd want to check in general to make sure that you
>> don't have multiple device that access the same iomem region at the same
>> time.
>
> I understand that, but I'm trying to figure out why of_iomap() is okay for
> hundreds of other drivers, but not this one. I've used it dozens of times
> myself, without ever worrying about overlapping regions.
The driver would work fine with just of_iomap(). But the resource range
check comes basically for free and it does help to catch errors, so I'd
recommend on using it rather than not using it.
- Lars
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.
Date: Thu, 17 Oct 2013 15:51:54 +0200 [thread overview]
Message-ID: <525FEB7A.5040406@metafoo.de> (raw)
In-Reply-To: <525FE815.1040300@tabi.org>
On 10/17/2013 03:37 PM, Timur Tabi wrote:
> Lars-Peter Clausen wrote:
>>> >Maybe I've been out of the loop for too long, but why is that a particular
>>> >problem with this driver?
>
>> It is usually something you'd want to check in general to make sure that you
>> don't have multiple device that access the same iomem region at the same
>> time.
>
> I understand that, but I'm trying to figure out why of_iomap() is okay for
> hundreds of other drivers, but not this one. I've used it dozens of times
> myself, without ever worrying about overlapping regions.
The driver would work fine with just of_iomap(). But the resource range
check comes basically for free and it does help to catch errors, so I'd
recommend on using it rather than not using it.
- Lars
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Timur Tabi <timur@tabi.org>
Cc: Xiubo Li <Li.Xiubo@freescale.com>,
r65073@freescale.com, lgirdwood@gmail.com, broonie@kernel.org,
mark.rutland@arm.com, alsa-devel@alsa-project.org,
linux-doc@vger.kernel.org, tiwai@suse.de, b18965@freescale.com,
LW@KARO-electronics.de, linux@arm.linux.org.uk,
b42378@freescale.com, oskar@scara.com, grant.likely@linaro.org,
devicetree@vger.kernel.org, ian.campbell@citrix.com,
pawel.moll@arm.com, swarren@wwwdotorg.org,
rob.herring@calxeda.com, linux-arm-kernel@lists.infradead.org,
fabio.estevam@freescale.com, linux-kernel@vger.kernel.org,
rob@landley.net, r64188@freescale.com, shawn.guo@linaro.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.
Date: Thu, 17 Oct 2013 15:51:54 +0200 [thread overview]
Message-ID: <525FEB7A.5040406@metafoo.de> (raw)
In-Reply-To: <525FE815.1040300@tabi.org>
On 10/17/2013 03:37 PM, Timur Tabi wrote:
> Lars-Peter Clausen wrote:
>>> >Maybe I've been out of the loop for too long, but why is that a particular
>>> >problem with this driver?
>
>> It is usually something you'd want to check in general to make sure that you
>> don't have multiple device that access the same iomem region at the same
>> time.
>
> I understand that, but I'm trying to figure out why of_iomap() is okay for
> hundreds of other drivers, but not this one. I've used it dozens of times
> myself, without ever worrying about overlapping regions.
The driver would work fine with just of_iomap(). But the resource range
check comes basically for free and it does help to catch errors, so I'd
recommend on using it rather than not using it.
- Lars
next prev parent reply other threads:[~2013-10-17 13:51 UTC|newest]
Thread overview: 158+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 9:01 [PATCHv1 0/8] ALSA: Add SAI driver and enable SGT15000 codec Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:42 ` Lothar Waßmann
2013-10-17 9:42 ` Lothar Waßmann
2013-10-17 9:42 ` Lothar Waßmann
2013-10-17 9:42 ` Lothar Waßmann
2013-10-18 3:19 ` Xiubo Li-B47053
2013-10-18 3:19 ` Xiubo Li-B47053
2013-10-18 3:19 ` Xiubo Li-B47053
2013-10-17 12:15 ` Timur Tabi
2013-10-17 12:15 ` Timur Tabi
2013-10-17 12:15 ` Timur Tabi
2013-10-17 12:15 ` Timur Tabi
2013-10-17 12:21 ` [alsa-devel] " Lars-Peter Clausen
2013-10-17 12:21 ` Lars-Peter Clausen
2013-10-17 12:21 ` Lars-Peter Clausen
2013-10-17 13:22 ` Timur Tabi
2013-10-17 13:22 ` Timur Tabi
2013-10-17 13:22 ` Timur Tabi
2013-10-17 13:33 ` Lars-Peter Clausen
2013-10-17 13:33 ` Lars-Peter Clausen
2013-10-17 13:33 ` Lars-Peter Clausen
2013-10-17 13:37 ` Timur Tabi
2013-10-17 13:37 ` Timur Tabi
2013-10-17 13:37 ` Timur Tabi
[not found] ` <525FE815.1040300-N01EOCouUvQ@public.gmane.org>
2013-10-17 13:51 ` Lars-Peter Clausen [this message]
2013-10-17 13:51 ` Lars-Peter Clausen
2013-10-17 13:51 ` Lars-Peter Clausen
2013-10-17 13:51 ` Lars-Peter Clausen
2013-10-17 14:10 ` Mark Brown
2013-10-17 14:10 ` [alsa-devel] " Mark Brown
2013-10-17 14:10 ` Mark Brown
2013-10-17 14:10 ` Mark Brown
2013-10-18 3:42 ` Xiubo Li-B47053
2013-10-18 3:42 ` Xiubo Li-B47053
2013-10-18 3:42 ` Xiubo Li-B47053
2013-10-17 17:43 ` Lars-Peter Clausen
2013-10-17 17:43 ` [alsa-devel] " Lars-Peter Clausen
2013-10-17 17:43 ` Lars-Peter Clausen
2013-10-17 17:43 ` Lars-Peter Clausen
2013-10-21 6:59 ` Xiubo Li-B47053
2013-10-21 6:59 ` Xiubo Li-B47053
2013-10-21 6:59 ` Xiubo Li-B47053
2013-10-22 2:20 ` Xiubo Li-B47053
2013-10-22 2:20 ` [alsa-devel] " Xiubo Li-B47053
2013-10-22 2:20 ` Xiubo Li-B47053
2013-10-28 5:58 ` Xiubo Li-B47053
2013-10-28 5:58 ` [alsa-devel] " Xiubo Li-B47053
2013-10-28 5:58 ` Xiubo Li-B47053
2013-11-12 5:02 ` Vinod Koul
2013-11-12 5:02 ` Vinod Koul
2013-11-12 5:02 ` Vinod Koul
2013-11-12 7:35 ` Li Xiubo
2013-11-12 7:35 ` Li Xiubo
2013-11-12 7:35 ` Li Xiubo
2013-11-12 7:59 ` Lars-Peter Clausen
2013-11-12 7:59 ` [alsa-devel] " Lars-Peter Clausen
2013-11-12 7:59 ` Lars-Peter Clausen
2013-10-24 11:05 ` Mark Brown
2013-10-24 11:05 ` Mark Brown
2013-10-24 11:05 ` Mark Brown
2013-10-28 7:15 ` Xiubo Li-B47053
2013-10-28 7:15 ` Xiubo Li-B47053
2013-10-28 7:15 ` Xiubo Li-B47053
2013-10-29 4:00 ` Xiubo Li-B47053
2013-10-29 4:00 ` Xiubo Li-B47053
2013-10-29 4:00 ` Xiubo Li-B47053
2013-10-29 4:02 ` Nicolin Chen
2013-10-29 4:02 ` Nicolin Chen
2013-10-29 4:02 ` Nicolin Chen
2013-10-29 9:31 ` Xiubo Li-B47053
2013-10-29 9:31 ` Xiubo Li-B47053
2013-10-29 9:31 ` Xiubo Li-B47053
2013-10-17 9:01 ` [PATCHv1 2/8] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio Interface node for VF610 Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` [PATCHv1 3/8] ARM: dts: Enables SAI ALSA SoC DAI device for Vybrid VF610 TOWER board Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` [PATCHv1 4/8] Documentation: Add device tree bindings for Freescale SAI Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:56 ` Nicolin Chen
2013-10-17 9:56 ` Nicolin Chen
2013-10-17 9:56 ` Nicolin Chen
2013-10-17 9:56 ` Nicolin Chen
2013-10-21 4:07 ` Xiubo Li-B47053
2013-10-21 4:07 ` Xiubo Li-B47053
2013-10-21 4:07 ` Xiubo Li-B47053
2013-10-17 10:17 ` Lothar Waßmann
2013-10-17 10:17 ` Lothar Waßmann
2013-10-17 10:17 ` Lothar Waßmann
2013-10-17 10:17 ` Lothar Waßmann
2013-10-21 4:15 ` Xiubo Li-B47053
2013-10-21 4:15 ` Xiubo Li-B47053
2013-10-21 4:15 ` Xiubo Li-B47053
2013-10-21 8:11 ` Lothar Waßmann
2013-10-21 8:11 ` Lothar Waßmann
2013-10-21 8:11 ` Lothar Waßmann
2013-10-21 11:21 ` Timur Tabi
2013-10-21 11:21 ` Timur Tabi
2013-10-21 11:21 ` Timur Tabi
2013-10-18 17:28 ` Mark Brown
2013-10-18 17:28 ` Mark Brown
2013-10-18 17:28 ` Mark Brown
2013-10-28 6:07 ` Xiubo Li-B47053
2013-10-28 6:07 ` Xiubo Li-B47053
2013-10-28 6:07 ` Xiubo Li-B47053
2013-10-17 9:01 ` [PATCHv1 6/8] ASoC: fsl: add SGT15000 based audio machine driver Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-18 17:33 ` Mark Brown
2013-10-18 17:33 ` Mark Brown
2013-10-18 17:33 ` Mark Brown
2013-10-21 7:50 ` Xiubo Li-B47053
2013-10-21 7:50 ` Xiubo Li-B47053
2013-10-21 7:50 ` Xiubo Li-B47053
2013-10-17 9:01 ` [PATCHv1 7/8] ARM: dts: Enable SGT15000 codec based audio driver node for VF610 Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` [PATCHv1 8/8] Documentation: Add device tree bindings for Freescale VF610 sound Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:01 ` Xiubo Li
2013-10-17 9:46 ` Lucas Stach
2013-10-17 9:46 ` Lucas Stach
2013-10-17 9:46 ` Lucas Stach
2013-10-18 3:27 ` Xiubo Li-B47053
2013-10-18 3:27 ` Xiubo Li-B47053
2013-10-18 3:27 ` Xiubo Li-B47053
2013-10-18 17:31 ` Mark Brown
2013-10-18 17:31 ` Mark Brown
2013-10-18 17:31 ` Mark Brown
2013-10-21 7:24 ` Xiubo Li-B47053
2013-10-21 7:24 ` Xiubo Li-B47053
2013-10-21 7:24 ` Xiubo Li-B47053
2013-10-22 9:47 ` Mark Brown
2013-10-22 9:47 ` Mark Brown
2013-10-22 9:47 ` Mark Brown
[not found] ` <1382000477-17304-1-git-send-email-Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-10-17 10:22 ` [PATCHv1 0/8] ALSA: Add SAI driver and enable SGT15000 codec Lothar Waßmann
2013-10-17 10:22 ` Lothar Waßmann
2013-10-17 10:22 ` Lothar Waßmann
2013-10-17 10:22 ` Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525FEB7A.5040406@metafoo.de \
--to=lars-qo5elluwu/uelga04laivw@public.gmane.org \
--cc=LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org \
--cc=Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=b18965-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=b42378-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=oskar-fYPSZ7JpQqsAvxtiuMwx3w@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=r64188-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=r65073-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=timur-N01EOCouUvQ@public.gmane.org \
--cc=tiwai-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.