[patch] hwmon: (w83793) Clean up a signedness issue

[patch] hwmon: (w83793) Clean up a signedness issue

[Dan Carpenter]

We cap the upper bound of "mtimeout" but since it's signed we should
check for negative values as well.  The mistake is harmless.  But I have
changed it to unsigned as a cleanup.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/hwmon/w83793.c b/drivers/hwmon/w83793.c
index b6470ec..9d63d71 100644
--- a/drivers/hwmon/w83793.c
+++ b/drivers/hwmon/w83793.c
@@ -1199,7 +1199,8 @@ static void w83793_init_client(struct i2c_client *client)
 
 static int watchdog_set_timeout(struct w83793_data *data, int timeout)
 {
-	int ret, mtimeout;
+	unsigned int mtimeout;
+	int ret;
 
 	mtimeout = DIV_ROUND_UP(timeout, 60);
 

[lm-sensors] [patch] hwmon: (w83793) Clean up a signedness issue

[Dan Carpenter]

We cap the upper bound of "mtimeout" but since it's signed we should
check for negative values as well.  The mistake is harmless.  But I have
changed it to unsigned as a cleanup.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/hwmon/w83793.c b/drivers/hwmon/w83793.c
index b6470ec..9d63d71 100644
--- a/drivers/hwmon/w83793.c
+++ b/drivers/hwmon/w83793.c
@@ -1199,7 +1199,8 @@ static void w83793_init_client(struct i2c_client *client)
 
 static int watchdog_set_timeout(struct w83793_data *data, int timeout)
 {
-	int ret, mtimeout;
+	unsigned int mtimeout;
+	int ret;
 
 	mtimeout = DIV_ROUND_UP(timeout, 60);
 

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [patch] hwmon: (w83793) Clean up a signedness issue

[Guenter Roeck]

On 10/19/2013 02:12 AM, Dan Carpenter wrote:
> We cap the upper bound of "mtimeout" but since it's signed we should
> check for negative values as well.  The mistake is harmless.  But I have
> changed it to unsigned as a cleanup.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Applied to -next.

Thanks,
Guenter

Re: [lm-sensors] [patch] hwmon: (w83793) Clean up a signedness issue

[Guenter Roeck]

On 10/19/2013 02:12 AM, Dan Carpenter wrote:
> We cap the upper bound of "mtimeout" but since it's signed we should
> check for negative values as well.  The mistake is harmless.  But I have
> changed it to unsigned as a cleanup.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Applied to -next.

Thanks,
Guenter



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors