Re: [PATCH v3 1/7] PM / Domains: Add DT bindings for the R-Car System Controller

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Geert,

Thank you for the patch.

On Wednesday 09 March 2016 20:18:36 Geert Uytterhoeven wrote:
> The Renesas R-Car System Controller provides power management for the
> CPU cores and various coprocessors, following the generic PM domain
> bindings in Documentation/devicetree/bindings/power/power_domain.txt.
> 
> This supports R-Car Gen1 (H1), Gen2, and Gen3.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3:
>   - Move power area hierarchy from DT to C (cfr. DT bindings for Renesas
>     CPG/MSSR), and switch to "#power-domain-cells = <1>",
>   - Drop fallback compatibility strings, as the bindings are
>     SoC-specific,
>   - Rename from renesas,sysc-rcar.txt to renesas,rcar-sysc.txt,
> 
> v2:
>   - Add R-Car H3 (r8a7795) support,
>   - Use "renesas,<type>-sysc" instead of "renesas,sysc-<type>",
>   - Add fallback compatibility strings for R-Car Gen2 and Gen3.
> ---
>  .../bindings/power/renesas,rcar-sysc.txt           | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt
> 
> diff --git a/Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt
> b/Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt new file
> mode 100644
> index 0000000000000000..1765fd37c3658b60
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt
> @@ -0,0 +1,48 @@
> +DT bindings for the Renesas R-Car System Controller
> +
> +== System Controller Node ==
> +
> +The R-Car System Controller provides power management for the CPU cores and
> +various coprocessors.
> +
> +Required properties:
> +  - compatible: Must contain one or more of the following:

I'd be curious to see a use case for specifying more than one ;-) I think you 
can phrase it as "Must contain exactly one of the following".

Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +      - "renesas,r8a7779-sysc" (R-Car H1)
> +      - "renesas,r8a7790-sysc" (R-Car H2)
> +      - "renesas,r8a7791-sysc" (R-Car M2-W)
> +      - "renesas,r8a7792-sysc" (R-Car V2H)
> +      - "renesas,r8a7793-sysc" (R-Car M2-N)
> +      - "renesas,r8a7794-sysc" (R-Car E2)
> +      - "renesas,r8a7795-sysc" (R-Car H3)
> +  - reg: Address start and address range for the device.
> +  - #power-domain-cells: Must be 1.
> +
> +
> +Example:
> +
> +	sysc: system-controller@e6180000 {
> +		compatible = "renesas,r8a7791-sysc";
> +		reg = <0 0xe6180000 0 0x0200>;
> +		#power-domain-cells = <1>;
> +	};
> +
> +
> +== PM Domain Consumers ==
> +
> +Devices residing in a power area must refer to that power area, as
> documented +by the generic PM domain bindings in
> +Documentation/devicetree/bindings/power/power_domain.txt.
> +
> +Required properties:
> +  - power-domains: A phandle and symbolic PM domain specifier, as defined
> in
> +		   <dt-bindings/power/r8a77*-sysc.h>.
> +
> +
> +Example:
> +
> +	L2_CA15: cache-controller@0 {
> +		compatible = "cache";
> +		power-domains = <&sysc R8A7791_PD_CA15_SCU>;
> +		cache-unified;
> +		cache-level = <2>;
> +	};

-- 
Regards,

Laurent Pinchart