From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, netfilter@vger.kernel.org,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 00/23 v2] cleanup: introduce br/netdev/netif/wiphy_<foo>_ratelimited() and use them to simplify code
Date: Mon, 21 Oct 2013 19:26:24 +0800 [thread overview]
Message-ID: <52650F60.5080402@huawei.com> (raw)
In-Reply-To: <1382069482.22110.164.camel@joe-AO722>
On 10/18 12:11, Joe Perches wrote:
> (resending to lists only because of multiple X's in the subject line)
>
> On Fri, 2013-10-18 at 11:52 +0800, Kefeng Wang wrote:
>> v1-v2:
>>
>> Introduce macro br/netdev/netif/wiphy_XXX_ratelimited() according
>> to Joe Perches's advice. The macros are similar to net_XXX_ratelimited()
>> which is more clarifying than net_ratelimited_function(), then use them
>> to simplify code.
>
> There are some conceptual differences between these
> implementations and other <foo>_ratelimited uses.
>
> For every other subsystem but net, there is a per-location
> struct ratelimit_state.
yes, but I think I just changed net subsystem. Macro DEFINE_RATELIMIT_STATE used
DEFAULT_RATELIMIT_INTERVAL and DEFAULT_RATELIMIT_BURST, so what do you think?
Could anyone give me some advises ?
> Here you've made the global net_ratelimit_state replace all
> of these individual structs so there is some new interaction.
>
> Dunno if that's good or bad.
>
>
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Joe Perches <joe@perches.com>
Cc: <linux-kernel@vger.kernel.org>, <netfilter@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 00/23 v2] cleanup: introduce br/netdev/netif/wiphy_<foo>_ratelimited() and use them to simplify code
Date: Mon, 21 Oct 2013 19:26:24 +0800 [thread overview]
Message-ID: <52650F60.5080402@huawei.com> (raw)
In-Reply-To: <1382069482.22110.164.camel@joe-AO722>
On 10/18 12:11, Joe Perches wrote:
> (resending to lists only because of multiple X's in the subject line)
>
> On Fri, 2013-10-18 at 11:52 +0800, Kefeng Wang wrote:
>> v1-v2:
>>
>> Introduce macro br/netdev/netif/wiphy_XXX_ratelimited() according
>> to Joe Perches's advice. The macros are similar to net_XXX_ratelimited()
>> which is more clarifying than net_ratelimited_function(), then use them
>> to simplify code.
>
> There are some conceptual differences between these
> implementations and other <foo>_ratelimited uses.
>
> For every other subsystem but net, there is a per-location
> struct ratelimit_state.
yes, but I think I just changed net subsystem. Macro DEFINE_RATELIMIT_STATE used
DEFAULT_RATELIMIT_INTERVAL and DEFAULT_RATELIMIT_BURST, so what do you think?
Could anyone give me some advises ?
> Here you've made the global net_ratelimit_state replace all
> of these individual structs so there is some new interaction.
>
> Dunno if that's good or bad.
>
>
>
>
>
next prev parent reply other threads:[~2013-10-21 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1382068363-10088-1-git-send-email-wangkefeng.wang@huawei.com>
[not found] ` <1382068363-10088-1-git-send-email-wangkefeng.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-10-18 4:11 ` [PATCH 00/23 v2] cleanup: introduce br/netdev/netif/wiphy_<foo>_ratelimited() and use them to simplify code Joe Perches
2013-10-18 4:11 ` Joe Perches
2013-10-21 11:26 ` Kefeng Wang [this message]
2013-10-21 11:26 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52650F60.5080402@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.