All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] InfiniBand: add missing break between cases
@ 2005-02-03  5:40 Roland Dreier
  2005-02-03 19:48 ` [PATCH] InfiniBand: remove unbalance refcnt decrement Roland Dreier
  0 siblings, 1 reply; 2+ messages in thread
From: Roland Dreier @ 2005-02-03  5:40 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel, openib-general

From: Libor Michalek <libor@topspin.com>

Add a missing break statement between RC and UD cases in mthca_post_send().
This fixes a possible oops for protocols that use the RC transport.

Signed-off-by: Libor Michalek <libor@topspin.com>
Signed-off-by: Roland Dreier <roland@topspin.com>

--- linux-bk.orig/drivers/infiniband/hw/mthca/mthca_qp.c	2005-01-28 11:11:02.000000000 -0800
+++ linux-bk/drivers/infiniband/hw/mthca/mthca_qp.c	2005-02-02 21:35:09.683871535 -0800
@@ -1323,6 +1323,8 @@
 				break;
 			}
 
+			break;
+
 		case UD:
 			((struct mthca_ud_seg *) wqe)->lkey =
 				cpu_to_be32(to_mah(wr->wr.ud.ah)->key);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] InfiniBand: remove unbalance refcnt decrement
  2005-02-03  5:40 [PATCH] InfiniBand: add missing break between cases Roland Dreier
@ 2005-02-03 19:48 ` Roland Dreier
  0 siblings, 0 replies; 2+ messages in thread
From: Roland Dreier @ 2005-02-03 19:48 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel, openib-general

From: Michael S. Tsirkin <mst@mellanox.co.il>

Fix unbalanced QP reference count decrement (introduced with QP lock
optimization patch)

Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
Signed-off-by: Roland Dreier <roland@topspin.com>

--- linux-bk.orig/drivers/infiniband/hw/mthca/mthca_cq.c	2005-01-28 11:11:03.000000000 -0800
+++ linux-bk/drivers/infiniband/hw/mthca/mthca_cq.c	2005-02-03 11:47:39.300426349 -0800
@@ -422,8 +422,6 @@
 				*freed = 0;
 			}
 			spin_unlock(&(*cur_qp)->lock);
-			if (atomic_dec_and_test(&(*cur_qp)->refcount))
-				wake_up(&(*cur_qp)->wait);
 		}
 
 		spin_lock(&dev->qp_table.lock);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-02-03 20:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-03  5:40 [PATCH] InfiniBand: add missing break between cases Roland Dreier
2005-02-03 19:48 ` [PATCH] InfiniBand: remove unbalance refcnt decrement Roland Dreier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.