All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org, edoutreleau@genoscope.cns.fr
Subject: Re: [PATCH] mount.nfs: print an error message when remount attempt fails
Date: Mon, 21 Oct 2013 13:34:12 -0400	[thread overview]
Message-ID: <52656594.4080907@RedHat.com> (raw)
In-Reply-To: <1382363229-6343-1-git-send-email-jlayton@redhat.com>



On 21/10/13 09:47, Jeff Layton wrote:
> Currently, mount.nfs returns an error code, but doesn't print anything
> when this occurs.
> 
> Reported-by: Eric Doutreleau <edoutreleau@genoscope.cns.fr>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
committed... 

steved.
> ---
>  utils/mount/stropts.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index 1dc38ef..a642394 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -1004,6 +1004,7 @@ static int nfs_remount(struct nfsmount_info *mi)
>  {
>  	if (nfs_sys_mount(mi, mi->options))
>  		return EX_SUCCESS;
> +	mount_error(mi->spec, mi->node, errno);
>  	return EX_FAIL;
>  }
>  
> -- 1.8.3.1
> 

      reply	other threads:[~2013-10-21 17:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21 13:47 [PATCH] mount.nfs: print an error message when remount attempt fails Jeff Layton
2013-10-21 17:34 ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52656594.4080907@RedHat.com \
    --to=steved@redhat.com \
    --cc=edoutreleau@genoscope.cns.fr \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.