All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mount.nfs: print an error message when remount attempt fails
@ 2013-10-21 13:47 Jeff Layton
  2013-10-21 17:34 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Layton @ 2013-10-21 13:47 UTC (permalink / raw)
  To: steved; +Cc: linux-nfs, edoutreleau

Currently, mount.nfs returns an error code, but doesn't print anything
when this occurs.

Reported-by: Eric Doutreleau <edoutreleau@genoscope.cns.fr>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
 utils/mount/stropts.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
index 1dc38ef..a642394 100644
--- a/utils/mount/stropts.c
+++ b/utils/mount/stropts.c
@@ -1004,6 +1004,7 @@ static int nfs_remount(struct nfsmount_info *mi)
 {
 	if (nfs_sys_mount(mi, mi->options))
 		return EX_SUCCESS;
+	mount_error(mi->spec, mi->node, errno);
 	return EX_FAIL;
 }
 
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mount.nfs: print an error message when remount attempt fails
  2013-10-21 13:47 [PATCH] mount.nfs: print an error message when remount attempt fails Jeff Layton
@ 2013-10-21 17:34 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2013-10-21 17:34 UTC (permalink / raw)
  To: Jeff Layton; +Cc: linux-nfs, edoutreleau



On 21/10/13 09:47, Jeff Layton wrote:
> Currently, mount.nfs returns an error code, but doesn't print anything
> when this occurs.
> 
> Reported-by: Eric Doutreleau <edoutreleau@genoscope.cns.fr>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
committed... 

steved.
> ---
>  utils/mount/stropts.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index 1dc38ef..a642394 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -1004,6 +1004,7 @@ static int nfs_remount(struct nfsmount_info *mi)
>  {
>  	if (nfs_sys_mount(mi, mi->options))
>  		return EX_SUCCESS;
> +	mount_error(mi->spec, mi->node, errno);
>  	return EX_FAIL;
>  }
>  
> -- 1.8.3.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-10-21 17:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-21 13:47 [PATCH] mount.nfs: print an error message when remount attempt fails Jeff Layton
2013-10-21 17:34 ` Steve Dickson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.