All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: use -F for mkfs.ext4 in btrfs/012
Date: Mon, 21 Oct 2013 14:59:33 -0500	[thread overview]
Message-ID: <526587A5.4000602@sandeen.net> (raw)
In-Reply-To: <1382371516-13720-1-git-send-email-jbacik@fusionio.com>

On 10/21/13 11:05 AM, Josef Bacik wrote:
> I noticed this test was hanging because mkfs.ext4 wanted to make sure it was ok
> to mkfs an entire device.  We need -F so it doesn't ask this question.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  tests/btrfs/012 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/btrfs/012 b/tests/btrfs/012
> index de90149..f7e5da5 100755
> --- a/tests/btrfs/012
> +++ b/tests/btrfs/012
> @@ -65,7 +65,7 @@ _require_command $E2FSCK_PROG e2fsck
>  rm -f $seqres.full
>  
>  # Create & populate an ext4 filesystem
> -$MKFS_EXT4_PROG -b 4096 $SCRATCH_DEV > $seqres.full 2>&1 || \
> +$MKFS_EXT4_PROG -F -b 4096 $SCRATCH_DEV > $seqres.full 2>&1 || \
>  	_notrun "Could not create ext4 filesystem"
>  # Manual mount so we don't use -t btrfs or selinux context
>  mount -t ext4 $SCRATCH_DEV $SCRATCH_MNT
> 


WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@sandeen.net>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: use -F for mkfs.ext4 in btrfs/012
Date: Mon, 21 Oct 2013 14:59:33 -0500	[thread overview]
Message-ID: <526587A5.4000602@sandeen.net> (raw)
In-Reply-To: <1382371516-13720-1-git-send-email-jbacik@fusionio.com>

On 10/21/13 11:05 AM, Josef Bacik wrote:
> I noticed this test was hanging because mkfs.ext4 wanted to make sure it was ok
> to mkfs an entire device.  We need -F so it doesn't ask this question.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  tests/btrfs/012 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/btrfs/012 b/tests/btrfs/012
> index de90149..f7e5da5 100755
> --- a/tests/btrfs/012
> +++ b/tests/btrfs/012
> @@ -65,7 +65,7 @@ _require_command $E2FSCK_PROG e2fsck
>  rm -f $seqres.full
>  
>  # Create & populate an ext4 filesystem
> -$MKFS_EXT4_PROG -b 4096 $SCRATCH_DEV > $seqres.full 2>&1 || \
> +$MKFS_EXT4_PROG -F -b 4096 $SCRATCH_DEV > $seqres.full 2>&1 || \
>  	_notrun "Could not create ext4 filesystem"
>  # Manual mount so we don't use -t btrfs or selinux context
>  mount -t ext4 $SCRATCH_DEV $SCRATCH_MNT
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-10-21 19:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21 16:05 [PATCH] xfstests: use -F for mkfs.ext4 in btrfs/012 Josef Bacik
2013-10-21 16:05 ` Josef Bacik
2013-10-21 19:59 ` Eric Sandeen [this message]
2013-10-21 19:59   ` Eric Sandeen
2013-10-22 21:19 ` Rich Johnston
2013-10-22 21:19   ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=526587A5.4000602@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=jbacik@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.