Re: [Qemu-devel] [v2 03/13] Add lxvdsx

[Paolo Bonzini <pbonzini@redhat.com>]

Il 11/10/2013 13:58, Tom Musta ha scritto:
> This patch adds the Load VSX Vector Doubleword & Splat Indexed
> (lxvdsx) instruction.
> 
> Signed-off-by: Tom Musta <tommusta@gmail.com>
> ---
>  target-ppc/translate.c |   16 ++++++++++++++++
>  1 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 6ee0d80..e5021cf 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -7038,6 +7038,21 @@ static void gen_lxvd2x(DisasContext *ctx)
>      tcg_temp_free(EA);
>  }
> 
> +static void gen_lxvdsx(DisasContext *ctx)
> +{
> +    TCGv EA;
> +    if (unlikely(!ctx->vsx_enabled)) {
> +        gen_exception(ctx, POWERPC_EXCP_VSXU);
> +        return;
> +    }
> +    gen_set_access_type(ctx, ACCESS_INT);
> +    EA = tcg_temp_new();
> +    gen_addr_reg_index(ctx, EA);
> +    gen_qemu_ld64(ctx, cpu_vsrh(xT(ctx->opcode)), EA);
> +    tcg_gen_mov_tl(cpu_vsrl(xT(ctx->opcode)), cpu_vsrh(xT(ctx->opcode)));
> +    tcg_temp_free(EA);
> +}
> +
>  static void gen_stxvd2x(DisasContext *ctx)
>  {
>      TCGv EA;
> @@ -9535,6 +9550,7 @@ GEN_VAFORM_PAIRED(vmaddfp, vnmsubfp, 23),
> 
>  GEN_HANDLER_E(lxsdx, 0x1F, 0x0C, 0x12, 0, PPC_NONE, PPC2_VSX),
>  GEN_HANDLER_E(lxvd2x, 0x1F, 0x0C, 0x1A, 0, PPC_NONE, PPC2_VSX),
> +GEN_HANDLER_E(lxvdsx, 0x1F, 0x0C, 0x0A, 0, PPC_NONE, PPC2_VSX),
> 
>  GEN_HANDLER_E(stxvd2x, 0x1F, 0xC, 0x1E, 0, PPC_NONE, PPC2_VSX),
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>